Some more minor clean up (#215)

* General clean up

- Reduced woodcutting code by alot, reverted the array to an enum
- Moved the login player method to the packet sender
- Deleted some dead code/cleaned up

* More random cleanup/refractoring

- Moved combat constants to combatconstants.java
- Moved dialogue options to dialogueoptions.java
- Deleted more dead code

* Replaced some poorly written methods

- refreshSkill, levelUp, and getTotalLevel all used way too much code for such a simple function so cleaned it up
- deleted a few other bits of dead code

* Fight caves

- Should fix fight caves npcs nulling out in the middle of your waves if they are too far away
- Also removed some unneeded scynchronization in itemassistant.java

* Gates

- Started cleaning up gate system, still can be improved a lot more

2006Redone Server/src/com/rebotted/net/packets/impl/ClickNPC.java

@@ -1,9 +1,9 @@
 package com.rebotted.net.packets.impl;
 
-import com.rebotted.GameConstants;
 import com.rebotted.event.CycleEvent;
 import com.rebotted.event.CycleEventContainer;
 import com.rebotted.event.CycleEventHandler;
+import com.rebotted.game.content.combat.CombatConstants;
 import com.rebotted.game.content.combat.magic.MagicData;
 import com.rebotted.game.content.combat.range.RangeData;
 import com.rebotted.game.content.skills.thieving.Pickpocket;
@@ -124,7 +124,7 @@ public class ClickNPC implements PacketType {
 				break;
 			}
 			if (RangeData.correctBowAndArrows(client) < client.playerEquipment[client.playerArrows]
-					&& GameConstants.CORRECT_ARROWS
+					&& CombatConstants.CORRECT_ARROWS
 					&& usingBow
 					&& !RangeData.usingCrystalBow(client)
 					&& client.playerEquipment[client.playerWeapon] != 9185) {