mirror of
https://github.com/2006-Scape/2006Scape.git
synced 2026-07-04 16:49:04 +00:00
Replace a bunch of magic numbers & Fix Mackerel Spelling (#559)
* Convert Some NPCActions Magic Numbers * IntelliJ Reformat NpcActions.java * Convert Magic Numbers In Dye.java * Convert More Magic Numbers In NpcActions.java * Convert More NpcActions.java Magic Numbers * Plugins: Replace Magic Numbers * Skills: Cooking: Replaced all Item/Object Magic Numbers & Fixed Mackerel spelling * Food: Fixed Mackerel spelling * Skills: Fishing: Replace Magic Numbers * Skills: Mining: Replace Magic Numbers * IntelliJ Code Reformat Changed Files
This commit is contained in:
@@ -1,77 +1,80 @@
|
||||
package com.rs2.game.items.impl;
|
||||
|
||||
import com.rs2.game.items.ItemData;
|
||||
import com.rs2.GameConstants;
|
||||
import com.rs2.game.items.ItemAssistant;
|
||||
import com.rs2.game.items.ItemData;
|
||||
import com.rs2.game.players.Player;
|
||||
|
||||
import static com.rs2.game.content.StaticItemList.*;
|
||||
|
||||
/**
|
||||
* Dye.java
|
||||
*
|
||||
* @author Andrew (Mr Extremez)
|
||||
*/
|
||||
|
||||
|
||||
public enum Dye {
|
||||
|
||||
RED_CAPE(1763, 1007),
|
||||
BLUE_CAPE(1767, 1021),
|
||||
GREEN_CAPE(1771, 1027),
|
||||
PINK_CAPE(6955, 6959),
|
||||
ORANGE_CAPE(1769, 1031),
|
||||
YELLOW_CAPE(1765, 1023),
|
||||
PURPLE_CAPE(1773, 1029);
|
||||
|
||||
int reward, itemUsed;
|
||||
|
||||
private Dye(int itemUsed, int reward) {
|
||||
this.itemUsed = itemUsed;
|
||||
this.reward = reward;
|
||||
}
|
||||
|
||||
private int getItemUsed() {
|
||||
return itemUsed;
|
||||
}
|
||||
|
||||
private int getReward() {
|
||||
return reward;
|
||||
}
|
||||
|
||||
//blue+yellow =green
|
||||
//red+blue = purple
|
||||
|
||||
public static final int[][] MAIL_DATA = {
|
||||
{1769, 288, 286},
|
||||
{1769, 287, 286},
|
||||
{1767, 288, 287},
|
||||
{1767, 286, 287},
|
||||
{1767, 1765, 1771},
|
||||
{1763, 1767, 1773}
|
||||
};
|
||||
|
||||
public static boolean blockDye(Player player, Dye dye, int itemUsed, int useWith) {
|
||||
if (itemUsed == dye.getItemUsed() && ItemAssistant.getItemName(useWith).equalsIgnoreCase("Cape") && ItemData.itemIsNote[useWith]) {
|
||||
player.getPacketSender().sendMessage("You can't dye a noted cape.");
|
||||
return true;
|
||||
} else if (itemUsed == dye.getItemUsed() && ItemAssistant.getItemName(useWith).equalsIgnoreCase("Cape") && useWith == dye.getReward() && !ItemData.itemIsNote[useWith]) {
|
||||
player.getPacketSender().sendMessage("That cape is already that color.");
|
||||
return true;
|
||||
} else if (itemUsed == dye.getItemUsed() && !ItemAssistant.getItemName(useWith).equalsIgnoreCase("Cape")) {
|
||||
return true;
|
||||
}
|
||||
return false;
|
||||
}
|
||||
|
||||
public static void dyeItem(Player player, int itemUsed, int useWith) {
|
||||
for (Dye cape: Dye.values()) {
|
||||
if (blockDye(player, cape, itemUsed, useWith)) {
|
||||
return;
|
||||
}
|
||||
if (itemUsed == cape.getItemUsed() && ItemAssistant.getItemName(useWith).equalsIgnoreCase("Cape") && !ItemData.itemIsNote[useWith] && useWith != cape.getReward()) {
|
||||
player.getItemAssistant().deleteItem(itemUsed, 1);
|
||||
player.getItemAssistant().deleteItem(useWith, 1);
|
||||
player.getItemAssistant().addItem(cape.getReward(), 1);
|
||||
player.getPlayerAssistant().addSkillXP(2.5, GameConstants.CRAFTING);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
RED_CAPE(RED_DYE, CAPE),
|
||||
BLUE_CAPE(BLUE_DYE, CAPE_1021),
|
||||
GREEN_CAPE(GREEN_DYE, CAPE_1027),
|
||||
PINK_CAPE(PINK_DYE, CAPE_6959),
|
||||
ORANGE_CAPE(ORANGE_DYE, CAPE_1031),
|
||||
YELLOW_CAPE(YELLOW_DYE, CAPE_1023),
|
||||
PURPLE_CAPE(PURPLE_DYE, CAPE_1029);
|
||||
|
||||
int reward, itemUsed;
|
||||
|
||||
private Dye(int itemUsed, int reward) {
|
||||
this.itemUsed = itemUsed;
|
||||
this.reward = reward;
|
||||
}
|
||||
|
||||
private int getItemUsed() {
|
||||
return itemUsed;
|
||||
}
|
||||
|
||||
private int getReward() {
|
||||
return reward;
|
||||
}
|
||||
|
||||
//blue+yellow =green
|
||||
//red+blue = purple
|
||||
|
||||
public static final int[][] MAIL_DATA = {
|
||||
{ORANGE_DYE, GOBLIN_MAIL, ORANGE_GOBLIN_MAIL},
|
||||
{ORANGE_DYE, BLUE_GOBLIN_MAIL, ORANGE_GOBLIN_MAIL},
|
||||
{BLUE_DYE, GOBLIN_MAIL, BLUE_GOBLIN_MAIL},
|
||||
{BLUE_DYE, ORANGE_GOBLIN_MAIL, BLUE_GOBLIN_MAIL},
|
||||
{BLUE_DYE, YELLOW_DYE, GREEN_DYE},
|
||||
{RED_DYE, BLUE_DYE, PURPLE_DYE}
|
||||
};
|
||||
|
||||
public static boolean blockDye(Player player, Dye dye, int itemUsed, int useWith) {
|
||||
if (itemUsed == dye.getItemUsed() && ItemAssistant.getItemName(useWith).equalsIgnoreCase("Cape") && ItemData.itemIsNote[useWith]) {
|
||||
player.getPacketSender().sendMessage("You can't dye a noted cape.");
|
||||
return true;
|
||||
} else if (itemUsed == dye.getItemUsed() && ItemAssistant.getItemName(useWith).equalsIgnoreCase("Cape") && useWith == dye.getReward() && !ItemData.itemIsNote[useWith]) {
|
||||
player.getPacketSender().sendMessage("That cape is already that color.");
|
||||
return true;
|
||||
} else if (itemUsed == dye.getItemUsed() && !ItemAssistant.getItemName(useWith).equalsIgnoreCase("Cape")) {
|
||||
return true;
|
||||
}
|
||||
return false;
|
||||
}
|
||||
|
||||
public static void dyeItem(Player player, int itemUsed, int useWith) {
|
||||
for (Dye cape : Dye.values()) {
|
||||
if (blockDye(player, cape, itemUsed, useWith)) {
|
||||
return;
|
||||
}
|
||||
if (itemUsed == cape.getItemUsed() && ItemAssistant.getItemName(useWith).equalsIgnoreCase("Cape") && !ItemData.itemIsNote[useWith] && useWith != cape.getReward()) {
|
||||
player.getItemAssistant().deleteItem(itemUsed, 1);
|
||||
player.getItemAssistant().deleteItem(useWith, 1);
|
||||
player.getItemAssistant().addItem(cape.getReward(), 1);
|
||||
player.getPlayerAssistant().addSkillXP(2.5, GameConstants.CRAFTING);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
}
|
||||
Reference in New Issue
Block a user