We should merge both develop and screenshots branches before merging this. Also need to add QoL toggle for this first before merging. The rationale behind this feature is basically a poor man's player exports. Also, there are official clients out there like RL that take automated screenshots on levelup, on kill and on death, etc so IMO this isn't too unheard of as a feature.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/2006-Scape/2006Scape/pull/652
**Author:** [@ipkpjersi](https://github.com/ipkpjersi)
**Created:** 1/6/2024
**Status:** ❌ Closed
**Base:** `master` ← **Head:** `automatic-screenshots-qol`
---
### 📝 Commits (10+)
- [`863ffde`](https://github.com/2006-Scape/2006Scape/commit/863ffdee34c900e3096ab986ed94a23ccc6afd82) Added ability to take screenshots
- [`4c65665`](https://github.com/2006-Scape/2006Scape/commit/4c65665928c7b3f85f3386639900a1470203e9a6) Removed duplicate screenshot warning message
- [`9dc9625`](https://github.com/2006-Scape/2006Scape/commit/9dc962560febde1aab06fed8ecaec0d487b143e6) Added subfolders option for screenshots
- [`02a1707`](https://github.com/2006-Scape/2006Scape/commit/02a1707b95d90b85137d48940d79063006d801d3) Removed unused code
- [`4858e16`](https://github.com/2006-Scape/2006Scape/commit/4858e16c1ee35f2dc5f2b5e8fbbc1d657c2c08ae) Added check for screenshots
- [`577b6af`](https://github.com/2006-Scape/2006Scape/commit/577b6afa99a6d87bf6b8f3645be28c4902b18a99) Added automatic screenshots
- [`c1e9d07`](https://github.com/2006-Scape/2006Scape/commit/c1e9d07affe648bdfea12a9b0d8343628595b00b) Updated TODOs
- [`0b694a2`](https://github.com/2006-Scape/2006Scape/commit/0b694a26d965c2b21597d435e5f5506a7d63244c) Fixed screenshots NPE when logged out
- [`edfb4ec`](https://github.com/2006-Scape/2006Scape/commit/edfb4ec91df0069158427ce0e3231cb60c70e66a) Added Local to titlebar when running locally
- [`ab60583`](https://github.com/2006-Scape/2006Scape/commit/ab60583cad40df39ec676e1a1b2ee2bc485b322e) Added automatic screenshots
### 📊 Changes
**2 files changed** (+72 additions, -2 deletions)
<details>
<summary>View changed files</summary>
📝 `2006Scape Client/src/main/java/Game.java` (+71 -1)
📝 `2006Scape Client/src/main/java/RSFrame.java` (+1 -1)
</details>
### 📄 Description
We should merge both develop and screenshots branches before merging this. Also need to add QoL toggle for this first before merging. The rationale behind this feature is basically a poor man's player exports. Also, there are official clients out there like RL that take automated screenshots on levelup, on kill and on death, etc so IMO this isn't too unheard of as a feature.
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/2006-Scape/2006Scape/pull/652
Author: @ipkpjersi
Created: 1/6/2024
Status: ❌ Closed
Base:
master← Head:automatic-screenshots-qol📝 Commits (10+)
863ffdeAdded ability to take screenshots4c65665Removed duplicate screenshot warning message9dc9625Added subfolders option for screenshots02a1707Removed unused code4858e16Added check for screenshots577b6afAdded automatic screenshotsc1e9d07Updated TODOs0b694a2Fixed screenshots NPE when logged outedfb4ecAdded Local to titlebar when running locallyab60583Added automatic screenshots📊 Changes
2 files changed (+72 additions, -2 deletions)
View changed files
📝
2006Scape Client/src/main/java/Game.java(+71 -1)📝
2006Scape Client/src/main/java/RSFrame.java(+1 -1)📄 Description
We should merge both develop and screenshots branches before merging this. Also need to add QoL toggle for this first before merging. The rationale behind this feature is basically a poor man's player exports. Also, there are official clients out there like RL that take automated screenshots on levelup, on kill and on death, etc so IMO this isn't too unheard of as a feature.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.