2006-Scape/2006Scape
1
0
Fork 0
mirror of https://github.com/2006-Scape/2006Scape.git synced 2026-07-02 16:49:03 +00:00
Code Issues 4.5k Packages Projects Releases 10 Wiki Activity

[PR #552] Network cleanup #11455

New Issue
Closed
opened 2026-06-04 12:22:29 +00:00 by Dark98 · 0 comments
Dark98 commented 2026-06-04 12:22:29 +00:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/2006-Scape/2006Scape/pull/552

State: closed
Merged: Yes

This replaces the mina 1.1.7 networking with Netty 4.0.34 final. The implementation is based on apollo. With changes differing in the GameSession and LoginSession classes.

The packet decoders were redesigned to work off of a packet object and read directly from the channel buffer rather than doing the array copying to getInstream() like they had previously. This allows the networking to be on a different thread and decode into packet objects which can be processed on the game thread.

Optimally the stream.java would be removed and packets would be constructed for outgoing messages as well (like hyperion). However that is outside the scope of this PR which is just the networking implementation.

Please report any issues here so that they can get taken care of.

**Original Pull Request:** https://github.com/2006-Scape/2006Scape/pull/552 **State:** closed **Merged:** Yes --- This replaces the mina 1.1.7 networking with Netty 4.0.34 final. The implementation is based on apollo. With changes differing in the GameSession and LoginSession classes. The packet decoders were redesigned to work off of a packet object and read directly from the channel buffer rather than doing the array copying to getInstream() like they had previously. This allows the networking to be on a different thread and decode into packet objects which can be processed on the game thread. Optimally the stream.java would be removed and packets would be constructed for outgoing messages as well (like hyperion). However that is outside the scope of this PR which is just the networking implementation. Please report any issues here so that they can get taken care of.
Dark98 added the pull-request label 2026-06-04 12:22:29 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Cannot Reproduce
Difficulty: Easy
Difficulty: Easy
Difficulty: Hard
Difficulty: Medium
Documentation
enhancement
Highest Priority of Type
New Content
New Content
pull-request
Mirrored from GitHub Pull Request
 QoL
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Dark98
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 2006-Scape/2006Scape#11455
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?