[PR #585] Def cleanup #11501

Open
opened 2026-06-04 12:22:35 +00:00 by Dark98 · 0 comments
Owner

Original Pull Request: https://github.com/2006-Scape/2006Scape/pull/585

State: closed
Merged: Yes


This cleans up the definitions for Items and Objects to cleanup the cache loaders and to also allow the loading of most Item Definition data from the cache. In the processing of this PR, some bugs were fixed with the Thieving skill where rewards for pickpocketing and stall thieving were given based off of item name but there was a typo so the reward wouldnt be given.

To the reviewer, should we move the minutes.log file from data/data to data/logs?

**Original Pull Request:** https://github.com/2006-Scape/2006Scape/pull/585 **State:** closed **Merged:** Yes --- This cleans up the definitions for Items and Objects to cleanup the cache loaders and to also allow the loading of most Item Definition data from the cache. In the processing of this PR, some bugs were fixed with the Thieving skill where rewards for pickpocketing and stall thieving were given based off of item name but there was a typo so the reward wouldnt be given. To the reviewer, should we move the minutes.log file from data/data to data/logs?
Dark98 added the pull-request label 2026-06-04 12:22:35 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 2006-Scape/2006Scape#11501