2006-Scape/2006Scape
1
0
Fork 0
mirror of https://github.com/2006-Scape/2006Scape.git synced 2026-07-02 16:49:03 +00:00
Code Issues 4.5k Packages Projects Releases 10 Wiki Activity

[PR #117] Trade issue #11941

New Issue
Open
opened 2026-06-05 12:21:28 +00:00 by Dark98 · 0 comments
Dark98 commented 2026-06-05 12:21:28 +00:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/2006-Scape/2006Scape/pull/117

State: closed
Merged: Yes

Resolved issues around the trading system:

  1. Can't trade anymore when other player isn't close;
  2. Trade interface now close when other player disconnect or click the minimap;
  3. Players cant no longer store items in the trade interface;
  4. Items are properly distributed after any player closes the trade interface;
  5. Added a message saying 'Trade completed.' after a trade is completed;

closes #59

**Original Pull Request:** https://github.com/2006-Scape/2006Scape/pull/117 **State:** closed **Merged:** Yes --- Resolved issues around the trading system: 1. Can't trade anymore when other player isn't close; 2. Trade interface now close when other player disconnect or click the minimap; 3. Players cant no longer store items in the trade interface; 4. Items are properly distributed after any player closes the trade interface; 5. Added a message saying 'Trade completed.' after a trade is completed; closes #59
Dark98 added the pull-request label 2026-06-05 12:21:28 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Cannot Reproduce
Difficulty: Easy
Difficulty: Easy
Difficulty: Hard
Difficulty: Medium
Documentation
enhancement
Highest Priority of Type
New Content
New Content
pull-request
Mirrored from GitHub Pull Request
 QoL
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Dark98
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 2006-Scape/2006Scape#11941
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?