2006-Scape/2006Scape
1
0
Fork 0
mirror of https://github.com/2006-Scape/2006Scape.git synced 2026-07-02 16:49:03 +00:00
Code Issues 4.5k Packages Projects Releases 10 Wiki Activity

[GH-ISSUE #251] When making headless arrows, action stacks so you end up creating a ton of arrows at the same time. #123

New Issue
Closed
opened 2026-05-15 02:56:18 +00:00 by Dark98 · 2 comments
Dark98 commented 2026-05-15 02:56:18 +00:00
Owner
Copy Link
Copy Source

Originally created by @Gptaqbc on GitHub (Dec 9, 2019).
Original GitHub issue: https://github.com/2006-Scape/2006Scape/issues/251

To replicate:

 1. Use feathers on arrow shafts
--- It'll create 15 each tick ---
2.Use feathers on arrow shafts
--- it'll create 30 each tick ---
...
Originally created by @Gptaqbc on GitHub (Dec 9, 2019). Original GitHub issue: https://github.com/2006-Scape/2006Scape/issues/251 To replicate: 1. Use feathers on arrow shafts --- It'll create 15 each tick --- 2.Use feathers on arrow shafts --- it'll create 30 each tick --- ...
Dark98 commented 2026-05-15 02:56:18 +00:00
Author
Owner
Copy Link
Copy Source

@Gptaqbc commented on GitHub (Dec 10, 2019):

A check like that at line 127 in ArrowMaking.java could maybe fix that issue (gotta try when I have time):

if player.playerIsFletching = true
{
Stop old cycle
Start a new cycle
OR
Return???? (Not sure what it'll do)
}

The problem is that it starts multiple cycles every time we send the action to create arrows or arrow shafts.

<!-- gh-comment-id:564111406 --> @Gptaqbc commented on GitHub (Dec 10, 2019): A check like that at line 127 in ArrowMaking.java could maybe fix that issue (gotta try when I have time): >if player.playerIsFletching = true { Stop old cycle Start a new cycle OR Return???? (Not sure what it'll do) >} The problem is that it starts **multiple cycles** every time we send the action to create arrows or arrow shafts.
Dark98 commented 2026-05-15 02:56:18 +00:00
Author
Owner
Copy Link
Copy Source

@Gptaqbc commented on GitHub (Dec 22, 2019):

Fixed

<!-- gh-comment-id:568285372 --> @Gptaqbc commented on GitHub (Dec 22, 2019): Fixed
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Cannot Reproduce
Difficulty: Easy
Difficulty: Easy
Difficulty: Hard
Difficulty: Medium
Documentation
enhancement
Highest Priority of Type
New Content
New Content
pull-request
Mirrored from GitHub Pull Request
 QoL
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Dark98
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 2006-Scape/2006Scape#123
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?