2006-Scape/2006Scape
1
0
Fork 0
mirror of https://github.com/2006-Scape/2006Scape.git synced 2026-07-02 16:49:03 +00:00
Code Issues 4.5k Packages Projects Releases 10 Wiki Activity

[PR #117] [MERGED] Trade issue #12803

New Issue
Open
opened 2026-06-06 12:21:23 +00:00 by Dark98 · 0 comments
Dark98 commented 2026-06-06 12:21:23 +00:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/2006-Scape/2006Scape/pull/117
Author: @Gptaqbc
Created: 10/26/2019
Status: ✅ Merged
Merged: 10/27/2019
Merged by: @dginovker

Base: master ← Head: trade-issue

📝 Commits (2)

📊 Changes

4 files changed (+61 additions, -28 deletions)

View changed files

📝 2006Redone Client/src/Game.java (+26 -16)
📝 2006Redone Server/src/redone/game/players/Trading.java (+21 -8)
📝 2006Redone Server/src/redone/net/packets/impl/ClickingButtons.java (+9 -1)
📝 2006Redone Server/src/redone/net/packets/impl/ClickingStuff.java (+5 -3)

📄 Description

Resolved issues around the trading system:

  1. Can't trade anymore when other player isn't close;
  2. Trade interface now close when other player disconnect or click the minimap;
  3. Players cant no longer store items in the trade interface;
  4. Items are properly distributed after any player closes the trade interface;
  5. Added a message saying 'Trade completed.' after a trade is completed;

closes #59

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/2006-Scape/2006Scape/pull/117 **Author:** [@Gptaqbc](https://github.com/Gptaqbc) **Created:** 10/26/2019 **Status:** ✅ Merged **Merged:** 10/27/2019 **Merged by:** [@dginovker](https://github.com/dginovker) **Base:** `master` ← **Head:** `trade-issue` --- ### 📝 Commits (2) - [`ecdfbbf`](https://github.com/2006-Scape/2006Scape/commit/ecdfbbf9482c0826dc27a7987ebc4fe65e67d690) Update Game.java - [`a2a123f`](https://github.com/2006-Scape/2006Scape/commit/a2a123f089c118118524184d4c3efb8904a6f2a2) Trade issues ### 📊 Changes **4 files changed** (+61 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `2006Redone Client/src/Game.java` (+26 -16) 📝 `2006Redone Server/src/redone/game/players/Trading.java` (+21 -8) 📝 `2006Redone Server/src/redone/net/packets/impl/ClickingButtons.java` (+9 -1) 📝 `2006Redone Server/src/redone/net/packets/impl/ClickingStuff.java` (+5 -3) </details> ### 📄 Description Resolved issues around the trading system: 1. Can't trade anymore when other player isn't close; 2. Trade interface now close when other player disconnect or click the minimap; 3. Players cant no longer store items in the trade interface; 4. Items are properly distributed after any player closes the trade interface; 5. Added a message saying 'Trade completed.' after a trade is completed; closes #59 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Dark98 added the pull-request label 2026-06-06 12:21:23 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Cannot Reproduce
Difficulty: Easy
Difficulty: Easy
Difficulty: Hard
Difficulty: Medium
Documentation
enhancement
Highest Priority of Type
New Content
New Content
pull-request
Mirrored from GitHub Pull Request
 QoL
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Dark98
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 2006-Scape/2006Scape#12803
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?