[PR #534] [MERGED] Implemented functionality where user can search for traps in some chests #1296

New Issue

2026-05-20T10:16:51Z

Dark98 commented

2026-05-20 10:16:51 +00:00

📋 Pull Request Information

Original PR: https://github.com/2006-Scape/2006Scape/pull/534
Author: @AugustasK
Created: 10/18/2022
Status: ✅ Merged
Merged: 1/20/2023
Merged by: @Dark98

Base: master ← Head: fix-search-for-traps

📝 Commits (4)

a8a9692 Initial commit
f7de729 Implemented cooldown timer and added ardougne castle chest
8daacb3 Refactoring
0ce7c05 Removing unused variable

📊 Changes

7 files changed (+229 additions, -96 deletions)

View changed files

➕ 2006Scape Server/src/main/java/com/rs2/game/content/skills/thieving/SearchForTraps.java (+143 -0)
📝 2006Scape Server/src/main/java/com/rs2/game/content/skills/thieving/ThieveOther.java (+43 -44)
📝 2006Scape Server/src/main/java/com/rs2/game/items/ItemAssistant.java (+3 -0)
📝 2006Scape Server/src/main/java/com/rs2/game/npcs/NpcData.java (+2 -2)
📝 2006Scape Server/src/main/java/com/rs2/game/objects/ObjectsActions.java (+15 -13)
📝 2006Scape Server/src/main/java/com/rs2/game/objects/impl/Searching.java (+5 -1)
📝 2006Scape Server/src/main/java/com/rs2/game/players/Player.java (+18 -36)

📄 Description

This is my first PR on this project, so any feedback is welcome :)

I've tested it locally and it works fine, it lets player to search for traps in chests, has cooldown with specific timers and rewards.
I've refactored some code in ThieveOther class (com.rs2.game.content.skills.thieving) and also addOrDropItem method in ItemAssistant class (com.rs2.game.items) to be able to drop item if player does not have stackable item and doesn't have space.

Let me know what you think :)

I guess it could close this issue

Thank you

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/2006-Scape/2006Scape/pull/534 **Author:** [@AugustasK](https://github.com/AugustasK) **Created:** 10/18/2022 **Status:** ✅ Merged **Merged:** 1/20/2023 **Merged by:** [@Dark98](https://github.com/Dark98) **Base:** `master` ← **Head:** `fix-search-for-traps` --- ### 📝 Commits (4) - [`a8a9692`](https://github.com/2006-Scape/2006Scape/commit/a8a9692a4fac87dedf0e3fd4bf435ce8d307fe7f) Initial commit - [`f7de729`](https://github.com/2006-Scape/2006Scape/commit/f7de7294eb71e220d05ea1a4718b139d2c82cb3b) Implemented cooldown timer and added ardougne castle chest - [`8daacb3`](https://github.com/2006-Scape/2006Scape/commit/8daacb3dcb033b4282d677228a264e495d8bf5d1) Refactoring - [`0ce7c05`](https://github.com/2006-Scape/2006Scape/commit/0ce7c057e4c0601b6a0b4b1d4489c8f28ad2e216) Removing unused variable ### 📊 Changes **7 files changed** (+229 additions, -96 deletions) <details> <summary>View changed files</summary> ➕ `2006Scape Server/src/main/java/com/rs2/game/content/skills/thieving/SearchForTraps.java` (+143 -0) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/skills/thieving/ThieveOther.java` (+43 -44) 📝 `2006Scape Server/src/main/java/com/rs2/game/items/ItemAssistant.java` (+3 -0) 📝 `2006Scape Server/src/main/java/com/rs2/game/npcs/NpcData.java` (+2 -2) 📝 `2006Scape Server/src/main/java/com/rs2/game/objects/ObjectsActions.java` (+15 -13) 📝 `2006Scape Server/src/main/java/com/rs2/game/objects/impl/Searching.java` (+5 -1) 📝 `2006Scape Server/src/main/java/com/rs2/game/players/Player.java` (+18 -36) </details> ### 📄 Description This is my first PR on this project, so any feedback is welcome :) I've tested it locally and it works fine, it lets player to search for traps in chests, has cooldown with specific timers and rewards. I've refactored some code in ThieveOther class (com.rs2.game.content.skills.thieving) and also addOrDropItem method in ItemAssistant class (com.rs2.game.items) to be able to drop item if player does not have stackable item and doesn't have space. Let me know what you think :) I guess it could close this [issue](https://github.com/2006-Scape/2006Scape/issues/221) Thank you --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

Dark98 added the pull-request label 2026-05-20 10:16:51 +00:00

Dark98 closed this issue

2026-05-20 10:16:51 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: 2006-Scape/2006Scape#1296