It appears that this code is related to farming and the state updating.
This PR removes a redundant and incompletely implemented tick system and converts the farming task to a cycle event. The event is not submitted for scheduling. As a result, this will not affect functionality. If the skill works correctly, the farmingtask can be removed and any methods called by it related to the state changes.
**Original Pull Request:** https://github.com/2006-Scape/2006Scape/pull/567
**State:** closed
**Merged:** Yes
---
Just noticed what appears to be an issue there is the Tick System here: https://github.com/2006-Scape/2006Scape/tree/master/2006Scape%20Server/src/main/java/com/rs2/tick
We already have a system "CycleEvents" for these tick based interactions.
That tick system is only used in the class https://github.com/2006-Scape/2006Scape/blob/master/2006Scape%20Server/src/main/java/com/rs2/game/content/skills/farming/FarmingTask.java
HOWEVER, this tick is never submitted to the gameengine for processing and the schedule/tick system is never called during the server loop.
As a result the following code is never called
It appears that this code is related to farming and the state updating.
This PR removes a redundant and incompletely implemented tick system and converts the farming task to a cycle event. The event is not submitted for scheduling. As a result, this will not affect functionality. If the skill works correctly, the farmingtask can be removed and any methods called by it related to the state changes.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Original Pull Request: https://github.com/2006-Scape/2006Scape/pull/567
State: closed
Merged: Yes
Just noticed what appears to be an issue there is the Tick System here: https://github.com/2006-Scape/2006Scape/tree/master/2006Scape%20Server/src/main/java/com/rs2/tick
We already have a system "CycleEvents" for these tick based interactions.
That tick system is only used in the class https://github.com/2006-Scape/2006Scape/blob/master/2006Scape%20Server/src/main/java/com/rs2/game/content/skills/farming/FarmingTask.java
HOWEVER, this tick is never submitted to the gameengine for processing and the schedule/tick system is never called during the server loop.
As a result the following code is never called
It appears that this code is related to farming and the state updating.
This PR removes a redundant and incompletely implemented tick system and converts the farming task to a cycle event. The event is not submitted for scheduling. As a result, this will not affect functionality. If the skill works correctly, the farmingtask can be removed and any methods called by it related to the state changes.