2006-Scape/2006Scape
1
0
Fork 0
mirror of https://github.com/2006-Scape/2006Scape.git synced 2026-07-02 16:49:03 +00:00
Code Issues 4.5k Packages Projects Releases 10 Wiki Activity

[PR #512] [MERGED] Astraeus Dialogue System Port #14156

New Issue
Open
opened 2026-06-07 12:23:13 +00:00 by Dark98 · 0 comments
Dark98 commented 2026-06-07 12:23:13 +00:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/2006-Scape/2006Scape/pull/512
Author: @Qweqker
Created: 10/29/2021
Status: ✅ Merged
Merged: 10/31/2021
Merged by: @Dark98

Base: master ← Head: Dialogue-Revamp

📝 Commits (5)

  • 753f00d - Marked As Deprecated
  • bfc5763 - Refactored Dialogue.java into DialoguePacket.java
  • 2f6beaa - Removed useless file
  • 75ab697 - Ported Astraeus Dialogue System
  • bbddc02 - Renamed Astraeus* classes to *Plugin

📊 Changes

21 files changed (+2887 additions, -9050 deletions)

View changed files

➕ 2006Scape Server/plugins/plugin/buttons/DialogueOptionButtons.kt (+41 -0)
📝 2006Scape Server/plugins/plugin/click/npc/NpcFirstClick.kt (+11 -11)
➕ 2006Scape Server/plugins/plugin/npc/banker/BankerDialogue.kt (+37 -0)
➕ 2006Scape Server/plugins/plugin/npc/manwoman/ManWomanDialogue.kt (+163 -0)
➖ 2006Scape Server/src/main/java/com/rs2/game/content/combat/npcs/StaticNpcList.java (+0 -7735)
➕ 2006Scape Server/src/main/java/com/rs2/game/dialogues/ChainablePlugin.java (+14 -0)
📝 2006Scape Server/src/main/java/com/rs2/game/dialogues/ChatEmotes.java (+6 -1)
➖ 2006Scape Server/src/main/java/com/rs2/game/dialogues/Dialogue.java (+0 -20)
➕ 2006Scape Server/src/main/java/com/rs2/game/dialogues/DialogueFactoryPlugin.java (+741 -0)
📝 2006Scape Server/src/main/java/com/rs2/game/dialogues/DialogueHandler.java (+9 -47)
📝 2006Scape Server/src/main/java/com/rs2/game/dialogues/DialogueOptions.java (+1114 -1083)
➕ 2006Scape Server/src/main/java/com/rs2/game/dialogues/DialoguePlugin.java (+37 -0)
➕ 2006Scape Server/src/main/java/com/rs2/game/dialogues/ExpressionPlugin.java (+74 -0)
➕ 2006Scape Server/src/main/java/com/rs2/game/dialogues/NPCDialogue.java (+122 -0)
➕ 2006Scape Server/src/main/java/com/rs2/game/dialogues/OptionDialoguePlugin.java (+163 -0)
➕ 2006Scape Server/src/main/java/com/rs2/game/dialogues/PlayerDialoguePlugin.java (+84 -0)
➕ 2006Scape Server/src/main/java/com/rs2/game/dialogues/StatementDialoguePlugin.java (+60 -0)
📝 2006Scape Server/src/main/java/com/rs2/game/players/Player.java (+40 -36)
📝 2006Scape Server/src/main/java/com/rs2/net/packets/PacketHandler.java (+2 -2)
➕ 2006Scape Server/src/main/java/com/rs2/net/packets/impl/DialoguePacket.java (+28 -0)

...and 1 more files

📄 Description

I figured I consider trying to port something over from Astraeus considering the plugin system was implemented recently. Surprisingly, I was able to port over the Dialogue System without much issue. The only other thing I did was add a line split function so that dialogues can be setup easier.

It's missing a couple of existing interfaces from the current DialogueHandler file, but it should be simple enough to move them over.

Change Summary

  • Refactored Dialogue.java into DialoguePacket.java
    • Also moved into the packets package
  • Implemented Astraeus Dialogue System
  • Added line split function in the Astraeus Dialogue System
  • Ported Over Man and Woman NPC dialogues
    • Added Missing Dialogues
    • Removed Existing Dialogues in the Dialogue Handler
  • Ported Over Banker Dialogue
    • Added Missing Dialogues
    • Removed Existing Dialogues in the Dialogue Handler
      • P I N removal notice remains in Dialogue Handler
  • Adjusted the Old Dialogues Option Handler to be ordered by Interface (Option Interface 2, 3, 4, and 5)
  • Adjusted the Misc.java file to be ordered by String, Number, RNG, and Positioning Functions
  • Marked Old Dialogue System as Deprecated
  • Removed StaticNpcList.java as it was unused and the NPC IDs were very inaccurate

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/2006-Scape/2006Scape/pull/512 **Author:** [@Qweqker](https://github.com/Qweqker) **Created:** 10/29/2021 **Status:** ✅ Merged **Merged:** 10/31/2021 **Merged by:** [@Dark98](https://github.com/Dark98) **Base:** `master` ← **Head:** `Dialogue-Revamp` --- ### 📝 Commits (5) - [`753f00d`](https://github.com/2006-Scape/2006Scape/commit/753f00d57901de36e35064c0684ac6f35eadb280) - Marked As Deprecated - [`bfc5763`](https://github.com/2006-Scape/2006Scape/commit/bfc5763797abf24e7171d8f248f658b5959f8c32) - Refactored Dialogue.java into DialoguePacket.java - [`2f6beaa`](https://github.com/2006-Scape/2006Scape/commit/2f6beaa75bab764819e6afca07c75aea26049d88) - Removed useless file - [`75ab697`](https://github.com/2006-Scape/2006Scape/commit/75ab6976b371a4bd513f331ca1950f47d6feddd7) - Ported Astraeus Dialogue System - [`bbddc02`](https://github.com/2006-Scape/2006Scape/commit/bbddc025e62fbcdd8814e17b78674748191b942f) - Renamed Astraeus* classes to *Plugin ### 📊 Changes **21 files changed** (+2887 additions, -9050 deletions) <details> <summary>View changed files</summary> ➕ `2006Scape Server/plugins/plugin/buttons/DialogueOptionButtons.kt` (+41 -0) 📝 `2006Scape Server/plugins/plugin/click/npc/NpcFirstClick.kt` (+11 -11) ➕ `2006Scape Server/plugins/plugin/npc/banker/BankerDialogue.kt` (+37 -0) ➕ `2006Scape Server/plugins/plugin/npc/manwoman/ManWomanDialogue.kt` (+163 -0) ➖ `2006Scape Server/src/main/java/com/rs2/game/content/combat/npcs/StaticNpcList.java` (+0 -7735) ➕ `2006Scape Server/src/main/java/com/rs2/game/dialogues/ChainablePlugin.java` (+14 -0) 📝 `2006Scape Server/src/main/java/com/rs2/game/dialogues/ChatEmotes.java` (+6 -1) ➖ `2006Scape Server/src/main/java/com/rs2/game/dialogues/Dialogue.java` (+0 -20) ➕ `2006Scape Server/src/main/java/com/rs2/game/dialogues/DialogueFactoryPlugin.java` (+741 -0) 📝 `2006Scape Server/src/main/java/com/rs2/game/dialogues/DialogueHandler.java` (+9 -47) 📝 `2006Scape Server/src/main/java/com/rs2/game/dialogues/DialogueOptions.java` (+1114 -1083) ➕ `2006Scape Server/src/main/java/com/rs2/game/dialogues/DialoguePlugin.java` (+37 -0) ➕ `2006Scape Server/src/main/java/com/rs2/game/dialogues/ExpressionPlugin.java` (+74 -0) ➕ `2006Scape Server/src/main/java/com/rs2/game/dialogues/NPCDialogue.java` (+122 -0) ➕ `2006Scape Server/src/main/java/com/rs2/game/dialogues/OptionDialoguePlugin.java` (+163 -0) ➕ `2006Scape Server/src/main/java/com/rs2/game/dialogues/PlayerDialoguePlugin.java` (+84 -0) ➕ `2006Scape Server/src/main/java/com/rs2/game/dialogues/StatementDialoguePlugin.java` (+60 -0) 📝 `2006Scape Server/src/main/java/com/rs2/game/players/Player.java` (+40 -36) 📝 `2006Scape Server/src/main/java/com/rs2/net/packets/PacketHandler.java` (+2 -2) ➕ `2006Scape Server/src/main/java/com/rs2/net/packets/impl/DialoguePacket.java` (+28 -0) _...and 1 more files_ </details> ### 📄 Description I figured I consider trying to port something over from Astraeus considering the plugin system was implemented recently. Surprisingly, I was able to port over the Dialogue System without much issue. The only other thing I did was add a line split function so that dialogues can be setup easier. <br /> It's missing a couple of existing interfaces from the current DialogueHandler file, but it should be simple enough to move them over. ### Change Summary - Refactored Dialogue.java into DialoguePacket.java - Also moved into the packets package - Implemented Astraeus Dialogue System - Added line split function in the Astraeus Dialogue System - Ported Over Man and Woman NPC dialogues - Added Missing Dialogues - Removed Existing Dialogues in the Dialogue Handler - Ported Over Banker Dialogue - Added Missing Dialogues - Removed Existing Dialogues in the Dialogue Handler - P I N removal notice remains in Dialogue Handler - Adjusted the Old Dialogues Option Handler to be ordered by Interface (Option Interface 2, 3, 4, and 5) - Adjusted the Misc.java file to be ordered by String, Number, RNG, and Positioning Functions - Marked Old Dialogue System as Deprecated - Removed StaticNpcList.java as it was unused and the NPC IDs were very inaccurate --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Dark98 added the pull-request label 2026-06-07 12:23:13 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Cannot Reproduce
Difficulty: Easy
Difficulty: Easy
Difficulty: Hard
Difficulty: Medium
Documentation
enhancement
Highest Priority of Type
New Content
New Content
pull-request
Mirrored from GitHub Pull Request
 QoL
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Dark98
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 2006-Scape/2006Scape#14156
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?