I figured I consider trying to port something over from Astraeus considering the plugin system was implemented recently. Surprisingly, I was able to port over the Dialogue System without much issue. The only other thing I did was add a line split function so that dialogues can be setup easier.
It's missing a couple of existing interfaces from the current DialogueHandler file, but it should be simple enough to move them over.
Change Summary
Refactored Dialogue.java into DialoguePacket.java
Also moved into the packets package
Implemented Astraeus Dialogue System
Added line split function in the Astraeus Dialogue System
Ported Over Man and Woman NPC dialogues
Added Missing Dialogues
Removed Existing Dialogues in the Dialogue Handler
Ported Over Banker Dialogue
Added Missing Dialogues
Removed Existing Dialogues in the Dialogue Handler
P I N removal notice remains in Dialogue Handler
Adjusted the Old Dialogues Option Handler to be ordered by Interface (Option Interface 2, 3, 4, and 5)
Adjusted the Misc.java file to be ordered by String, Number, RNG, and Positioning Functions
Marked Old Dialogue System as Deprecated
Removed StaticNpcList.java as it was unused and the NPC IDs were very inaccurate
**Original Pull Request:** https://github.com/2006-Scape/2006Scape/pull/512
**State:** closed
**Merged:** Yes
---
I figured I consider trying to port something over from Astraeus considering the plugin system was implemented recently. Surprisingly, I was able to port over the Dialogue System without much issue. The only other thing I did was add a line split function so that dialogues can be setup easier. <br />
It's missing a couple of existing interfaces from the current DialogueHandler file, but it should be simple enough to move them over.
### Change Summary
- Refactored Dialogue.java into DialoguePacket.java
- Also moved into the packets package
- Implemented Astraeus Dialogue System
- Added line split function in the Astraeus Dialogue System
- Ported Over Man and Woman NPC dialogues
- Added Missing Dialogues
- Removed Existing Dialogues in the Dialogue Handler
- Ported Over Banker Dialogue
- Added Missing Dialogues
- Removed Existing Dialogues in the Dialogue Handler
- P I N removal notice remains in Dialogue Handler
- Adjusted the Old Dialogues Option Handler to be ordered by Interface (Option Interface 2, 3, 4, and 5)
- Adjusted the Misc.java file to be ordered by String, Number, RNG, and Positioning Functions
- Marked Old Dialogue System as Deprecated
- Removed StaticNpcList.java as it was unused and the NPC IDs were very inaccurate
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Original Pull Request: https://github.com/2006-Scape/2006Scape/pull/512
State: closed
Merged: Yes
I figured I consider trying to port something over from Astraeus considering the plugin system was implemented recently. Surprisingly, I was able to port over the Dialogue System without much issue. The only other thing I did was add a line split function so that dialogues can be setup easier.
It's missing a couple of existing interfaces from the current DialogueHandler file, but it should be simple enough to move them over.
Change Summary