2006-Scape/2006Scape
1
0
Fork 0
mirror of https://github.com/2006-Scape/2006Scape.git synced 2026-07-02 16:49:03 +00:00
Code Issues 4.5k Packages Projects Releases 10 Wiki Activity

[PR #642] [MERGED] Fixed magic attacks running up to NPCs and Players #14298

New Issue
Closed
opened 2026-06-07 12:23:32 +00:00 by Dark98 · 0 comments
Dark98 commented 2026-06-07 12:23:32 +00:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/2006-Scape/2006Scape/pull/642
Author: @ipkpjersi
Created: 12/23/2023
Status: ✅ Merged
Merged: 9/21/2024
Merged by: @Dark98

Base: master ← Head: fix-maging-npcs-distance

📝 Commits (5)

  • e87adf3 Fixed magic attacks running up to NPCs
  • 1e8d9b3 Revert "Fixed magic attacks running up to NPCs"
  • 5720fe9 Fixed magic attacks running up to NPCs
  • 0973040 Fixed player running up to players when casting magic
  • 92fb1d5 Updated comment

📊 Changes

1 file changed (+15 additions, -1 deletions)

View changed files

📝 2006Scape Server/src/main/java/com/rs2/game/content/combat/CombatAssistant.java (+15 -1)

📄 Description

I'd actually also like to refactor this since followId vs followId2 is horrible naming, but, one step at a time... This is good to go as it stands right now.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/2006-Scape/2006Scape/pull/642 **Author:** [@ipkpjersi](https://github.com/ipkpjersi) **Created:** 12/23/2023 **Status:** ✅ Merged **Merged:** 9/21/2024 **Merged by:** [@Dark98](https://github.com/Dark98) **Base:** `master` ← **Head:** `fix-maging-npcs-distance` --- ### 📝 Commits (5) - [`e87adf3`](https://github.com/2006-Scape/2006Scape/commit/e87adf3f469ea9cde40aa30608cb3618c5cca50e) Fixed magic attacks running up to NPCs - [`1e8d9b3`](https://github.com/2006-Scape/2006Scape/commit/1e8d9b3d6f474d10986416e46d87c14cda247503) Revert "Fixed magic attacks running up to NPCs" - [`5720fe9`](https://github.com/2006-Scape/2006Scape/commit/5720fe9697ca6285e25ee5158eb5e15a4100c458) Fixed magic attacks running up to NPCs - [`0973040`](https://github.com/2006-Scape/2006Scape/commit/097304078796e6d9db1caacb3afc6a0c57c1ada8) Fixed player running up to players when casting magic - [`92fb1d5`](https://github.com/2006-Scape/2006Scape/commit/92fb1d50ba3c38fb03311d0792927462edd2fd3d) Updated comment ### 📊 Changes **1 file changed** (+15 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `2006Scape Server/src/main/java/com/rs2/game/content/combat/CombatAssistant.java` (+15 -1) </details> ### 📄 Description I'd actually also like to refactor this since followId vs followId2 is horrible naming, but, one step at a time... This is good to go as it stands right now. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Dark98 added the pull-request label 2026-06-07 12:23:32 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Cannot Reproduce
Difficulty: Easy
Difficulty: Easy
Difficulty: Hard
Difficulty: Medium
Documentation
enhancement
Highest Priority of Type
New Content
New Content
pull-request
Mirrored from GitHub Pull Request
 QoL
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Dark98
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 2006-Scape/2006Scape#14298
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?