2006-Scape/2006Scape
1
0
Fork 0
mirror of https://github.com/2006-Scape/2006Scape.git synced 2026-07-02 16:49:03 +00:00
Code Issues 4.5k Packages Projects Releases 10 Wiki Activity

[PR #643] [CLOSED] Added ability to take screenshots #14300

New Issue
Open
opened 2026-06-07 12:23:33 +00:00 by Dark98 · 0 comments
Dark98 commented 2026-06-07 12:23:33 +00:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/2006-Scape/2006Scape/pull/643
Author: @ipkpjersi
Created: 12/27/2023
Status: ❌ Closed

Base: master ← Head: screenshots

📝 Commits (10+)

  • 863ffde Added ability to take screenshots
  • 4c65665 Removed duplicate screenshot warning message
  • 9dc9625 Added subfolders option for screenshots
  • 02a1707 Removed unused code
  • 4858e16 Added check for screenshots
  • 0b694a2 Fixed screenshots NPE when logged out
  • edfb4ec Added Local to titlebar when running locally
  • 1d15c2c Added sendMessage param for screenshots
  • a315467 Default to send messages for screenshots
  • db5f9d2 Use the sendMessage variable

📊 Changes

59 files changed (+134834 additions, -134498 deletions)

View changed files

📝 2006Scape Client/src/main/java/ClientSettings.java (+47 -0)
📝 2006Scape Client/src/main/java/Flo.java (+1 -1)
📝 2006Scape Client/src/main/java/Game.java (+90 -11)
📝 2006Scape Client/src/main/java/Main.java (+22 -3)
📝 2006Scape Client/src/main/java/ObjectManager.java (+6 -2)
📝 2006Scape Client/src/main/java/RSFrame.java (+1 -1)
➕ 2006Scape Server/data/cfg/npcDefinitions.json (+134246 -0)
➖ 2006Scape Server/data/cfg/npcDefinitions.xml (+0 -134240)
📝 2006Scape Server/data/cfg/spawns.json (+0 -40)
➕ 2006Scape Server/plugins/plugin/buttons/gameframe/SoundVolumeButtons.java (+37 -0)
📝 2006Scape Server/src/main/java/com/rs2/GameEngine.java (+9 -9)
➕ 2006Scape Server/src/main/java/com/rs2/game/content/combat/AttackType.java (+18 -0)
📝 2006Scape Server/src/main/java/com/rs2/game/content/combat/CombatAssistant.java (+15 -1)
📝 2006Scape Server/src/main/java/com/rs2/game/content/combat/npcs/NpcCombat.java (+68 -66)
📝 2006Scape Server/src/main/java/com/rs2/game/content/combat/npcs/NpcEmotes.java (+9 -8)
📝 2006Scape Server/src/main/java/com/rs2/game/content/minigames/Barrows.java (+0 -1)
📝 2006Scape Server/src/main/java/com/rs2/game/content/minigames/Dueling.java (+1 -1)
📝 2006Scape Server/src/main/java/com/rs2/game/content/quests/impl/BlackKnightsFortress.java (+7 -1)
📝 2006Scape Server/src/main/java/com/rs2/game/content/quests/impl/CooksAssistant.java (+7 -1)
📝 2006Scape Server/src/main/java/com/rs2/game/content/quests/impl/DoricsQuest.java (+7 -1)

...and 39 more files

📄 Description

Since we have a screenshots folder in the 2006Scape folder in the home path, we might as well make use of it.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/2006-Scape/2006Scape/pull/643 **Author:** [@ipkpjersi](https://github.com/ipkpjersi) **Created:** 12/27/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `screenshots` --- ### 📝 Commits (10+) - [`863ffde`](https://github.com/2006-Scape/2006Scape/commit/863ffdee34c900e3096ab986ed94a23ccc6afd82) Added ability to take screenshots - [`4c65665`](https://github.com/2006-Scape/2006Scape/commit/4c65665928c7b3f85f3386639900a1470203e9a6) Removed duplicate screenshot warning message - [`9dc9625`](https://github.com/2006-Scape/2006Scape/commit/9dc962560febde1aab06fed8ecaec0d487b143e6) Added subfolders option for screenshots - [`02a1707`](https://github.com/2006-Scape/2006Scape/commit/02a1707b95d90b85137d48940d79063006d801d3) Removed unused code - [`4858e16`](https://github.com/2006-Scape/2006Scape/commit/4858e16c1ee35f2dc5f2b5e8fbbc1d657c2c08ae) Added check for screenshots - [`0b694a2`](https://github.com/2006-Scape/2006Scape/commit/0b694a26d965c2b21597d435e5f5506a7d63244c) Fixed screenshots NPE when logged out - [`edfb4ec`](https://github.com/2006-Scape/2006Scape/commit/edfb4ec91df0069158427ce0e3231cb60c70e66a) Added Local to titlebar when running locally - [`1d15c2c`](https://github.com/2006-Scape/2006Scape/commit/1d15c2c97f7624b548a586d72fcc5a56f0c901c5) Added sendMessage param for screenshots - [`a315467`](https://github.com/2006-Scape/2006Scape/commit/a31546773f08f28779995c1f93eee0d959ae1218) Default to send messages for screenshots - [`db5f9d2`](https://github.com/2006-Scape/2006Scape/commit/db5f9d26ac54d1a82e58e357cdbdb2ea5357b511) Use the sendMessage variable ### 📊 Changes **59 files changed** (+134834 additions, -134498 deletions) <details> <summary>View changed files</summary> 📝 `2006Scape Client/src/main/java/ClientSettings.java` (+47 -0) 📝 `2006Scape Client/src/main/java/Flo.java` (+1 -1) 📝 `2006Scape Client/src/main/java/Game.java` (+90 -11) 📝 `2006Scape Client/src/main/java/Main.java` (+22 -3) 📝 `2006Scape Client/src/main/java/ObjectManager.java` (+6 -2) 📝 `2006Scape Client/src/main/java/RSFrame.java` (+1 -1) ➕ `2006Scape Server/data/cfg/npcDefinitions.json` (+134246 -0) ➖ `2006Scape Server/data/cfg/npcDefinitions.xml` (+0 -134240) 📝 `2006Scape Server/data/cfg/spawns.json` (+0 -40) ➕ `2006Scape Server/plugins/plugin/buttons/gameframe/SoundVolumeButtons.java` (+37 -0) 📝 `2006Scape Server/src/main/java/com/rs2/GameEngine.java` (+9 -9) ➕ `2006Scape Server/src/main/java/com/rs2/game/content/combat/AttackType.java` (+18 -0) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/combat/CombatAssistant.java` (+15 -1) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/combat/npcs/NpcCombat.java` (+68 -66) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/combat/npcs/NpcEmotes.java` (+9 -8) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/minigames/Barrows.java` (+0 -1) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/minigames/Dueling.java` (+1 -1) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/quests/impl/BlackKnightsFortress.java` (+7 -1) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/quests/impl/CooksAssistant.java` (+7 -1) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/quests/impl/DoricsQuest.java` (+7 -1) _...and 39 more files_ </details> ### 📄 Description Since we have a screenshots folder in the 2006Scape folder in the home path, we might as well make use of it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Dark98 added the pull-request label 2026-06-07 12:23:33 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Cannot Reproduce
Difficulty: Easy
Difficulty: Easy
Difficulty: Hard
Difficulty: Medium
Documentation
enhancement
Highest Priority of Type
New Content
New Content
pull-request
Mirrored from GitHub Pull Request
 QoL
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Dark98
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 2006-Scape/2006Scape#14300
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?