2006-Scape/2006Scape
1
0
Fork 0
mirror of https://github.com/2006-Scape/2006Scape.git synced 2026-07-02 16:49:03 +00:00
Code Issues 4.5k Packages Projects Releases 10 Wiki Activity

[PR #680] [CLOSED] Add agent personality chatter #14339

New Issue
Closed
opened 2026-06-09 01:15:04 +00:00 by Dark98 · 0 comments
Dark98 commented 2026-06-09 01:15:04 +00:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/2006-Scape/2006Scape/pull/680
Author: @francisgreenleaf
Created: 6/7/2026
Status: ❌ Closed

Base: master ← Head: agent-session-logs

📝 Commits (10+)

📊 Changes

4662 files changed (+1724921 additions, -151532 deletions)

View changed files

➕ .codex/skills/2006scape-agent-bridge-dev/SKILL.md (+101 -0)
➕ .codex/skills/2006scape-agent-bridge-dev/agents/openai.yaml (+4 -0)
➕ .codex/skills/2006scape-agent-session-logs/SKILL.md (+78 -0)
➕ .codex/skills/2006scape-agent-session-logs/agents/openai.yaml (+4 -0)
➕ .codex/skills/2006scape-cache-map/SKILL.md (+157 -0)
➕ .codex/skills/2006scape-cache-map/agents/openai.yaml (+4 -0)
➕ .codex/skills/2006scape-cache-map/references/cache-world-map.md (+245 -0)
➕ .codex/skills/2006scape-character-memory/SKILL.md (+62 -0)
➕ .codex/skills/2006scape-character-memory/agents/openai.yaml (+5 -0)
➕ .codex/skills/2006scape-custom-content/SKILL.md (+82 -0)
➕ .codex/skills/2006scape-custom-content/agents/openai.yaml (+4 -0)
➕ .codex/skills/2006scape-dev-editing/SKILL.md (+61 -0)
➕ .codex/skills/2006scape-dev-editing/agents/openai.yaml (+4 -0)
➕ .codex/skills/2006scape-dev-editing/references/actionable-lessons.md (+277 -0)
➕ .codex/skills/2006scape-frontier-exploration/SKILL.md (+52 -0)
➕ .codex/skills/2006scape-frontier-exploration/agents/openai.yaml (+4 -0)
➕ .codex/skills/2006scape-gameplay-progression/SKILL.md (+117 -0)
➕ .codex/skills/2006scape-gameplay-progression/agents/openai.yaml (+4 -0)
➕ .codex/skills/2006scape-local-runtime/SKILL.md (+107 -0)
➕ .codex/skills/2006scape-local-runtime/agents/openai.yaml (+4 -0)

...and 80 more files

📄 Description

Summary

  • Adds server-side AgentPersonalityNarrator for milestone classification, deterministic fallback chatter, cooldowns, dedupe, compact LLM enrichment queueing, and server-approved spoken lines.
  • Records compact personality_chatter, personality_spoken, and personality_chatter_failed events in session logs and expands profile memory with narrative self-talk, personality sketch, style influences, and spoken thoughts.
  • Adds bridge endpoints for pending/complete/failed personality enrichment and a tiny client-side no-tools narration worker that adopts local sessions.
  • Uses forced-chat-with-chatbox-forwarding for narrator speech so the speaking player actually sees the line, and fixes the public chat update word packing regression covered by tests.

Live validation

  • MrFish final validation session: dcab60206fe98208
    • JSONL recorded personality_chatter and personality_spoken for goal completion.
    • Markdown timeline recorded Personality chatter spoken publicly at 2026-06-07T20:00:59.040Z.
  • MrGem final validation session: 3d3eaf8ed1b544c0
    • JSONL recorded personality_chatter and personality_spoken for goal completion.
    • Markdown timeline recorded Personality chatter spoken publicly at 2026-06-07T20:00:59.043Z.
  • Screenshot capture was attempted, but macOS returned black full-screen captures / unavailable Java window bounds during final validation, so the reliable attached evidence is the live session logs plus regression tests.

Tests

  • mvn -q -pl '2006Scape Server' -Dtest=AgentPersonalityNarratorTest,AgentToolServiceTest test
  • mvn -q clean test
  • mvn -q -DskipTests package
  • git diff --check

Not run

  • docker compose run --rm rsps-2006scape-build because Docker is not installed/available in this environment (docker: command not found).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/2006-Scape/2006Scape/pull/680 **Author:** [@francisgreenleaf](https://github.com/francisgreenleaf) **Created:** 6/7/2026 **Status:** ❌ Closed **Base:** `master` ← **Head:** `agent-session-logs` --- ### 📝 Commits (10+) - [`ab8f13e`](https://github.com/2006-Scape/2006Scape/commit/ab8f13e4e2410c59a1651be8c72db265e3fcb250) Song when player levels up a skill (#426) - [`93e4212`](https://github.com/2006-Scape/2006Scape/commit/93e42123f4215409da10138f5ce24245bd2c4143) Sound Effects for Protection Prayers (#427) - [`411a07e`](https://github.com/2006-Scape/2006Scape/commit/411a07e7b8070943d2fa8a25ba028d195f22d1f2) Spade Animation / SFX (#428) - [`2ca6b8a`](https://github.com/2006-Scape/2006Scape/commit/2ca6b8a8783b722f37d06c9028a135e1a4266667) Fixed Rasolo The Merchant's Shop (#432) - [`bf34518`](https://github.com/2006-Scape/2006Scape/commit/bf3451811c5512b7bbf549dca1e519433d0f8a8c) Lost City Value for Quest Progression (#431) - [`a60790d`](https://github.com/2006-Scape/2006Scape/commit/a60790d945ba82b725cd09a8f96e656f8ba467ad) Added NPCs for Lost City Quest (#430) - [`e940575`](https://github.com/2006-Scape/2006Scape/commit/e940575350c57c80ba30956130f38ec7cb2442fb) Level Up Fireworks GFX (#429) - [`b8ed2bf`](https://github.com/2006-Scape/2006Scape/commit/b8ed2bff75e5978cf0a9c2e8f8afbe4be095673e) Lost City Rewards Added (#433) - [`a8dd6ca`](https://github.com/2006-Scape/2006Scape/commit/a8dd6ca993fcbc3a9755ca94b92e2422c661bf24) Add Jognson's Lost City - [`03ddfcf`](https://github.com/2006-Scape/2006Scape/commit/03ddfcf3a37b237eb5330e09e17600216d5a8f81) Add Jognson's Lost City (#434) ### 📊 Changes **4662 files changed** (+1724921 additions, -151532 deletions) <details> <summary>View changed files</summary> ➕ `.codex/skills/2006scape-agent-bridge-dev/SKILL.md` (+101 -0) ➕ `.codex/skills/2006scape-agent-bridge-dev/agents/openai.yaml` (+4 -0) ➕ `.codex/skills/2006scape-agent-session-logs/SKILL.md` (+78 -0) ➕ `.codex/skills/2006scape-agent-session-logs/agents/openai.yaml` (+4 -0) ➕ `.codex/skills/2006scape-cache-map/SKILL.md` (+157 -0) ➕ `.codex/skills/2006scape-cache-map/agents/openai.yaml` (+4 -0) ➕ `.codex/skills/2006scape-cache-map/references/cache-world-map.md` (+245 -0) ➕ `.codex/skills/2006scape-character-memory/SKILL.md` (+62 -0) ➕ `.codex/skills/2006scape-character-memory/agents/openai.yaml` (+5 -0) ➕ `.codex/skills/2006scape-custom-content/SKILL.md` (+82 -0) ➕ `.codex/skills/2006scape-custom-content/agents/openai.yaml` (+4 -0) ➕ `.codex/skills/2006scape-dev-editing/SKILL.md` (+61 -0) ➕ `.codex/skills/2006scape-dev-editing/agents/openai.yaml` (+4 -0) ➕ `.codex/skills/2006scape-dev-editing/references/actionable-lessons.md` (+277 -0) ➕ `.codex/skills/2006scape-frontier-exploration/SKILL.md` (+52 -0) ➕ `.codex/skills/2006scape-frontier-exploration/agents/openai.yaml` (+4 -0) ➕ `.codex/skills/2006scape-gameplay-progression/SKILL.md` (+117 -0) ➕ `.codex/skills/2006scape-gameplay-progression/agents/openai.yaml` (+4 -0) ➕ `.codex/skills/2006scape-local-runtime/SKILL.md` (+107 -0) ➕ `.codex/skills/2006scape-local-runtime/agents/openai.yaml` (+4 -0) _...and 80 more files_ </details> ### 📄 Description ## Summary - Adds server-side `AgentPersonalityNarrator` for milestone classification, deterministic fallback chatter, cooldowns, dedupe, compact LLM enrichment queueing, and server-approved spoken lines. - Records compact `personality_chatter`, `personality_spoken`, and `personality_chatter_failed` events in session logs and expands profile memory with narrative self-talk, personality sketch, style influences, and spoken thoughts. - Adds bridge endpoints for pending/complete/failed personality enrichment and a tiny client-side no-tools narration worker that adopts local sessions. - Uses forced-chat-with-chatbox-forwarding for narrator speech so the speaking player actually sees the line, and fixes the public chat update word packing regression covered by tests. ## Live validation - MrFish final validation session: `dcab60206fe98208` - JSONL recorded `personality_chatter` and `personality_spoken` for goal completion. - Markdown timeline recorded `Personality chatter spoken publicly` at `2026-06-07T20:00:59.040Z`. - MrGem final validation session: `3d3eaf8ed1b544c0` - JSONL recorded `personality_chatter` and `personality_spoken` for goal completion. - Markdown timeline recorded `Personality chatter spoken publicly` at `2026-06-07T20:00:59.043Z`. - Screenshot capture was attempted, but macOS returned black full-screen captures / unavailable Java window bounds during final validation, so the reliable attached evidence is the live session logs plus regression tests. ## Tests - `mvn -q -pl '2006Scape Server' -Dtest=AgentPersonalityNarratorTest,AgentToolServiceTest test` - `mvn -q clean test` - `mvn -q -DskipTests package` - `git diff --check` ## Not run - `docker compose run --rm rsps-2006scape-build` because Docker is not installed/available in this environment (`docker: command not found`). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Dark98 added the pull-request label 2026-06-09 01:15:04 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Cannot Reproduce
Difficulty: Easy
Difficulty: Easy
Difficulty: Hard
Difficulty: Medium
Documentation
enhancement
Highest Priority of Type
New Content
New Content
pull-request
Mirrored from GitHub Pull Request
 QoL
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Dark98
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 2006-Scape/2006Scape#14339
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?