2006-Scape/2006Scape
1
0
Fork 0
mirror of https://github.com/2006-Scape/2006Scape.git synced 2026-07-02 16:49:03 +00:00
Code Issues 4.5k Packages Projects Releases 10 Wiki Activity

[PR #417] [MERGED] [FEATURE] Data will now use json #1885

New Issue
Closed
opened 2026-05-21 10:16:33 +00:00 by Dark98 · 0 comments
Dark98 commented 2026-05-21 10:16:33 +00:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/2006-Scape/2006Scape/pull/417
Author: @SandroCoutinho
Created: 8/5/2020
Status: ✅ Merged
Merged: 8/13/2020
Merged by: @dginovker

Base: master ← Head: feature/json-data

📝 Commits (7)

  • b4571a2 [FEATURE] Item data is now loaded from json
  • c818b16 [TASK] Renamed the old method into it's new use
  • e1af20f [TASK] Removed unused code
  • ac76dac [FEATURE] Added some more json's
  • c2b0c3d [CLEANUP] Code cleanup
  • ab2bd5b [FEATURE] NPC drops are now in json
  • 391335c [CLEANUP] Removed testing class

📊 Changes

33 files changed (+513658 additions, -22442 deletions)

View changed files

➕ 2006Redone Server/data/cfg/globaldrops.json (+1927 -0)
➖ 2006Redone Server/data/cfg/globaldrops.txt (+0 -321)
➖ 2006Redone Server/data/cfg/item.cfg (+0 -9409)
➕ 2006Redone Server/data/cfg/items.json (+263398 -0)
➖ 2006Redone Server/data/cfg/npc.cfg (+0 -2911)
➕ 2006Redone Server/data/cfg/npc.json (+16646 -0)
➕ 2006Redone Server/data/cfg/npcdrops.json (+173871 -0)
➖ 2006Redone Server/data/cfg/shops.cfg (+0 -350)
➕ 2006Redone Server/data/cfg/shops.json (+15211 -0)
➖ 2006Redone Server/data/cfg/spawn-config.cfg (+0 -2461)
➕ 2006Redone Server/data/cfg/spawns.json (+23582 -0)
➕ 2006Redone Server/data/data/minutes.log (+1 -0)
➕ 2006Redone Server/data/doors.json (+12302 -0)
➖ 2006Redone Server/data/doors.txt (+0 -1025)
➕ 2006Redone Server/data/doubledoors.json (+2840 -0)
➖ 2006Redone Server/data/doubledoors.txt (+0 -258)
📝 2006Redone Server/pom.xml (+6 -2)
📝 2006Redone Server/src/main/java/com/rebotted/game/globalworldobjects/Doors.java (+298 -260)
📝 2006Redone Server/src/main/java/com/rebotted/game/globalworldobjects/DoubleDoors.java (+417 -381)
📝 2006Redone Server/src/main/java/com/rebotted/game/npcs/NpcHandler.java (+1597 -1521)

...and 13 more files

📄 Description

Data will now be loaded from .json instead of .txt or .cfg simply for readability sake.

DO NOT PUSH UNTIL I NOTIFY

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/2006-Scape/2006Scape/pull/417 **Author:** [@SandroCoutinho](https://github.com/SandroCoutinho) **Created:** 8/5/2020 **Status:** ✅ Merged **Merged:** 8/13/2020 **Merged by:** [@dginovker](https://github.com/dginovker) **Base:** `master` ← **Head:** `feature/json-data` --- ### 📝 Commits (7) - [`b4571a2`](https://github.com/2006-Scape/2006Scape/commit/b4571a28f28da94c90046ed3e8cfed7704274a64) [FEATURE] Item data is now loaded from json - [`c818b16`](https://github.com/2006-Scape/2006Scape/commit/c818b160640ec9c562e67dc1b8f019a70517393f) [TASK] Renamed the old method into it's new use - [`e1af20f`](https://github.com/2006-Scape/2006Scape/commit/e1af20f071d49968c326d3035cc3bc15619b5786) [TASK] Removed unused code - [`ac76dac`](https://github.com/2006-Scape/2006Scape/commit/ac76dac6701b92c98628f391dc3a54f8dbae5892) [FEATURE] Added some more json's - [`c2b0c3d`](https://github.com/2006-Scape/2006Scape/commit/c2b0c3d46405afb11f11224bb5609af754bcfcc1) [CLEANUP] Code cleanup - [`ab2bd5b`](https://github.com/2006-Scape/2006Scape/commit/ab2bd5bd8f59796e4237d74ef842836f27335e76) [FEATURE] NPC drops are now in json - [`391335c`](https://github.com/2006-Scape/2006Scape/commit/391335c02f0eb0730fcd2839b77ad3cc7deb6c62) [CLEANUP] Removed testing class ### 📊 Changes **33 files changed** (+513658 additions, -22442 deletions) <details> <summary>View changed files</summary> ➕ `2006Redone Server/data/cfg/globaldrops.json` (+1927 -0) ➖ `2006Redone Server/data/cfg/globaldrops.txt` (+0 -321) ➖ `2006Redone Server/data/cfg/item.cfg` (+0 -9409) ➕ `2006Redone Server/data/cfg/items.json` (+263398 -0) ➖ `2006Redone Server/data/cfg/npc.cfg` (+0 -2911) ➕ `2006Redone Server/data/cfg/npc.json` (+16646 -0) ➕ `2006Redone Server/data/cfg/npcdrops.json` (+173871 -0) ➖ `2006Redone Server/data/cfg/shops.cfg` (+0 -350) ➕ `2006Redone Server/data/cfg/shops.json` (+15211 -0) ➖ `2006Redone Server/data/cfg/spawn-config.cfg` (+0 -2461) ➕ `2006Redone Server/data/cfg/spawns.json` (+23582 -0) ➕ `2006Redone Server/data/data/minutes.log` (+1 -0) ➕ `2006Redone Server/data/doors.json` (+12302 -0) ➖ `2006Redone Server/data/doors.txt` (+0 -1025) ➕ `2006Redone Server/data/doubledoors.json` (+2840 -0) ➖ `2006Redone Server/data/doubledoors.txt` (+0 -258) 📝 `2006Redone Server/pom.xml` (+6 -2) 📝 `2006Redone Server/src/main/java/com/rebotted/game/globalworldobjects/Doors.java` (+298 -260) 📝 `2006Redone Server/src/main/java/com/rebotted/game/globalworldobjects/DoubleDoors.java` (+417 -381) 📝 `2006Redone Server/src/main/java/com/rebotted/game/npcs/NpcHandler.java` (+1597 -1521) _...and 13 more files_ </details> ### 📄 Description Data will now be loaded from `.json` instead of `.txt` or `.cfg` simply for readability sake. DO NOT PUSH UNTIL I NOTIFY --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Dark98 added the pull-request label 2026-05-21 10:16:33 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Cannot Reproduce
Difficulty: Easy
Difficulty: Easy
Difficulty: Hard
Difficulty: Medium
Documentation
enhancement
Highest Priority of Type
New Content
New Content
pull-request
Mirrored from GitHub Pull Request
 QoL
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Dark98
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 2006-Scape/2006Scape#1885
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?