2006-Scape/2006Scape
1
0
Fork 0
mirror of https://github.com/2006-Scape/2006Scape.git synced 2026-07-02 16:49:03 +00:00
Code Issues 4.5k Packages Projects Releases 10 Wiki Activity

[PR #574] [MERGED] Magic numbers & removed some dead specials #2019

New Issue
Closed
opened 2026-05-21 10:17:05 +00:00 by Dark98 · 0 comments
Dark98 commented 2026-05-21 10:17:05 +00:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/2006-Scape/2006Scape/pull/574
Author: @Dark98
Created: 2/2/2023
Status: ✅ Merged
Merged: 2/2/2023
Merged by: @Dark98

Base: master ← Head: magic-numbers

📝 Commits (4)

  • 6f9c5ae Replace Magic Numbers in Specials.java
  • f115e5d Removed Dbow, Hand Cannon & Morrigans Ranged Specs
  • 38edb7d RangeData.java Convert Magic Numbers
  • 5a72c22 DwarfCannon.java Convert Magic Numbers

📊 Changes

6 files changed (+328 additions, -427 deletions)

View changed files

📝 2006Scape Server/src/main/java/com/rs2/game/content/combat/CombatAssistant.java (+0 -20)
📝 2006Scape Server/src/main/java/com/rs2/game/content/combat/Specials.java (+27 -84)
📝 2006Scape Server/src/main/java/com/rs2/game/content/combat/melee/MeleeData.java (+1 -3)
📝 2006Scape Server/src/main/java/com/rs2/game/content/combat/range/DwarfCannon.java (+13 -14)
📝 2006Scape Server/src/main/java/com/rs2/game/content/combat/range/RangeData.java (+286 -304)
📝 2006Scape Server/src/main/java/com/rs2/game/players/Player.java (+1 -2)

📄 Description

Replaced some magic numbers & removed code relating to some special attacks for weapons released after 06

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/2006-Scape/2006Scape/pull/574 **Author:** [@Dark98](https://github.com/Dark98) **Created:** 2/2/2023 **Status:** ✅ Merged **Merged:** 2/2/2023 **Merged by:** [@Dark98](https://github.com/Dark98) **Base:** `master` ← **Head:** `magic-numbers` --- ### 📝 Commits (4) - [`6f9c5ae`](https://github.com/2006-Scape/2006Scape/commit/6f9c5ae24083dce677d255768bb368fd0f929662) Replace Magic Numbers in Specials.java - [`f115e5d`](https://github.com/2006-Scape/2006Scape/commit/f115e5dbd8fec79de42b043fef87f600470f0c1d) Removed Dbow, Hand Cannon & Morrigans Ranged Specs - [`38edb7d`](https://github.com/2006-Scape/2006Scape/commit/38edb7d06eda508493cc321c4e7318be564ce0c8) RangeData.java Convert Magic Numbers - [`5a72c22`](https://github.com/2006-Scape/2006Scape/commit/5a72c22f792247315ae675b186012eea70dfc090) DwarfCannon.java Convert Magic Numbers ### 📊 Changes **6 files changed** (+328 additions, -427 deletions) <details> <summary>View changed files</summary> 📝 `2006Scape Server/src/main/java/com/rs2/game/content/combat/CombatAssistant.java` (+0 -20) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/combat/Specials.java` (+27 -84) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/combat/melee/MeleeData.java` (+1 -3) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/combat/range/DwarfCannon.java` (+13 -14) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/combat/range/RangeData.java` (+286 -304) 📝 `2006Scape Server/src/main/java/com/rs2/game/players/Player.java` (+1 -2) </details> ### 📄 Description Replaced some magic numbers & removed code relating to some special attacks for weapons released after 06 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Dark98 added the pull-request label 2026-05-21 10:17:05 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Cannot Reproduce
Difficulty: Easy
Difficulty: Easy
Difficulty: Hard
Difficulty: Medium
Documentation
enhancement
Highest Priority of Type
New Content
New Content
pull-request
Mirrored from GitHub Pull Request
 QoL
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Dark98
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 2006-Scape/2006Scape#2019
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?