mirror of
https://github.com/2006-Scape/2006Scape.git
synced 2026-07-02 16:49:03 +00:00
[PR #540] Replace clipping files with loading straight from the cache. #2693
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Original Pull Request: https://github.com/2006-Scape/2006Scape/pull/540
State: closed
Merged: Yes
This replaces the existing clipping files with loading the data from the cache. The cache loader code is mostly unmodified, however there is a method added in the IndexedFileSystem to load the data as a byte[] rather than a bytebuffer.
Archive loading code for the map_index/loc files is from Apollo.
The accessor methods within ObjectDefinition have not been renamed to minimize the amount of changed files to allow easier merging of any existing PRs. The private values that they reference were renamed to make that easier later.
There is a readString method from a ByteBuffer currently in ObjectDefinition just because there was no obvious place forit outside of making a Utility class.
This may potentially help fix some random clipping issues because the definitions loaded by the server did not completely match the cache. This PR does not affect any clipping on doors or affect force movement (such as firemaking).