It appears that this code is related to farming and the state updating.
This PR removes a redundant and incompletely implemented tick system and converts the farming task to a cycle event. The event is not submitted for scheduling. As a result, this will not affect functionality. If the skill works correctly, the farmingtask can be removed and any methods called by it related to the state changes.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/2006-Scape/2006Scape/pull/567
**Author:** [@advnau](https://github.com/advnau)
**Created:** 1/30/2023
**Status:** ✅ Merged
**Merged:** 2/1/2023
**Merged by:** [@Dark98](https://github.com/Dark98)
**Base:** `master` ← **Head:** `farming-task`
---
### 📝 Commits (7)
- [`3953cba`](https://github.com/2006-Scape/2006Scape/commit/3953cbad1bdbab2ef7dc4231fe73347888f439cb) Firemaking: Fix some text (#548)
- [`a295c68`](https://github.com/2006-Scape/2006Scape/commit/a295c680a9bb04392f2f560eb2c159f16b88ddfb) Network cleanup (#552)
- [`78c3890`](https://github.com/2006-Scape/2006Scape/commit/78c3890be79878fb67dce7733f693865ef94c494) Redo StaticNpcList constants (#553)
- [`aff43d9`](https://github.com/2006-Scape/2006Scape/commit/aff43d968eb38dd7dfb7acadf19998c8926d9336) Bump netty-all from 4.0.34.Final to 4.1.42.Final in /2006Scape Server (#555)
- [`b9f0fb3`](https://github.com/2006-Scape/2006Scape/commit/b9f0fb3ca3718c36aab0c2f02f29214694180414) Converted FarmingTask to CycleEvent
- [`d2fadd9`](https://github.com/2006-Scape/2006Scape/commit/d2fadd94a3e923e4637e4481bd4c33ad5c337e25) Removed redundant tick system.
- [`3f3d577`](https://github.com/2006-Scape/2006Scape/commit/3f3d577124d3ecbaff1f9153e689562b8314b357) Remove redundant tick system+convert farmingtask
### 📊 Changes
**4 files changed** (+14 additions, -234 deletions)
<details>
<summary>View changed files</summary>
📝 `2006Scape Server/src/main/java/com/rs2/GameEngine.java` (+0 -14)
📝 `2006Scape Server/src/main/java/com/rs2/game/content/skills/farming/FarmingTask.java` (+14 -10)
➖ `2006Scape Server/src/main/java/com/rs2/tick/Scheduler.java` (+0 -59)
➖ `2006Scape Server/src/main/java/com/rs2/tick/Tick.java` (+0 -151)
</details>
### 📄 Description
Just noticed what appears to be an issue there is the Tick System here: https://github.com/2006-Scape/2006Scape/tree/master/2006Scape%20Server/src/main/java/com/rs2/tick
We already have a system "CycleEvents" for these tick based interactions.
That tick system is only used in the class https://github.com/2006-Scape/2006Scape/blob/master/2006Scape%20Server/src/main/java/com/rs2/game/content/skills/farming/FarmingTask.java
HOWEVER, this tick is never submitted to the gameengine for processing and the schedule/tick system is never called during the server loop.
As a result the following code is never called
It appears that this code is related to farming and the state updating.
This PR removes a redundant and incompletely implemented tick system and converts the farming task to a cycle event. The event is not submitted for scheduling. As a result, this will not affect functionality. If the skill works correctly, the farmingtask can be removed and any methods called by it related to the state changes.
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/2006-Scape/2006Scape/pull/567
Author: @advnau
Created: 1/30/2023
Status: ✅ Merged
Merged: 2/1/2023
Merged by: @Dark98
Base:
master← Head:farming-task📝 Commits (7)
3953cbaFiremaking: Fix some text (#548)a295c68Network cleanup (#552)78c3890Redo StaticNpcList constants (#553)aff43d9Bump netty-all from 4.0.34.Final to 4.1.42.Final in /2006Scape Server (#555)b9f0fb3Converted FarmingTask to CycleEventd2fadd9Removed redundant tick system.3f3d577Remove redundant tick system+convert farmingtask📊 Changes
4 files changed (+14 additions, -234 deletions)
View changed files
📝
2006Scape Server/src/main/java/com/rs2/GameEngine.java(+0 -14)📝
2006Scape Server/src/main/java/com/rs2/game/content/skills/farming/FarmingTask.java(+14 -10)➖
2006Scape Server/src/main/java/com/rs2/tick/Scheduler.java(+0 -59)➖
2006Scape Server/src/main/java/com/rs2/tick/Tick.java(+0 -151)📄 Description
Just noticed what appears to be an issue there is the Tick System here: https://github.com/2006-Scape/2006Scape/tree/master/2006Scape%20Server/src/main/java/com/rs2/tick
We already have a system "CycleEvents" for these tick based interactions.
That tick system is only used in the class https://github.com/2006-Scape/2006Scape/blob/master/2006Scape%20Server/src/main/java/com/rs2/game/content/skills/farming/FarmingTask.java
HOWEVER, this tick is never submitted to the gameengine for processing and the schedule/tick system is never called during the server loop.
As a result the following code is never called
It appears that this code is related to farming and the state updating.
This PR removes a redundant and incompletely implemented tick system and converts the farming task to a cycle event. The event is not submitted for scheduling. As a result, this will not affect functionality. If the skill works correctly, the farmingtask can be removed and any methods called by it related to the state changes.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.