2006-Scape/2006Scape
1
0
Fork 0
mirror of https://github.com/2006-Scape/2006Scape.git synced 2026-07-02 16:49:03 +00:00
Code Issues 4.5k Packages Projects Releases 10 Wiki Activity

[PR #644] [MERGED] Added NPC kill counts with message display #2758

New Issue
Closed
opened 2026-05-22 10:17:10 +00:00 by Dark98 · 0 comments
Dark98 commented 2026-05-22 10:17:10 +00:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/2006-Scape/2006Scape/pull/644
Author: @ipkpjersi
Created: 12/28/2023
Status: ✅ Merged
Merged: 9/21/2024
Merged by: @Dark98

Base: master ← Head: kclogging

📝 Commits (10+)

  • 4db9ae3 Added kill counts with message display
  • a0d834c Fixed barrows chest count
  • 4a96399 Preserve insertion order of NPC IDs for Constants
  • cfc81d5 Added KC command and interfaces
  • 3dc4826 Added more robustness to KC command
  • 4ec4df3 Added alias and documentation to new commands
  • a9cb7fd Added more aliases for new commands
  • b1d17f1 Merged slayer KC interface names
  • e62c31c Preserve slayerkc nameToKills insertion order and formatting fix
  • b029f42 Updated comment

📊 Changes

7 files changed (+318 additions, -5 deletions)

View changed files

📝 2006Scape Server/src/main/java/com/rs2/Constants.java (+90 -0)
📝 2006Scape Server/src/main/java/com/rs2/game/content/minigames/Barrows.java (+4 -0)
📝 2006Scape Server/src/main/java/com/rs2/game/npcs/Npc.java (+4 -0)
📝 2006Scape Server/src/main/java/com/rs2/game/npcs/NpcHandler.java (+16 -4)
📝 2006Scape Server/src/main/java/com/rs2/game/players/Player.java (+18 -0)
📝 2006Scape Server/src/main/java/com/rs2/game/players/PlayerSave.java (+37 -0)
📝 2006Scape Server/src/main/java/com/rs2/net/packets/impl/Commands.java (+149 -1)

📄 Description

This is a very cool system and allows for future expandability too, I have a couple of ideas building on this later on like an interface for boss NPC kills and an interface for slayer NPC kills.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/2006-Scape/2006Scape/pull/644 **Author:** [@ipkpjersi](https://github.com/ipkpjersi) **Created:** 12/28/2023 **Status:** ✅ Merged **Merged:** 9/21/2024 **Merged by:** [@Dark98](https://github.com/Dark98) **Base:** `master` ← **Head:** `kclogging` --- ### 📝 Commits (10+) - [`4db9ae3`](https://github.com/2006-Scape/2006Scape/commit/4db9ae33342ed03834aa8c5ac4ea8fb6840fb3ec) Added kill counts with message display - [`a0d834c`](https://github.com/2006-Scape/2006Scape/commit/a0d834c868bfa1db2b2b39140cf3076cb8995173) Fixed barrows chest count - [`4a96399`](https://github.com/2006-Scape/2006Scape/commit/4a96399ba2438f632319e217430b1071c8c8889f) Preserve insertion order of NPC IDs for Constants - [`cfc81d5`](https://github.com/2006-Scape/2006Scape/commit/cfc81d5825976ba991c50ef100aa463c40b33c2a) Added KC command and interfaces - [`3dc4826`](https://github.com/2006-Scape/2006Scape/commit/3dc48269ec10c8efc572b85bf36cb109272fe815) Added more robustness to KC command - [`4ec4df3`](https://github.com/2006-Scape/2006Scape/commit/4ec4df38b77b1f8cbe89aa1bff8312f9edae7751) Added alias and documentation to new commands - [`a9cb7fd`](https://github.com/2006-Scape/2006Scape/commit/a9cb7fdeadf44b3aa96f237cfa077dc77fe54b1f) Added more aliases for new commands - [`b1d17f1`](https://github.com/2006-Scape/2006Scape/commit/b1d17f1278ea5183e9970111bddd34e97884a794) Merged slayer KC interface names - [`e62c31c`](https://github.com/2006-Scape/2006Scape/commit/e62c31c14f24b155ca86360ffc3ef0a439698602) Preserve slayerkc nameToKills insertion order and formatting fix - [`b029f42`](https://github.com/2006-Scape/2006Scape/commit/b029f42a4bf527fb05f9e631d96cf2a6348d9c95) Updated comment ### 📊 Changes **7 files changed** (+318 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `2006Scape Server/src/main/java/com/rs2/Constants.java` (+90 -0) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/minigames/Barrows.java` (+4 -0) 📝 `2006Scape Server/src/main/java/com/rs2/game/npcs/Npc.java` (+4 -0) 📝 `2006Scape Server/src/main/java/com/rs2/game/npcs/NpcHandler.java` (+16 -4) 📝 `2006Scape Server/src/main/java/com/rs2/game/players/Player.java` (+18 -0) 📝 `2006Scape Server/src/main/java/com/rs2/game/players/PlayerSave.java` (+37 -0) 📝 `2006Scape Server/src/main/java/com/rs2/net/packets/impl/Commands.java` (+149 -1) </details> ### 📄 Description This is a very cool system and allows for future expandability too, I have a couple of ideas building on this later on like an interface for boss NPC kills and an interface for slayer NPC kills. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Dark98 added the pull-request label 2026-05-22 10:17:10 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Cannot Reproduce
Difficulty: Easy
Difficulty: Easy
Difficulty: Hard
Difficulty: Medium
Documentation
enhancement
Highest Priority of Type
New Content
New Content
pull-request
Mirrored from GitHub Pull Request
 QoL
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Dark98
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 2006-Scape/2006Scape#2758
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?