2006-Scape/2006Scape
1
0
Fork 0
mirror of https://github.com/2006-Scape/2006Scape.git synced 2026-07-03 00:31:51 +00:00
Code Issues 4.5k Packages Projects Releases 10 Wiki Activity

[PR #650] Fixed dueling NPE #2766

New Issue
Open
opened 2026-05-22 10:17:12 +00:00 by Dark98 · 0 comments
Dark98 commented 2026-05-22 10:17:12 +00:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/2006-Scape/2006Scape/pull/650

State: open
Merged: No

Why was this null? Right clicking player and sending duel request via "Challenge" option produces an NPE, because packet is null, but ChallengePlayer checks packet.getOpcode() value without checking if packet is null first. Dueling, sending a challenge, etc all that still works fine even with an NPE but why have an NPE in the first place?

This closes #639 but is it correct?

**Original Pull Request:** https://github.com/2006-Scape/2006Scape/pull/650 **State:** open **Merged:** No --- Why was this null? Right clicking player and sending duel request via "Challenge" option produces an NPE, because packet is null, but ChallengePlayer checks packet.getOpcode() value without checking if packet is null first. Dueling, sending a challenge, etc all that still works fine even with an NPE but why have an NPE in the first place? This closes #639 but is it correct?
Dark98 added the pull-request label 2026-05-22 10:17:12 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Cannot Reproduce
Difficulty: Easy
Difficulty: Easy
Difficulty: Hard
Difficulty: Medium
Documentation
enhancement
Highest Priority of Type
New Content
New Content
pull-request
Mirrored from GitHub Pull Request
 QoL
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Dark98
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 2006-Scape/2006Scape#2766
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?