Calling random inside the Glory loop results in multiple rolls, potentially hiding the double giveGem check.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/2006-Scape/2006Scape/pull/474
**Author:** [@nickgal](https://github.com/nickgal)
**Created:** 2/4/2021
**Status:** ✅ Merged
**Merged:** 2/5/2021
**Merged by:** [@dginovker](https://github.com/dginovker)
**Base:** `master` ← **Head:** `gem-chance`
---
### 📝 Commits (1)
- [`ff53b9f`](https://github.com/2006-Scape/2006Scape/commit/ff53b9f0e48d01e585d783642568197c82c199dd) Fix gem check being rolled twice.
### 📊 Changes
**1 file changed** (+7 additions, -8 deletions)
<details>
<summary>View changed files</summary>
📝 `2006Redone Server/src/main/java/com/rebotted/game/content/skills/core/Mining.java` (+7 -8)
</details>
### 📄 Description
`giveGem` roll is not needed in `obtainGem` because it is already checked in order to call `obtainGem`.
https://github.com/2006rebotted/2006rebotted/blob/15ab6253499e5f5a38372a296d35aa30492dd6d6/2006Redone%20Server/src/main/java/com/rebotted/game/content/skills/core/Mining.java#L232-L238
Calling random inside the Glory loop results in multiple rolls, potentially hiding the double `giveGem` check.
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/2006-Scape/2006Scape/pull/474
Author: @nickgal
Created: 2/4/2021
Status: ✅ Merged
Merged: 2/5/2021
Merged by: @dginovker
Base:
master← Head:gem-chance📝 Commits (1)
ff53b9fFix gem check being rolled twice.📊 Changes
1 file changed (+7 additions, -8 deletions)
View changed files
📝
2006Redone Server/src/main/java/com/rebotted/game/content/skills/core/Mining.java(+7 -8)📄 Description
giveGemroll is not needed inobtainGembecause it is already checked in order to callobtainGem.https://github.com/2006rebotted/2006rebotted/blob/15ab6253499e5f5a38372a296d35aa30492dd6d6/2006Redone%20Server/src/main/java/com/rebotted/game/content/skills/core/Mining.java#L232-L238
Calling random inside the Glory loop results in multiple rolls, potentially hiding the double
giveGemcheck.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.