2006-Scape/2006Scape
1
0
Fork 0
mirror of https://github.com/2006-Scape/2006Scape.git synced 2026-07-02 16:49:03 +00:00
Code Issues 4.5k Packages Projects Releases 10 Wiki Activity

[PR #512] Astraeus Dialogue System Port #3357

New Issue
Closed
opened 2026-05-24 12:21:29 +00:00 by Dark98 · 0 comments
Dark98 commented 2026-05-24 12:21:29 +00:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/2006-Scape/2006Scape/pull/512

State: closed
Merged: Yes

I figured I consider trying to port something over from Astraeus considering the plugin system was implemented recently. Surprisingly, I was able to port over the Dialogue System without much issue. The only other thing I did was add a line split function so that dialogues can be setup easier.

It's missing a couple of existing interfaces from the current DialogueHandler file, but it should be simple enough to move them over.

Change Summary

  • Refactored Dialogue.java into DialoguePacket.java
    • Also moved into the packets package
  • Implemented Astraeus Dialogue System
  • Added line split function in the Astraeus Dialogue System
  • Ported Over Man and Woman NPC dialogues
    • Added Missing Dialogues
    • Removed Existing Dialogues in the Dialogue Handler
  • Ported Over Banker Dialogue
    • Added Missing Dialogues
    • Removed Existing Dialogues in the Dialogue Handler
      • P I N removal notice remains in Dialogue Handler
  • Adjusted the Old Dialogues Option Handler to be ordered by Interface (Option Interface 2, 3, 4, and 5)
  • Adjusted the Misc.java file to be ordered by String, Number, RNG, and Positioning Functions
  • Marked Old Dialogue System as Deprecated
  • Removed StaticNpcList.java as it was unused and the NPC IDs were very inaccurate
**Original Pull Request:** https://github.com/2006-Scape/2006Scape/pull/512 **State:** closed **Merged:** Yes --- I figured I consider trying to port something over from Astraeus considering the plugin system was implemented recently. Surprisingly, I was able to port over the Dialogue System without much issue. The only other thing I did was add a line split function so that dialogues can be setup easier. <br /> It's missing a couple of existing interfaces from the current DialogueHandler file, but it should be simple enough to move them over. ### Change Summary - Refactored Dialogue.java into DialoguePacket.java - Also moved into the packets package - Implemented Astraeus Dialogue System - Added line split function in the Astraeus Dialogue System - Ported Over Man and Woman NPC dialogues - Added Missing Dialogues - Removed Existing Dialogues in the Dialogue Handler - Ported Over Banker Dialogue - Added Missing Dialogues - Removed Existing Dialogues in the Dialogue Handler - P I N removal notice remains in Dialogue Handler - Adjusted the Old Dialogues Option Handler to be ordered by Interface (Option Interface 2, 3, 4, and 5) - Adjusted the Misc.java file to be ordered by String, Number, RNG, and Positioning Functions - Marked Old Dialogue System as Deprecated - Removed StaticNpcList.java as it was unused and the NPC IDs were very inaccurate
Dark98 added the pull-request label 2026-05-24 12:21:29 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Cannot Reproduce
Difficulty: Easy
Difficulty: Easy
Difficulty: Hard
Difficulty: Medium
Documentation
enhancement
Highest Priority of Type
New Content
New Content
pull-request
Mirrored from GitHub Pull Request
 QoL
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Dark98
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 2006-Scape/2006Scape#3357
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?