2006-Scape/2006Scape
1
0
Fork 0
mirror of https://github.com/2006-Scape/2006Scape.git synced 2026-07-02 16:49:03 +00:00
Code Issues 4.5k Packages Projects Releases 10 Wiki Activity

[GH-ISSUE #107] Client Sell-10 currently executes Sell-All #3522

New Issue
Closed
opened 2026-05-25 12:19:36 +00:00 by Dark98 · 9 comments
Dark98 commented 2026-05-25 12:19:36 +00:00
Owner
Copy Link
Copy Source

Originally created by @dginovker on GitHub (Oct 25, 2019).
Original GitHub issue: https://github.com/2006-Scape/2006Scape/issues/107

Originally assigned to: @Gptaqbc on GitHub.

& When buying items all items disappear

Originally created by @dginovker on GitHub (Oct 25, 2019). Original GitHub issue: https://github.com/2006-Scape/2006Scape/issues/107 Originally assigned to: @Gptaqbc on GitHub. & When buying items all items disappear
Dark98 added the Difficulty: Easy label 2026-05-25 12:19:36 +00:00
Dark98 commented 2026-05-25 12:19:36 +00:00
Author
Owner
Copy Link
Copy Source

@Gptaqbc commented on GitHub (Oct 27, 2019):

What do you mean by string needs to be fixed?

<!-- gh-comment-id:546740979 --> @Gptaqbc commented on GitHub (Oct 27, 2019): What do you mean by string needs to be fixed?
Dark98 commented 2026-05-25 12:19:37 +00:00
Author
Owner
Copy Link
Copy Source

@RedSparr0w commented on GitHub (Oct 27, 2019):

Menu item needs to be modified:
Sell 5 -> Sell 10
Sell 10 → Sell All

<!-- gh-comment-id:546741089 --> @RedSparr0w commented on GitHub (Oct 27, 2019): Menu item needs to be modified: `Sell 5` -> `Sell 10` `Sell 10` → `Sell All`
Dark98 commented 2026-05-25 12:19:37 +00:00
Author
Owner
Copy Link
Copy Source

@Gptaqbc commented on GitHub (Oct 27, 2019):

Oh alright. I'll do that!

<!-- gh-comment-id:546741246 --> @Gptaqbc commented on GitHub (Oct 27, 2019): Oh alright. I'll do that!
Dark98 commented 2026-05-25 12:19:37 +00:00
Author
Owner
Copy Link
Copy Source

@Gptaqbc commented on GitHub (Oct 27, 2019):

You got any hint about where I have to look? Looking for Sell 10 doesn't give anything.

<!-- gh-comment-id:546741339 --> @Gptaqbc commented on GitHub (Oct 27, 2019): You got any hint about where I have to look? Looking for Sell 10 doesn't give anything.
Dark98 commented 2026-05-25 12:19:37 +00:00
Author
Owner
Copy Link
Copy Source

@RedSparr0w commented on GitHub (Oct 27, 2019):

Not sure sorry, haven't looked into any of the client sided things yet.

<!-- gh-comment-id:546741391 --> @RedSparr0w commented on GitHub (Oct 27, 2019): Not sure sorry, haven't looked into any of the client sided things yet.
Dark98 commented 2026-05-25 12:19:37 +00:00
Author
Owner
Copy Link
Copy Source

@Gptaqbc commented on GitHub (Oct 27, 2019):

RSInterface.java

Sell 1 → 1
Sell 5 → 10
Sell 10 → All

Code to modify: around line 108...
This add a sell all option... it needs some work done though.
if(rsInterface.parentID == shop interface id) rsInterface.itemActions[buy all menu action number] = "Sell All";

<!-- gh-comment-id:546745356 --> @Gptaqbc commented on GitHub (Oct 27, 2019): RSInterface.java Sell 1 → 1 Sell 5 → 10 Sell 10 → All Code to modify: around line 108... This add a sell all option... it needs some work done though. if(rsInterface.parentID == shop interface id) rsInterface.itemActions[buy all menu action number] = "Sell All";
Dark98 commented 2026-05-25 12:19:37 +00:00
Author
Owner
Copy Link
Copy Source

@Gptaqbc commented on GitHub (Oct 28, 2019):

To do:

  1. Replace Buy 10 by buy X - Server side; -Done
  2. Fix selling options that currently only sells 1 at a time; -Done
  3. Add sell all feature for non-stackable items; -Done
  4. Fix amount of gp received when selling more than 1;
  5. Replaced noted items in shops for un-noted version; -Done
  6. Implement Sell X - Server side; -Done
  7. Fix buy/sell delay(loop) that causes lags; -Done
    (Some of these issues are also happening with trading)
<!-- gh-comment-id:546752673 --> @Gptaqbc commented on GitHub (Oct 28, 2019): To do: 1. Replace Buy 10 by buy X - Server side; -Done 2. Fix selling options that currently only sells 1 at a time; -Done 3. Add sell all feature for non-stackable items; -Done 4. Fix amount of gp received when selling more than 1; 5. Replaced noted items in shops for un-noted version; -Done 6. Implement Sell X - Server side; -Done 7. Fix buy/sell delay(loop) that causes lags; -Done (Some of these issues are also happening with trading)
Dark98 commented 2026-05-25 12:19:37 +00:00
Author
Owner
Copy Link
Copy Source

@RedSparr0w commented on GitHub (Oct 28, 2019):

Not sure what you mean by 2?
I'm pretty sure we replaced the loop that it used to use.

<!-- gh-comment-id:546752770 --> @RedSparr0w commented on GitHub (Oct 28, 2019): Not sure what you mean by `2`? I'm pretty sure we replaced the loop that it used to use.
Dark98 commented 2026-05-25 12:19:37 +00:00
Author
Owner
Copy Link
Copy Source

@Gptaqbc commented on GitHub (Nov 1, 2019):

@RedSparr0w Yeah it needed some work because it was causing lag when buying more than a couple item at once.

<!-- gh-comment-id:548773950 --> @Gptaqbc commented on GitHub (Nov 1, 2019): @RedSparr0w Yeah it needed some work because it was causing lag when buying more than a couple item at once.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Cannot Reproduce
Difficulty: Easy
Difficulty: Easy
Difficulty: Hard
Difficulty: Medium
Documentation
enhancement
Highest Priority of Type
New Content
New Content
pull-request
Mirrored from GitHub Pull Request
 QoL
No Label Difficulty: Easy
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Dark98
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 2006-Scape/2006Scape#3522
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?