2006-Scape/2006Scape
1
0
Fork 0
mirror of https://github.com/2006-Scape/2006Scape.git synced 2026-07-02 16:49:03 +00:00
Code Issues 4.5k Packages Projects Releases 10 Wiki Activity

[PR #193] [MERGED] Update drop handling, Allow rares, Remove some logging #366

New Issue
Closed
opened 2026-05-15 02:57:13 +00:00 by Dark98 · 0 comments
Dark98 commented 2026-05-15 02:57:13 +00:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/2006-Scape/2006Scape/pull/193
Author: @RedSparr0w
Created: 11/17/2019
Status: ✅ Merged
Merged: 11/18/2019
Merged by: @dginovker

Base: master ← Head: drops

📝 Commits (10+)

  • 0e1e079 Fix local Parabot instructions
  • 8c8428e Merge remote-tracking branch 'upstream/master'
  • 484d5d6 Merge remote-tracking branch 'upstream/master'
  • 21a379e Merge remote-tracking branch 'upstream/master'
  • 30a4a7a Add kick command, and force logout function
  • 53a8582 Merge remote-tracking branch 'upstream/master'
  • 9a06cfb Merge remote-tracking branch 'upstream/master'
  • d11622a Merge remote-tracking branch 'upstream/master'
  • a6a8a9e Allow rare items (phats etc)
  • 1adccc1 remove random server logging

📊 Changes

7 files changed (+2430 additions, -2370 deletions)

View changed files

📝 2006Redone Server/src/redone/game/items/Item.java (+0 -5)
📝 2006Redone Server/src/redone/game/items/impl/RareProtection.java (+14 -8)
📝 2006Redone Server/src/redone/game/npcs/NpcHandler.java (+76 -59)
➕ 2006Redone Server/src/redone/game/npcs/drops/ItemDrop.java (+32 -0)
📝 2006Redone Server/src/redone/game/npcs/drops/NPCDrops.java (+2302 -2291)
📝 2006Redone Server/src/redone/game/npcs/drops/NPCDropsHandler.java (+5 -6)
📝 2006Redone Server/src/redone/net/packets/impl/Commands.java (+1 -1)

📄 Description

Update drop handling

  • random amount on drop (not constant random on server restart)
  • rarity is consistent (not constant random on server restart)

Allow rare items

  • phats
  • crackers
  • other stuff

Remove some logging that was leftover from other PRs

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/2006-Scape/2006Scape/pull/193 **Author:** [@RedSparr0w](https://github.com/RedSparr0w) **Created:** 11/17/2019 **Status:** ✅ Merged **Merged:** 11/18/2019 **Merged by:** [@dginovker](https://github.com/dginovker) **Base:** `master` ← **Head:** `drops` --- ### 📝 Commits (10+) - [`0e1e079`](https://github.com/2006-Scape/2006Scape/commit/0e1e07924b527562074acf9761b5535f7823f98c) Fix local Parabot instructions - [`8c8428e`](https://github.com/2006-Scape/2006Scape/commit/8c8428e0be3e0d5e80fdbbbe1424ead4c17f6cf1) Merge remote-tracking branch 'upstream/master' - [`484d5d6`](https://github.com/2006-Scape/2006Scape/commit/484d5d68ab08e6f9a1e3fe409c3a01dc9d4338b4) Merge remote-tracking branch 'upstream/master' - [`21a379e`](https://github.com/2006-Scape/2006Scape/commit/21a379ed8efbd4435f8e7fb4ee1bb443b2b41cf6) Merge remote-tracking branch 'upstream/master' - [`30a4a7a`](https://github.com/2006-Scape/2006Scape/commit/30a4a7a10f4c1277b8f06424af374aab168f016c) Add kick command, and force logout function - [`53a8582`](https://github.com/2006-Scape/2006Scape/commit/53a8582308af59f8359c93199acdef981ca26fea) Merge remote-tracking branch 'upstream/master' - [`9a06cfb`](https://github.com/2006-Scape/2006Scape/commit/9a06cfbfb45acb7b79fcd9d8fac7999c174e21c7) Merge remote-tracking branch 'upstream/master' - [`d11622a`](https://github.com/2006-Scape/2006Scape/commit/d11622ac504068da4a546f3b09004bc5f21ba6c0) Merge remote-tracking branch 'upstream/master' - [`a6a8a9e`](https://github.com/2006-Scape/2006Scape/commit/a6a8a9e2551ccb55e9d4b07b0f12eff360066b52) Allow rare items (phats etc) - [`1adccc1`](https://github.com/2006-Scape/2006Scape/commit/1adccc1d35b4b4120720596ae5dfe70f64674894) remove random server logging ### 📊 Changes **7 files changed** (+2430 additions, -2370 deletions) <details> <summary>View changed files</summary> 📝 `2006Redone Server/src/redone/game/items/Item.java` (+0 -5) 📝 `2006Redone Server/src/redone/game/items/impl/RareProtection.java` (+14 -8) 📝 `2006Redone Server/src/redone/game/npcs/NpcHandler.java` (+76 -59) ➕ `2006Redone Server/src/redone/game/npcs/drops/ItemDrop.java` (+32 -0) 📝 `2006Redone Server/src/redone/game/npcs/drops/NPCDrops.java` (+2302 -2291) 📝 `2006Redone Server/src/redone/game/npcs/drops/NPCDropsHandler.java` (+5 -6) 📝 `2006Redone Server/src/redone/net/packets/impl/Commands.java` (+1 -1) </details> ### 📄 Description Update drop handling - random amount on drop (not constant random on server restart) - rarity is consistent (not constant random on server restart) Allow rare items - phats - crackers - other stuff Remove some logging that was leftover from other PRs --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Dark98 added the pull-request label 2026-05-15 02:57:13 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Cannot Reproduce
Difficulty: Easy
Difficulty: Easy
Difficulty: Hard
Difficulty: Medium
Documentation
enhancement
Highest Priority of Type
New Content
New Content
pull-request
Mirrored from GitHub Pull Request
 QoL
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Dark98
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 2006-Scape/2006Scape#366
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?