2006-Scape/2006Scape
1
0
Fork 0
mirror of https://github.com/2006-Scape/2006Scape.git synced 2026-10-01 02:17:17 +00:00
Code Issues 4.5k Packages Projects Releases 10 Wiki Activity

[PR #254] [MERGED] Remove rare protection, add all NPCs to a static list #3864

New Issue
Closed
opened 2026-05-25 12:21:02 +00:00 by Dark98 · 0 comments
Dark98 commented 2026-05-25 12:21:02 +00:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/2006-Scape/2006Scape/pull/254
Author: @dginovker
Created: 12/10/2019
Status: ✅ Merged
Merged: 12/10/2019
Merged by: @dginovker

Base: master ← Head: rare_protection_and_static_npc_list

📝 Commits (1)

  • 032b96d Remove rare protection, add all NPCs to a static list

📊 Changes

6 files changed (+7736 additions, -1 deletions)

View changed files

➕ 2006Redone Server/src/com/rebotted/game/content/combat/npcs/StaticNpcList.java (+7735 -0)
📝 2006Redone Server/src/com/rebotted/game/items/impl/RareProtection.java (+1 -1)
➕ CompiledServer/production/2006rebotted/META-INF/2006rebotted.kotlin_module (+0 -0)
➕ CompiledServer/production/2006rebotted/com/rebotted/game/content/combat/npcs/StaticNpcList.class (+0 -0)
📝 CompiledServer/production/2006rebotted/com/rebotted/game/items/impl/RareProtection.class (+0 -0)
📝 CompiledServer/production/2006rebotted/com/rebotted/net/packets/impl/ItemOnPlayer.class (+0 -0)

📄 Description

  • Removing rare protection to give awards
  • NPCs in static list is beginning of a potential future where rather than getting NPCs by their ID, we can just do something like NpcStatic.MAN_3, which in some areas of the code could make it more legible

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/2006-Scape/2006Scape/pull/254 **Author:** [@dginovker](https://github.com/dginovker) **Created:** 12/10/2019 **Status:** ✅ Merged **Merged:** 12/10/2019 **Merged by:** [@dginovker](https://github.com/dginovker) **Base:** `master` ← **Head:** `rare_protection_and_static_npc_list` --- ### 📝 Commits (1) - [`032b96d`](https://github.com/2006-Scape/2006Scape/commit/032b96dc7006330e0f2920d2887b7a78c22017f2) Remove rare protection, add all NPCs to a static list ### 📊 Changes **6 files changed** (+7736 additions, -1 deletions) <details> <summary>View changed files</summary> ➕ `2006Redone Server/src/com/rebotted/game/content/combat/npcs/StaticNpcList.java` (+7735 -0) 📝 `2006Redone Server/src/com/rebotted/game/items/impl/RareProtection.java` (+1 -1) ➕ `CompiledServer/production/2006rebotted/META-INF/2006rebotted.kotlin_module` (+0 -0) ➕ `CompiledServer/production/2006rebotted/com/rebotted/game/content/combat/npcs/StaticNpcList.class` (+0 -0) 📝 `CompiledServer/production/2006rebotted/com/rebotted/game/items/impl/RareProtection.class` (+0 -0) 📝 `CompiledServer/production/2006rebotted/com/rebotted/net/packets/impl/ItemOnPlayer.class` (+0 -0) </details> ### 📄 Description - Removing rare protection to give awards - NPCs in static list is beginning of a potential future where rather than getting NPCs by their ID, we can just do something like NpcStatic.MAN_3, which in some areas of the code could make it more legible --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Dark98 added the pull-request label 2026-05-25 12:21:02 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Cannot Reproduce
Difficulty: Easy
Difficulty: Easy
Difficulty: Hard
Difficulty: Medium
Documentation
Highest Priority of Type
New Content
New Content
QoL
enhancement
pull-request
Mirrored from GitHub Pull Request
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Dark98
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 2006-Scape/2006Scape#3864