Wow, this was a ton of effort to clean up this PR but I think I did it properly. I tried many things, but ultimately I had to interactive rebase and just drop the commits I didn't want that were from other branches. My old PR I closed was 7 files changed and this new PR is 7 files changed, so it's extremely likely I did clean up this branch properly.
Anyway, onto this feature:
This is probably fine to merge. It doesn't fix all pathing bugs that currently exist (it doesn't fix player clipping when moving/attacking/clicking on objects etc), that would likely be a ton of work, but this does address not handling NPC size > 1 pathing, and it doesn't seem to introduce any new bugs.
With that said, I'll go ahead and mark this as draft for now so we can make sure it gets tested more first since I don't really consider it completely fully tested. Marked as ready, we can review it/merge it whenever.
**Original Pull Request:** https://github.com/2006-Scape/2006Scape/pull/658
**State:** open
**Merged:** No
---
Wow, this was a ton of effort to clean up this PR but I think I did it properly. I tried many things, but ultimately I had to interactive rebase and just drop the commits I didn't want that were from other branches. My old PR I closed was 7 files changed and this new PR is 7 files changed, so it's extremely likely I did clean up this branch properly.
Anyway, onto this feature:
This is probably fine to merge. It doesn't fix all pathing bugs that currently exist (it doesn't fix player clipping when moving/attacking/clicking on objects etc), that would likely be a ton of work, but this does address not handling NPC size > 1 pathing, and it doesn't seem to introduce any new bugs.
~~With that said, I'll go ahead and mark this as draft for now so we can make sure it gets tested more first since I don't really consider it completely fully tested.~~ Marked as ready, we can review it/merge it whenever.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Original Pull Request: https://github.com/2006-Scape/2006Scape/pull/658
State: open
Merged: No
Wow, this was a ton of effort to clean up this PR but I think I did it properly. I tried many things, but ultimately I had to interactive rebase and just drop the commits I didn't want that were from other branches. My old PR I closed was 7 files changed and this new PR is 7 files changed, so it's extremely likely I did clean up this branch properly.
Anyway, onto this feature:
This is probably fine to merge. It doesn't fix all pathing bugs that currently exist (it doesn't fix player clipping when moving/attacking/clicking on objects etc), that would likely be a ton of work, but this does address not handling NPC size > 1 pathing, and it doesn't seem to introduce any new bugs.
With that said, I'll go ahead and mark this as draft for now so we can make sure it gets tested more first since I don't really consider it completely fully tested.Marked as ready, we can review it/merge it whenever.