2006-Scape/2006Scape
1
0
Fork 0
mirror of https://github.com/2006-Scape/2006Scape.git synced 2026-07-02 16:49:03 +00:00
Code Issues 4.5k Packages Projects Releases 10 Wiki Activity

[PR #420] [MERGED] Mining Fixes | Yell Command Fix #488

New Issue
Closed
opened 2026-05-15 02:57:37 +00:00 by Dark98 · 0 comments
Dark98 commented 2026-05-15 02:57:37 +00:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/2006-Scape/2006Scape/pull/420
Author: @PeterFarber
Created: 9/29/2020
Status: ✅ Merged
Merged: 9/29/2020
Merged by: @dginovker

Base: master ← Head: FxxXSociety

📝 Commits (2)

  • a1cc421 Fixed Yell Command
  • 32aee02 Added Mining Sounds. Fixed Addy and Mith Pickages.

📊 Changes

2 files changed (+5 additions, -3 deletions)

View changed files

📝 2006Redone Server/src/main/java/com/rebotted/game/content/skills/core/Mining.java (+4 -2)
📝 2006Redone Server/src/main/java/com/rebotted/net/packets/impl/Commands.java (+1 -1)

📄 Description

Description

Mining

  • Fixed Mining Pickaxes: When using a mith pickaxe it showed it using addy and vise versa.
  • Added Mining Sounds.

Commands

  • Fixed Yell Command: It was originally using playerCommand.substring(5) which would return index out of bounds. (Changed to argument[0].

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/2006-Scape/2006Scape/pull/420 **Author:** [@PeterFarber](https://github.com/PeterFarber) **Created:** 9/29/2020 **Status:** ✅ Merged **Merged:** 9/29/2020 **Merged by:** [@dginovker](https://github.com/dginovker) **Base:** `master` ← **Head:** `FxxXSociety` --- ### 📝 Commits (2) - [`a1cc421`](https://github.com/2006-Scape/2006Scape/commit/a1cc42143bba0a1b7fbb49e4146a7f41c62071a7) Fixed Yell Command - [`32aee02`](https://github.com/2006-Scape/2006Scape/commit/32aee0211ad840a010dca4c93b202f162c8211f2) Added Mining Sounds. Fixed Addy and Mith Pickages. ### 📊 Changes **2 files changed** (+5 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `2006Redone Server/src/main/java/com/rebotted/game/content/skills/core/Mining.java` (+4 -2) 📝 `2006Redone Server/src/main/java/com/rebotted/net/packets/impl/Commands.java` (+1 -1) </details> ### 📄 Description ### Description **Mining** - Fixed Mining Pickaxes: When using a mith pickaxe it showed it using addy and vise versa. - Added Mining Sounds. **Commands** - Fixed Yell Command: It was originally using playerCommand.substring(5) which would return index out of bounds. (Changed to argument[0]. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Dark98 added the pull-request label 2026-05-15 02:57:37 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Cannot Reproduce
Difficulty: Easy
Difficulty: Easy
Difficulty: Hard
Difficulty: Medium
Documentation
enhancement
Highest Priority of Type
New Content
New Content
pull-request
Mirrored from GitHub Pull Request
 QoL
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Dark98
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 2006-Scape/2006Scape#488
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?