[GH-ISSUE #59] Trading system flaws #4898

New Issue

2026-05-27T12:19:40Z

Dark98 commented

2026-05-27 12:19:40 +00:00

Originally created by @Gptaqbc on GitHub (Oct 15, 2019).
Original GitHub issue: https://github.com/2006-Scape/2006Scape/issues/59

It seems there is a problem with the coding of the trading system between players.
I tested it this week-end and here are my observations.

I'll explain the expected process:

P1 clicks trade on P2;
P1 moves next to P2 to send him the request;
P2 receive and accpet the request;
Trade screen opens;
-- Anything happening here that isn't adding/removing items or accepting in the trade screen abort the trade process ---
P1 & P2 accepts screen 1;
-- Anything happening here that accepting in the trade screen abort the trade process ---
P1 & P2 accepts screen 2;

Trade completed

Here's a list of the problem with our trading system:

After the trade request is sent (click trade player) both players doesn't have to be next to each other to initiate the trading process and complete the trade.
A player can quit the trade screen by clicking the minimap but it's not declining it for the other player. Let's call this solo trading interface.
When a player is stuck in the solo trading interface he can still fill the trade screen with items. If the other player that initiated the trade proceed to logout, the trade screen will close but the items will stay in the trade screen until the players trade again. This is a big issues as it can expand the inventory by 28 slots for every player.

Originally created by @Gptaqbc on GitHub (Oct 15, 2019). Original GitHub issue: https://github.com/2006-Scape/2006Scape/issues/59 It seems there is a problem with the coding of the trading system between players. I tested it this week-end and here are my observations. I'll explain the expected process: > P1 clicks trade on P2; > P1 moves next to P2 to send him the request; > P2 receive and accpet the request; > Trade screen opens; -- Anything happening here that isn't adding/removing items or accepting in the trade screen abort the trade process --- > P1 & P2 accepts screen 1; -- Anything happening here that accepting in the trade screen abort the trade process --- > P1 & P2 accepts screen 2; >>Trade completed **Here's a list of the problem with our trading system**: - After the trade request is sent (click trade player) both players doesn't have to be next to each other to initiate the trading process and complete the trade. - A player can quit the trade screen by clicking the minimap but it's not declining it for the other player. Let's call this **solo trading interface**. - When a player is stuck in the **solo trading interface** he can still fill the trade screen with items. If the other player that initiated the trade proceed to logout, the trade screen will close but **the items will stay in the trade screen** until the players trade again. _This is a big issues as it can expand the inventory by 28 slots for every player._

Dark98 added the Difficulty: Medium label 2026-05-27 12:19:40 +00:00

Dark98 closed this issue

2026-05-27 12:19:40 +00:00

Dark98 commented

2026-05-27 12:19:41 +00:00

@Gptaqbc commented on GitHub (Oct 24, 2019):

Here: https://github.com/dginovker/2006rebotted/blob/ea513131259e183017476cb3177649c804a35af9/2006Redone%20Server/src/redone/net/packets/impl/ClickingStuff.java#L34

player.getTrading().declineTrade();

What about adding oponnent.getTrading().declineTrade(); too? That should close the trade screen for both players. That should fix the issue with being able to store items in the trading interface. I'll try soon.

@Gptaqbc commented on GitHub (Oct 24, 2019): Here: https://github.com/dginovker/2006rebotted/blob/ea513131259e183017476cb3177649c804a35af9/2006Redone%20Server/src/redone/net/packets/impl/ClickingStuff.java#L34 > player.getTrading().declineTrade(); What about adding oponnent.getTrading().declineTrade(); too? That should close the trade screen for both players. That should fix the issue with being able to store items in the trading interface. I'll try soon.

Dark98 commented

2026-05-27 12:19:41 +00:00

@Gptaqbc commented on GitHub (Oct 26, 2019):

Almost completed. Can you assign me on the issue?

@Gptaqbc commented on GitHub (Oct 26, 2019): Almost completed. Can you assign me on the issue?

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: 2006-Scape/2006Scape#4898