2006-Scape/2006Scape
1
0
Fork 0
mirror of https://github.com/2006-Scape/2006Scape.git synced 2026-07-02 16:49:03 +00:00
Code Issues 4.5k Packages Projects Releases 10 Wiki Activity

[PR #133] [MERGED] Buy/sell x buying loop lagging issue fix general shop using fixes trading amount fix #5214

New Issue
Closed
opened 2026-05-27 12:21:16 +00:00 by Dark98 · 0 comments
Dark98 commented 2026-05-27 12:21:16 +00:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/2006-Scape/2006Scape/pull/133
Author: @Gptaqbc
Created: 11/3/2019
Status: ✅ Merged
Merged: 11/4/2019
Merged by: @dginovker

Base: master ← Head: Buy/Sell-X--Buying-loop-lagging-issue-fix--General-shop-using-fixes--Trading-amount-fix

📝 Commits (4)

  • 1c4be29 Update NpcHandler.class
  • db62ca1 Update NpcHandler.java
  • 8a0b9c3 Buy/Sell-X--Buying-loop-lagging-issue-fix--General-shop-using-fixes--Trading-amount-fix
  • 6f2334f Merge remote-tracking branch 'upstream/master' into Buy/Sell-X--Buying-loop-lagging-issue-fix--General-shop-using-fixes--Trading-amount-fix

📊 Changes

8 files changed (+200 additions, -112 deletions)

View changed files

📝 2006Redone Client/src/RSInterface.java (+8 -0)
📝 2006Redone Server/src/redone/game/players/Player.java (+4 -27)
📝 2006Redone Server/src/redone/game/players/Trading.java (+4 -1)
📝 2006Redone Server/src/redone/game/shops/ShopAssistant.java (+129 -31)
📝 2006Redone Server/src/redone/net/packets/impl/Bank5.java (+1 -1)
📝 2006Redone Server/src/redone/net/packets/impl/BankAll.java (+9 -3)
📝 2006Redone Server/src/redone/net/packets/impl/BankX1.java (+1 -9)
📝 2006Redone Server/src/redone/net/packets/impl/BankX2.java (+44 -40)

📄 Description

closes #107
Buying-loop-lagging-issue-fix--General-shop-using-fixes--Trading-amount-fix

Trading-amount-fix

  • Added buy/sell X feature
  • Fixed a lag with the buying loop when buying high amount. Instead of spam buying 1 at a times it divide the amount to buy in equal parts and buy in increments.
  • Much more

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/2006-Scape/2006Scape/pull/133 **Author:** [@Gptaqbc](https://github.com/Gptaqbc) **Created:** 11/3/2019 **Status:** ✅ Merged **Merged:** 11/4/2019 **Merged by:** [@dginovker](https://github.com/dginovker) **Base:** `master` ← **Head:** `Buy/Sell-X--Buying-loop-lagging-issue-fix--General-shop-using-fixes--Trading-amount-fix` --- ### 📝 Commits (4) - [`1c4be29`](https://github.com/2006-Scape/2006Scape/commit/1c4be29c0d84a36d9ac398aafa261cc823c038af) Update NpcHandler.class - [`db62ca1`](https://github.com/2006-Scape/2006Scape/commit/db62ca1a59aa9fd1d8996acfb1bb09ba5ee0664c) Update NpcHandler.java - [`8a0b9c3`](https://github.com/2006-Scape/2006Scape/commit/8a0b9c3483766134cbca4ef64bf584ea4cadf81c) Buy/Sell-X--Buying-loop-lagging-issue-fix--General-shop-using-fixes--Trading-amount-fix - [`6f2334f`](https://github.com/2006-Scape/2006Scape/commit/6f2334ffc41e19a0f7622f5c5e16bdf1e1702cd4) Merge remote-tracking branch 'upstream/master' into Buy/Sell-X--Buying-loop-lagging-issue-fix--General-shop-using-fixes--Trading-amount-fix ### 📊 Changes **8 files changed** (+200 additions, -112 deletions) <details> <summary>View changed files</summary> 📝 `2006Redone Client/src/RSInterface.java` (+8 -0) 📝 `2006Redone Server/src/redone/game/players/Player.java` (+4 -27) 📝 `2006Redone Server/src/redone/game/players/Trading.java` (+4 -1) 📝 `2006Redone Server/src/redone/game/shops/ShopAssistant.java` (+129 -31) 📝 `2006Redone Server/src/redone/net/packets/impl/Bank5.java` (+1 -1) 📝 `2006Redone Server/src/redone/net/packets/impl/BankAll.java` (+9 -3) 📝 `2006Redone Server/src/redone/net/packets/impl/BankX1.java` (+1 -9) 📝 `2006Redone Server/src/redone/net/packets/impl/BankX2.java` (+44 -40) </details> ### 📄 Description closes #107 Buying-loop-lagging-issue-fix--General-shop-using-fixes--Trading-amount-fix Trading-amount-fix - Added buy/sell X feature - Fixed a lag with the buying loop when buying high amount. Instead of spam buying 1 at a times it divide the amount to buy in equal parts and buy in increments. - Much more --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Dark98 added the pull-request label 2026-05-27 12:21:16 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Cannot Reproduce
Difficulty: Easy
Difficulty: Easy
Difficulty: Hard
Difficulty: Medium
Documentation
enhancement
Highest Priority of Type
New Content
New Content
pull-request
Mirrored from GitHub Pull Request
 QoL
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Dark98
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 2006-Scape/2006Scape#5214
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?