mirror of
https://github.com/2006-Scape/2006Scape.git
synced 2026-07-02 16:49:03 +00:00
[GH-ISSUE #115] When buying items all items disappear #5617
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @RedSparr0w on GitHub (Oct 26, 2019).
Original GitHub issue: https://github.com/2006-Scape/2006Scape/issues/115
When buying player sold items from a store (general store for example)
If you buy any amount of items, the whole stack will disappear.
@Gptaqbc commented on GitHub (Oct 26, 2019):
It only happens if the stack was sold using the sell all option IIRC
@RedSparr0w commented on GitHub (Oct 26, 2019):
seems to happen with any amount sold.
@Gptaqbc commented on GitHub (Oct 29, 2019):
Is it possible to merge that issue with the #107? I got this fixed in my work in progress.
@dginovker commented on GitHub (Oct 29, 2019):
Closed for #107
@RedSparr0w commented on GitHub (Oct 29, 2019):
You don't need to be assigned an issue to work on it 😄
When you create the PR what you would usually do is write the following:
Closes #107
Closes #115
Which would close the 2 issues once your PR is merged
Better to keep the issue open until they are actually fixed, otherwise they can get missed quite easily.
@Gptaqbc commented on GitHub (Oct 29, 2019):
It’s not that I want or need to be assigned. It’s that I dont want other contributors to start working on it while I am too. So no one is working for nothing a.k.a wasting our time.
@RedSparr0w commented on GitHub (Oct 29, 2019):
Yeah, once the comment is there other people should notice someone is already working on it, just saying better to keep the issues open until they are actually fixed.
@Gptaqbc commented on GitHub (Oct 29, 2019):
Oh yeah, that’s sure. Issues have to stay open until completely resolved. I just asked to merge 2 issues together because It was related to the same problem.
@RedSparr0w commented on GitHub (Oct 29, 2019):
But they are separate problems, they may be similar/have a similar fix, but they are quite different problems.
@Gptaqbc commented on GitHub (Oct 29, 2019):
What should I do then? I dont want someone working on that because it’s fixed on my side.
@RedSparr0w commented on GitHub (Oct 29, 2019):
Just comment here, and put it on your PR when you create it.
Basically the same thing you would do on the other issue.