2006-Scape/2006Scape
1
0
Fork 0
mirror of https://github.com/2006-Scape/2006Scape.git synced 2026-07-02 16:49:03 +00:00
Code Issues 4.5k Packages Projects Releases 10 Wiki Activity

[PR #382] [MERGED] A few things #6024

New Issue
Closed
opened 2026-05-28 12:21:34 +00:00 by Dark98 · 0 comments
Dark98 commented 2026-05-28 12:21:34 +00:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/2006-Scape/2006Scape/pull/382
Author: @mrextremez
Created: 3/3/2020
Status: ✅ Merged
Merged: 3/6/2020
Merged by: @dginovker

Base: master ← Head: whynot

📝 Commits (1)

📊 Changes

88 files changed (+2576 additions, -3268 deletions)

View changed files

📝 2006Redone Server/src/main/java/com/rebotted/GameConstants.java (+7 -120)
📝 2006Redone Server/src/main/java/com/rebotted/game/content/BankPin.java (+24 -24)
📝 2006Redone Server/src/main/java/com/rebotted/game/content/combat/CombatAssistant.java (+4 -3)
📝 2006Redone Server/src/main/java/com/rebotted/game/content/combat/magic/CastOnOther.java (+2 -2)
📝 2006Redone Server/src/main/java/com/rebotted/game/content/combat/magic/MagicSpells.java (+5 -8)
📝 2006Redone Server/src/main/java/com/rebotted/game/content/combat/magic/MagicTeleports.java (+10 -10)
📝 2006Redone Server/src/main/java/com/rebotted/game/content/combat/melee/MeleeData.java (+5 -8)
📝 2006Redone Server/src/main/java/com/rebotted/game/content/combat/prayer/ActivatePrayers.java (+2 -2)
📝 2006Redone Server/src/main/java/com/rebotted/game/content/combat/range/DwarfCannon.java (+3 -2)
📝 2006Redone Server/src/main/java/com/rebotted/game/content/consumables/Potions.java (+1 -1)
📝 2006Redone Server/src/main/java/com/rebotted/game/content/guilds/impl/RangersGuild.java (+16 -16)
📝 2006Redone Server/src/main/java/com/rebotted/game/content/minigames/Dueling.java (+28 -29)
📝 2006Redone Server/src/main/java/com/rebotted/game/content/minigames/FightPits.java (+4 -4)
📝 2006Redone Server/src/main/java/com/rebotted/game/content/minigames/MageArena.java (+5 -5)
📝 2006Redone Server/src/main/java/com/rebotted/game/content/minigames/castlewars/CastleWars.java (+7 -7)
📝 2006Redone Server/src/main/java/com/rebotted/game/content/minigames/trawler/Trawler.java (+4 -4)
📝 2006Redone Server/src/main/java/com/rebotted/game/content/music/PlayList.java (+4 -4)
📝 2006Redone Server/src/main/java/com/rebotted/game/content/quests/QuestAssistant.java (+44 -44)
📝 2006Redone Server/src/main/java/com/rebotted/game/content/quests/QuestRewards.java (+22 -22)
📝 2006Redone Server/src/main/java/com/rebotted/game/content/quests/impl/BlackKnightsFortress.java (+25 -25)

...and 68 more files

📄 Description

  • Added a distance check for item on object packet (should fix a runecrafting bug that recently came to my attention)
  • Added cook x functionality
  • Removed a fair amount of dead code
  • Did some renaming and fixed some typos
  • Cleaned up a lot of the smithing code
  • Added a new boundary system to reduce code clutter
  • Fixed a firemaking bug
  • Also moved all item constants to itemconstants.java

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/2006-Scape/2006Scape/pull/382 **Author:** [@mrextremez](https://github.com/mrextremez) **Created:** 3/3/2020 **Status:** ✅ Merged **Merged:** 3/6/2020 **Merged by:** [@dginovker](https://github.com/dginovker) **Base:** `master` ← **Head:** `whynot` --- ### 📝 Commits (1) - [`eac14a5`](https://github.com/2006-Scape/2006Scape/commit/eac14a5936c39637688c70257d62546e22fe645b) A few things ### 📊 Changes **88 files changed** (+2576 additions, -3268 deletions) <details> <summary>View changed files</summary> 📝 `2006Redone Server/src/main/java/com/rebotted/GameConstants.java` (+7 -120) 📝 `2006Redone Server/src/main/java/com/rebotted/game/content/BankPin.java` (+24 -24) 📝 `2006Redone Server/src/main/java/com/rebotted/game/content/combat/CombatAssistant.java` (+4 -3) 📝 `2006Redone Server/src/main/java/com/rebotted/game/content/combat/magic/CastOnOther.java` (+2 -2) 📝 `2006Redone Server/src/main/java/com/rebotted/game/content/combat/magic/MagicSpells.java` (+5 -8) 📝 `2006Redone Server/src/main/java/com/rebotted/game/content/combat/magic/MagicTeleports.java` (+10 -10) 📝 `2006Redone Server/src/main/java/com/rebotted/game/content/combat/melee/MeleeData.java` (+5 -8) 📝 `2006Redone Server/src/main/java/com/rebotted/game/content/combat/prayer/ActivatePrayers.java` (+2 -2) 📝 `2006Redone Server/src/main/java/com/rebotted/game/content/combat/range/DwarfCannon.java` (+3 -2) 📝 `2006Redone Server/src/main/java/com/rebotted/game/content/consumables/Potions.java` (+1 -1) 📝 `2006Redone Server/src/main/java/com/rebotted/game/content/guilds/impl/RangersGuild.java` (+16 -16) 📝 `2006Redone Server/src/main/java/com/rebotted/game/content/minigames/Dueling.java` (+28 -29) 📝 `2006Redone Server/src/main/java/com/rebotted/game/content/minigames/FightPits.java` (+4 -4) 📝 `2006Redone Server/src/main/java/com/rebotted/game/content/minigames/MageArena.java` (+5 -5) 📝 `2006Redone Server/src/main/java/com/rebotted/game/content/minigames/castlewars/CastleWars.java` (+7 -7) 📝 `2006Redone Server/src/main/java/com/rebotted/game/content/minigames/trawler/Trawler.java` (+4 -4) 📝 `2006Redone Server/src/main/java/com/rebotted/game/content/music/PlayList.java` (+4 -4) 📝 `2006Redone Server/src/main/java/com/rebotted/game/content/quests/QuestAssistant.java` (+44 -44) 📝 `2006Redone Server/src/main/java/com/rebotted/game/content/quests/QuestRewards.java` (+22 -22) 📝 `2006Redone Server/src/main/java/com/rebotted/game/content/quests/impl/BlackKnightsFortress.java` (+25 -25) _...and 68 more files_ </details> ### 📄 Description - Added a distance check for item on object packet (should fix a runecrafting bug that recently came to my attention) - Added cook x functionality - Removed a fair amount of dead code - Did some renaming and fixed some typos - Cleaned up a lot of the smithing code - Added a new boundary system to reduce code clutter - Fixed a firemaking bug - Also moved all item constants to itemconstants.java --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Dark98 added the pull-request label 2026-05-28 12:21:34 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Cannot Reproduce
Difficulty: Easy
Difficulty: Easy
Difficulty: Hard
Difficulty: Medium
Documentation
enhancement
Highest Priority of Type
New Content
New Content
pull-request
Mirrored from GitHub Pull Request
 QoL
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Dark98
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 2006-Scape/2006Scape#6024
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?