2006-Scape/2006Scape
1
0
Fork 0
mirror of https://github.com/2006-Scape/2006Scape.git synced 2026-07-02 16:49:03 +00:00
Code Issues 4.5k Packages Projects Releases 10 Wiki Activity

[PR #367] [MERGED] Convert item definitions into JSON form and fix shop prices #6694

New Issue
Closed
opened 2026-05-29 12:21:29 +00:00 by Dark98 · 0 comments
Dark98 commented 2026-05-29 12:21:29 +00:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/2006-Scape/2006Scape/pull/367
Author: @dginovker
Created: 1/21/2020
Status: ✅ Merged
Merged: 2/1/2020
Merged by: @dginovker

Base: master ← Head: convertitemdef

📝 Commits (4)

  • 847830c Created itemdef.json with same content as itemdefs.gsu. Still need to read from it
  • a051752 Converted a lot of IDs, not all
  • cff8497 All the runelocus shop items are in realshopvalues.json, all the old ones are in the regular json. Keeping this commit just in case something goes horribly, horribly wrong.
  • 8d30bd3 Verified shop values are correct

📊 Changes

446 files changed (+145009 additions, -94 deletions)

View changed files

➕ 2006Redone Server/com/rebotted/Connection.class (+0 -0)
➕ 2006Redone Server/com/rebotted/GameConstants.class (+0 -0)
➕ 2006Redone Server/com/rebotted/GameEngine.class (+0 -0)
➕ 2006Redone Server/com/rebotted/event/CycleEvent.class (+0 -0)
➕ 2006Redone Server/com/rebotted/event/CycleEventContainer.class (+0 -0)
➕ 2006Redone Server/com/rebotted/event/CycleEventHandler.class (+0 -0)
➕ 2006Redone Server/com/rebotted/game/bots/Bot$TradeChat.class (+0 -0)
➕ 2006Redone Server/com/rebotted/game/bots/Bot.class (+0 -0)
➕ 2006Redone Server/com/rebotted/game/bots/BotConstants.class (+0 -0)
➕ 2006Redone Server/com/rebotted/game/bots/BotHandler.class (+0 -0)
➕ 2006Redone Server/com/rebotted/game/content/BankPin.class (+0 -0)
➕ 2006Redone Server/com/rebotted/game/content/EmoteHandler$Emotes.class (+0 -0)
➕ 2006Redone Server/com/rebotted/game/content/EmoteHandler.class (+0 -0)
➕ 2006Redone Server/com/rebotted/game/content/combat/CombatAssistant.class (+0 -0)
➕ 2006Redone Server/com/rebotted/game/content/combat/CombatConstants.class (+0 -0)
➕ 2006Redone Server/com/rebotted/game/content/combat/Specials$specialAttack.class (+0 -0)
➕ 2006Redone Server/com/rebotted/game/content/combat/Specials.class (+0 -0)
➕ 2006Redone Server/com/rebotted/game/content/combat/magic/CastOnOther$1.class (+0 -0)
➕ 2006Redone Server/com/rebotted/game/content/combat/magic/CastOnOther.class (+0 -0)
➕ 2006Redone Server/com/rebotted/game/content/combat/magic/CastRequirements.class (+0 -0)

...and 80 more files

📄 Description

There were some shop items that were going for far too much.. This fixes that too!

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/2006-Scape/2006Scape/pull/367 **Author:** [@dginovker](https://github.com/dginovker) **Created:** 1/21/2020 **Status:** ✅ Merged **Merged:** 2/1/2020 **Merged by:** [@dginovker](https://github.com/dginovker) **Base:** `master` ← **Head:** `convertitemdef` --- ### 📝 Commits (4) - [`847830c`](https://github.com/2006-Scape/2006Scape/commit/847830c1047e841c8dbdafa11143fb5444bfb2df) Created itemdef.json with same content as itemdefs.gsu. Still need to read from it - [`a051752`](https://github.com/2006-Scape/2006Scape/commit/a05175210cddcb8f0f8da5636743a68f0aaa9439) Converted a lot of IDs, not all - [`cff8497`](https://github.com/2006-Scape/2006Scape/commit/cff8497684d4c669c9ad6ab10159d56fec8e206c) All the runelocus shop items are in realshopvalues.json, all the old ones are in the regular json. Keeping this commit just in case something goes horribly, horribly wrong. - [`8d30bd3`](https://github.com/2006-Scape/2006Scape/commit/8d30bd33c4fe8764abb3936e682b4ec35df86bb5) Verified shop values are correct ### 📊 Changes **446 files changed** (+145009 additions, -94 deletions) <details> <summary>View changed files</summary> ➕ `2006Redone Server/com/rebotted/Connection.class` (+0 -0) ➕ `2006Redone Server/com/rebotted/GameConstants.class` (+0 -0) ➕ `2006Redone Server/com/rebotted/GameEngine.class` (+0 -0) ➕ `2006Redone Server/com/rebotted/event/CycleEvent.class` (+0 -0) ➕ `2006Redone Server/com/rebotted/event/CycleEventContainer.class` (+0 -0) ➕ `2006Redone Server/com/rebotted/event/CycleEventHandler.class` (+0 -0) ➕ `2006Redone Server/com/rebotted/game/bots/Bot$TradeChat.class` (+0 -0) ➕ `2006Redone Server/com/rebotted/game/bots/Bot.class` (+0 -0) ➕ `2006Redone Server/com/rebotted/game/bots/BotConstants.class` (+0 -0) ➕ `2006Redone Server/com/rebotted/game/bots/BotHandler.class` (+0 -0) ➕ `2006Redone Server/com/rebotted/game/content/BankPin.class` (+0 -0) ➕ `2006Redone Server/com/rebotted/game/content/EmoteHandler$Emotes.class` (+0 -0) ➕ `2006Redone Server/com/rebotted/game/content/EmoteHandler.class` (+0 -0) ➕ `2006Redone Server/com/rebotted/game/content/combat/CombatAssistant.class` (+0 -0) ➕ `2006Redone Server/com/rebotted/game/content/combat/CombatConstants.class` (+0 -0) ➕ `2006Redone Server/com/rebotted/game/content/combat/Specials$specialAttack.class` (+0 -0) ➕ `2006Redone Server/com/rebotted/game/content/combat/Specials.class` (+0 -0) ➕ `2006Redone Server/com/rebotted/game/content/combat/magic/CastOnOther$1.class` (+0 -0) ➕ `2006Redone Server/com/rebotted/game/content/combat/magic/CastOnOther.class` (+0 -0) ➕ `2006Redone Server/com/rebotted/game/content/combat/magic/CastRequirements.class` (+0 -0) _...and 80 more files_ </details> ### 📄 Description There were some shop items that were going for far too much.. This fixes that too! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Dark98 added the pull-request label 2026-05-29 12:21:29 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Cannot Reproduce
Difficulty: Easy
Difficulty: Easy
Difficulty: Hard
Difficulty: Medium
Documentation
enhancement
Highest Priority of Type
New Content
New Content
pull-request
Mirrored from GitHub Pull Request
 QoL
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Dark98
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 2006-Scape/2006Scape#6694
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?