2006-Scape/2006Scape
1
0
Fork 0
mirror of https://github.com/2006-Scape/2006Scape.git synced 2026-07-02 16:49:03 +00:00
Code Issues 4.5k Packages Projects Releases 10 Wiki Activity

[GH-ISSUE #156] Trading issue "Other player is busy at the moment" #68

New Issue
Closed
opened 2026-05-15 02:56:01 +00:00 by Dark98 · 1 comment
Dark98 commented 2026-05-15 02:56:01 +00:00
Owner
Copy Link
Copy Source

Originally created by @Gptaqbc on GitHub (Nov 10, 2019).
Original GitHub issue: https://github.com/2006-Scape/2006Scape/issues/156

The message "Other player is busy at the moment" shows in chat when trying to trade a player in some context. I think if a player traded someone, the player can't trade another player because there is a var that isn't set properly after the initial trade.

Originally created by @Gptaqbc on GitHub (Nov 10, 2019). Original GitHub issue: https://github.com/2006-Scape/2006Scape/issues/156 The message "Other player is busy at the moment" shows in chat when trying to trade a player in some context. I think if a player traded someone, the player can't trade another player because there is a var that isn't set properly after the initial trade.
Dark98 commented 2026-05-15 02:56:01 +00:00
Author
Owner
Copy Link
Copy Source

@Gptaqbc commented on GitHub (Nov 15, 2019):

Changing this line(65) in Trading.java:

} else if (player.playerIsBusy() == false && o.playerIsBusy() == true) {

for this one:

} else if (player.playerIsBusy() == true || o.playerIsBusy() == true) {

Should fix the issue. Gotta try it to know if it works correctly though.

<!-- gh-comment-id:554423631 --> @Gptaqbc commented on GitHub (Nov 15, 2019): Changing this line(65) in Trading.java: > } else if (player.playerIsBusy() == false && o.playerIsBusy() == true) { for this one: > } else if (player.playerIsBusy() == true || o.playerIsBusy() == true) { Should fix the issue. Gotta try it to know if it works correctly though.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Cannot Reproduce
Difficulty: Easy
Difficulty: Easy
Difficulty: Hard
Difficulty: Medium
Documentation
enhancement
Highest Priority of Type
New Content
New Content
pull-request
Mirrored from GitHub Pull Request
 QoL
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Dark98
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 2006-Scape/2006Scape#68
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?