This is my first PR on this project, so any feedback is welcome :)
I've tested it locally and it works fine, it lets player to search for traps in chests, has cooldown with specific timers and rewards.
I've refactored some code in ThieveOther class (com.rs2.game.content.skills.thieving) and also addOrDropItem method in ItemAssistant class (com.rs2.game.items) to be able to drop item if player does not have stackable item and doesn't have space.
**Original Pull Request:** https://github.com/2006-Scape/2006Scape/pull/534
**State:** closed
**Merged:** Yes
---
This is my first PR on this project, so any feedback is welcome :)
I've tested it locally and it works fine, it lets player to search for traps in chests, has cooldown with specific timers and rewards.
I've refactored some code in ThieveOther class (com.rs2.game.content.skills.thieving) and also addOrDropItem method in ItemAssistant class (com.rs2.game.items) to be able to drop item if player does not have stackable item and doesn't have space.
Let me know what you think :)
I guess it could close this [issue](https://github.com/2006-Scape/2006Scape/issues/221)
Thank you
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Original Pull Request: https://github.com/2006-Scape/2006Scape/pull/534
State: closed
Merged: Yes
This is my first PR on this project, so any feedback is welcome :)
I've tested it locally and it works fine, it lets player to search for traps in chests, has cooldown with specific timers and rewards.
I've refactored some code in ThieveOther class (com.rs2.game.content.skills.thieving) and also addOrDropItem method in ItemAssistant class (com.rs2.game.items) to be able to drop item if player does not have stackable item and doesn't have space.
Let me know what you think :)
I guess it could close this issue
Thank you