2006-Scape/2006Scape
1
0
Fork 0
mirror of https://github.com/2006-Scape/2006Scape.git synced 2026-07-02 16:49:03 +00:00
Code Issues 4.5k Packages Projects Releases 10 Wiki Activity

[PR #611] [MERGED] Fix getLevelforXP methods #6885

New Issue
Closed
opened 2026-05-29 12:22:09 +00:00 by Dark98 · 0 comments
Dark98 commented 2026-05-29 12:22:09 +00:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/2006-Scape/2006Scape/pull/611
Author: @advnau
Created: 2/7/2023
Status: ✅ Merged
Merged: 2/7/2023
Merged by: @Dark98

Base: master ← Head: temp

📝 Commits (4)

📊 Changes

15 files changed (+112 additions, -135 deletions)

View changed files

📝 2006Scape Server/src/main/java/com/rs2/game/content/combat/CombatAssistant.java (+10 -10)
📝 2006Scape Server/src/main/java/com/rs2/game/content/combat/Specials.java (+1 -1)
📝 2006Scape Server/src/main/java/com/rs2/game/content/combat/magic/MagicMaxHit.java (+6 -6)
📝 2006Scape Server/src/main/java/com/rs2/game/content/combat/magic/MagicSpells.java (+1 -1)
📝 2006Scape Server/src/main/java/com/rs2/game/content/combat/melee/MeleeData.java (+11 -11)
📝 2006Scape Server/src/main/java/com/rs2/game/content/combat/melee/MeleeMaxHit.java (+1 -1)
📝 2006Scape Server/src/main/java/com/rs2/game/content/combat/npcs/NpcCombat.java (+1 -1)
📝 2006Scape Server/src/main/java/com/rs2/game/content/combat/range/RangeMaxHit.java (+6 -6)
📝 2006Scape Server/src/main/java/com/rs2/game/content/consumables/Beverages.java (+2 -2)
📝 2006Scape Server/src/main/java/com/rs2/game/content/consumables/Food.java (+3 -3)
📝 2006Scape Server/src/main/java/com/rs2/game/content/consumables/Kebabs.java (+11 -11)
📝 2006Scape Server/src/main/java/com/rs2/game/content/consumables/Potions.java (+22 -22)
📝 2006Scape Server/src/main/java/com/rs2/game/content/minigames/castlewars/CastleWars.java (+1 -1)
📝 2006Scape Server/src/main/java/com/rs2/game/players/Player.java (+16 -34)
📝 2006Scape Server/src/main/java/com/rs2/game/players/PlayerAssistant.java (+20 -25)

📄 Description

Fix for bug introduced with levelup in earlier PR. Only a single method is used for getting the level for XP. The method now also works more effectively. https://github.com/2006-Scape/2006Scape/commit/09068e31d34921fefe152b0aaab80e89f97bdaf3 is a summary of the changes to the methods

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/2006-Scape/2006Scape/pull/611 **Author:** [@advnau](https://github.com/advnau) **Created:** 2/7/2023 **Status:** ✅ Merged **Merged:** 2/7/2023 **Merged by:** [@Dark98](https://github.com/Dark98) **Base:** `master` ← **Head:** `temp` --- ### 📝 Commits (4) - [`d97c85a`](https://github.com/2006-Scape/2006Scape/commit/d97c85a766271fa129f7f9313f829b92172b5548) Use single method for level for XP - [`ea789ff`](https://github.com/2006-Scape/2006Scape/commit/ea789ff91d8c84c023acf1c7e33e9dbf9e6c78ba) redundant access - [`09068e3`](https://github.com/2006-Scape/2006Scape/commit/09068e31d34921fefe152b0aaab80e89f97bdaf3) New xp and level methods - [`b9123c4`](https://github.com/2006-Scape/2006Scape/commit/b9123c4f81a961e4ac1cc6376eafbac107b3050e) Removed test command ### 📊 Changes **15 files changed** (+112 additions, -135 deletions) <details> <summary>View changed files</summary> 📝 `2006Scape Server/src/main/java/com/rs2/game/content/combat/CombatAssistant.java` (+10 -10) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/combat/Specials.java` (+1 -1) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/combat/magic/MagicMaxHit.java` (+6 -6) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/combat/magic/MagicSpells.java` (+1 -1) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/combat/melee/MeleeData.java` (+11 -11) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/combat/melee/MeleeMaxHit.java` (+1 -1) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/combat/npcs/NpcCombat.java` (+1 -1) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/combat/range/RangeMaxHit.java` (+6 -6) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/consumables/Beverages.java` (+2 -2) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/consumables/Food.java` (+3 -3) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/consumables/Kebabs.java` (+11 -11) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/consumables/Potions.java` (+22 -22) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/minigames/castlewars/CastleWars.java` (+1 -1) 📝 `2006Scape Server/src/main/java/com/rs2/game/players/Player.java` (+16 -34) 📝 `2006Scape Server/src/main/java/com/rs2/game/players/PlayerAssistant.java` (+20 -25) </details> ### 📄 Description Fix for bug introduced with levelup in earlier PR. Only a single method is used for getting the level for XP. The method now also works more effectively. https://github.com/2006-Scape/2006Scape/commit/09068e31d34921fefe152b0aaab80e89f97bdaf3 is a summary of the changes to the methods --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Dark98 added the pull-request label 2026-05-29 12:22:09 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Cannot Reproduce
Difficulty: Easy
Difficulty: Easy
Difficulty: Hard
Difficulty: Medium
Documentation
enhancement
Highest Priority of Type
New Content
New Content
pull-request
Mirrored from GitHub Pull Request
 QoL
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Dark98
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 2006-Scape/2006Scape#6885
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?