2006-Scape/2006Scape
1
0
Fork 0
mirror of https://github.com/2006-Scape/2006Scape.git synced 2026-07-02 16:49:03 +00:00
Code Issues 4.5k Packages Projects Releases 10 Wiki Activity

[PR #669] [CLOSED] Codex/rename classes #6938

New Issue
Closed
opened 2026-05-29 12:22:20 +00:00 by Dark98 · 0 comments
Dark98 commented 2026-05-29 12:22:20 +00:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/2006-Scape/2006Scape/pull/669
Author: @Ddemon26
Created: 6/30/2025
Status: ❌ Closed

Base: master ← Head: codex/rename-classes

📝 Commits (10+)

  • e2ce83d Handle UTF-8 BOM in config loader and update .gitignore
  • 6f245c9 Remove version field from docker-compose.yml
  • a9b2d61 Add AGENTS.md with automated agent ruleset
  • 2387b4b Convert rule lists in AGENTS.md to bullet points
  • 9e77ea8 Update agent rules for offline Maven builds and renaming
  • a83f8cc Update renaming protocol for batch class refactors
  • 51030ba Add PR template for RuneBot contributions
  • 221c336 Add exception for large class renames in agent rules
  • 86e246a Update build/test requirements for Maven-based PRs
  • 0e1f8cc [BOT] refactor(rename): music control methods

📊 Changes

39 files changed (+1651 additions, -1332 deletions)

View changed files

➕ .github/PULL_REQUEST_TEMPLATE/bot.md (+61 -0)
📝 .gitignore (+1 -0)
➕ 2006Scape Client/src/main/java/AnimFrame.java (+142 -0)
📝 2006Scape Client/src/main/java/Animable.java (+1 -1)
📝 2006Scape Client/src/main/java/Animable_Sub3.java (+1 -1)
📝 2006Scape Client/src/main/java/Animable_Sub4.java (+1 -1)
📝 2006Scape Client/src/main/java/Animation.java (+6 -6)
➖ 2006Scape Client/src/main/java/Class18.java (+0 -28)
➖ 2006Scape Client/src/main/java/Class21.java (+0 -27)
➖ 2006Scape Client/src/main/java/Class29.java (+0 -64)
➖ 2006Scape Client/src/main/java/Class36.java (+0 -142)
➖ 2006Scape Client/src/main/java/Class39.java (+0 -117)
➖ 2006Scape Client/src/main/java/Class43.java (+0 -25)
📝 2006Scape Client/src/main/java/Class56.java (+14 -14)
📝 2006Scape Client/src/main/java/Class56_Sub1_Sub1.java (+9 -9)
📝 2006Scape Client/src/main/java/Class56_Sub1_Sub2.java (+8 -8)
➖ 2006Scape Client/src/main/java/Class6.java (+0 -305)
📝 2006Scape Client/src/main/java/Decompressor.java (+13 -13)
📝 2006Scape Client/src/main/java/EntityDef.java (+2 -2)
➕ 2006Scape Client/src/main/java/FrameBase.java (+26 -0)

...and 19 more files

📄 Description

This pull request introduces several changes across multiple files in the 2006Scape Client project, focusing on refactoring, cleanup, and replacing deprecated classes. Key updates include the removal of unused or outdated classes, the introduction of a new AnimFrame class to replace Class36, and renaming methods in Class56 for improved clarity.

Refactoring and Cleanup:

  • Removed unused classes: Deprecated classes such as Class18, Class21, Class29, Class36, Class39, and Class43 were removed to streamline the codebase. These classes were no longer necessary due to the introduction of AnimFrame. [1] [2] [3] [4] [5] [6]

  • Replaced Class36 with AnimFrame: The new AnimFrame class encapsulates animation frame logic and replaces the functionality previously handled by Class36. This includes methods for loading, clearing, and accessing animation frames.

Code Consistency and Clarity:

  • Method renaming in Class56: Abstract methods in Class56 were renamed for clarity, such as method827 → playMidi, method833 → stopMidi, and method831 → setVolume. These changes improve readability and better describe the methods' functionality. [1] [2] [3] [4]

  • Updated references to AnimFrame: Replaced calls to Class36 methods with the corresponding AnimFrame methods in related files, such as Animable_Sub3, Animable_Sub4, and Animation. For example, Class36.method532() was replaced with AnimFrame.isNullFrame(). [1] [2] [3]

Other Changes:

  • PR template for bot-generated pull requests: Added a new template for bot-generated pull requests to .github/PULL_REQUEST_TEMPLATE/bot.md. This template includes a checklist, rename-specific fields, and rollback plans to ensure quality and consistency in automated PRs.

These changes simplify the codebase, improve maintainability, and enhance clarity for developers working on the project.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/2006-Scape/2006Scape/pull/669 **Author:** [@Ddemon26](https://github.com/Ddemon26) **Created:** 6/30/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `codex/rename-classes` --- ### 📝 Commits (10+) - [`e2ce83d`](https://github.com/2006-Scape/2006Scape/commit/e2ce83d797b62e3e9dfce607976260f42a9d2696) Handle UTF-8 BOM in config loader and update .gitignore - [`6f245c9`](https://github.com/2006-Scape/2006Scape/commit/6f245c95a06f6f4b5405e3c3ae334cad29f80f6e) Remove version field from docker-compose.yml - [`a9b2d61`](https://github.com/2006-Scape/2006Scape/commit/a9b2d61520cffe68e3e871e127ca5b40f60e53a9) Add AGENTS.md with automated agent ruleset - [`2387b4b`](https://github.com/2006-Scape/2006Scape/commit/2387b4bb0dafda087db27232b9d3fc2eec62f7e4) Convert rule lists in AGENTS.md to bullet points - [`9e77ea8`](https://github.com/2006-Scape/2006Scape/commit/9e77ea865eb9b92202003c11bc780f577a4e201b) Update agent rules for offline Maven builds and renaming - [`a83f8cc`](https://github.com/2006-Scape/2006Scape/commit/a83f8cc22875ae0d7d6ac9cd46f84e1df2cae060) Update renaming protocol for batch class refactors - [`51030ba`](https://github.com/2006-Scape/2006Scape/commit/51030baf0c79b2b448ce0d25b3cdbb92e67dabdb) Add PR template for RuneBot contributions - [`221c336`](https://github.com/2006-Scape/2006Scape/commit/221c336e853778dd49b666b40a361ae3878c2da8) Add exception for large class renames in agent rules - [`86e246a`](https://github.com/2006-Scape/2006Scape/commit/86e246a2b492b6b7e536e4bbc5cca25ae39781f4) Update build/test requirements for Maven-based PRs - [`0e1f8cc`](https://github.com/2006-Scape/2006Scape/commit/0e1f8ccd3c2f37cbac1e2a75824333fd0322bd1d) [BOT] refactor(rename): music control methods ### 📊 Changes **39 files changed** (+1651 additions, -1332 deletions) <details> <summary>View changed files</summary> ➕ `.github/PULL_REQUEST_TEMPLATE/bot.md` (+61 -0) 📝 `.gitignore` (+1 -0) ➕ `2006Scape Client/src/main/java/AnimFrame.java` (+142 -0) 📝 `2006Scape Client/src/main/java/Animable.java` (+1 -1) 📝 `2006Scape Client/src/main/java/Animable_Sub3.java` (+1 -1) 📝 `2006Scape Client/src/main/java/Animable_Sub4.java` (+1 -1) 📝 `2006Scape Client/src/main/java/Animation.java` (+6 -6) ➖ `2006Scape Client/src/main/java/Class18.java` (+0 -28) ➖ `2006Scape Client/src/main/java/Class21.java` (+0 -27) ➖ `2006Scape Client/src/main/java/Class29.java` (+0 -64) ➖ `2006Scape Client/src/main/java/Class36.java` (+0 -142) ➖ `2006Scape Client/src/main/java/Class39.java` (+0 -117) ➖ `2006Scape Client/src/main/java/Class43.java` (+0 -25) 📝 `2006Scape Client/src/main/java/Class56.java` (+14 -14) 📝 `2006Scape Client/src/main/java/Class56_Sub1_Sub1.java` (+9 -9) 📝 `2006Scape Client/src/main/java/Class56_Sub1_Sub2.java` (+8 -8) ➖ `2006Scape Client/src/main/java/Class6.java` (+0 -305) 📝 `2006Scape Client/src/main/java/Decompressor.java` (+13 -13) 📝 `2006Scape Client/src/main/java/EntityDef.java` (+2 -2) ➕ `2006Scape Client/src/main/java/FrameBase.java` (+26 -0) _...and 19 more files_ </details> ### 📄 Description This pull request introduces several changes across multiple files in the `2006Scape Client` project, focusing on refactoring, cleanup, and replacing deprecated classes. Key updates include the removal of unused or outdated classes, the introduction of a new `AnimFrame` class to replace `Class36`, and renaming methods in `Class56` for improved clarity. ### Refactoring and Cleanup: * **Removed unused classes**: Deprecated classes such as `Class18`, `Class21`, `Class29`, `Class36`, `Class39`, and `Class43` were removed to streamline the codebase. These classes were no longer necessary due to the introduction of `AnimFrame`. [[1]](diffhunk://#diff-e3a7637a0579a81884f6904493849b9495ecf548bb949f7e76f5e0577b9e524dL1-L28) [[2]](diffhunk://#diff-53338b22b27a8aef197d9dda921db8ec6a899679e6e6813fe4790f20ce44dfe4L1-L27) [[3]](diffhunk://#diff-0c42985ff4d3be991acd0836bcc2297027a2a5a6a0d46318b9da87352bfb347cL1-L64) [[4]](diffhunk://#diff-0e0fe0a771c8d491e4da826b2d49bd39426ad2ba104571df2d21fb2070a46571L1-L142) [[5]](diffhunk://#diff-e864dbb8708ed2c3f0f86e20a875ab16dbeda40c3ddef7a447b2d84ea5f97bf5L1-L117) [[6]](diffhunk://#diff-b65c1ce4018923f53ed5ae01f91a10d38757b9df3bed3ca7ba01699366ba4ab5L1-L25) * **Replaced `Class36` with `AnimFrame`**: The new `AnimFrame` class encapsulates animation frame logic and replaces the functionality previously handled by `Class36`. This includes methods for loading, clearing, and accessing animation frames. ### Code Consistency and Clarity: * **Method renaming in `Class56`**: Abstract methods in `Class56` were renamed for clarity, such as `method827` → `playMidi`, `method833` → `stopMidi`, and `method831` → `setVolume`. These changes improve readability and better describe the methods' functionality. [[1]](diffhunk://#diff-189c74f06451718fb49ae668af7404a77a18c4484048a996643a139f5cd4a251L3-R17) [[2]](diffhunk://#diff-f68763837bfac592801923e316220114e3ab63571739c7c3e3efd08747810e6cL19-R19) [[3]](diffhunk://#diff-f68763837bfac592801923e316220114e3ab63571739c7c3e3efd08747810e6cL33-R33) [[4]](diffhunk://#diff-f68763837bfac592801923e316220114e3ab63571739c7c3e3efd08747810e6cL73-R79) * **Updated references to `AnimFrame`**: Replaced calls to `Class36` methods with the corresponding `AnimFrame` methods in related files, such as `Animable_Sub3`, `Animable_Sub4`, and `Animation`. For example, `Class36.method532()` was replaced with `AnimFrame.isNullFrame()`. [[1]](diffhunk://#diff-4eaee31aaf7feb9f3405a84333f0f7b5964cf668a3b4b147a3ff1fbd48431dc6L25-R25) [[2]](diffhunk://#diff-a3109a69ee40e4d4c01b74c2b35d75ac27f187e3671f5507dde8b8749437ce1fL36-R36) [[3]](diffhunk://#diff-a6e34fb5ca8b665bba5f0ad09db405059b081fa699ac1ca6dc75929a051b0fc8L24-R26) ### Other Changes: * **PR template for bot-generated pull requests**: Added a new template for bot-generated pull requests to `.github/PULL_REQUEST_TEMPLATE/bot.md`. This template includes a checklist, rename-specific fields, and rollback plans to ensure quality and consistency in automated PRs. These changes simplify the codebase, improve maintainability, and enhance clarity for developers working on the project. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Dark98 added the pull-request label 2026-05-29 12:22:20 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Cannot Reproduce
Difficulty: Easy
Difficulty: Easy
Difficulty: Hard
Difficulty: Medium
Documentation
enhancement
Highest Priority of Type
New Content
New Content
pull-request
Mirrored from GitHub Pull Request
 QoL
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Dark98
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 2006-Scape/2006Scape#6938
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?