2006-Scape/2006Scape
1
0
Fork 0
mirror of https://github.com/2006-Scape/2006Scape.git synced 2026-10-01 02:17:17 +00:00
Code Issues 4.5k Packages Projects Releases 10 Wiki Activity

[PR #502] [MERGED] Update server skill magic numbers #7512

New Issue
Closed
opened 2026-05-30 12:22:08 +00:00 by Dark98 · 0 comments
Dark98 commented 2026-05-30 12:22:08 +00:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/2006-Scape/2006Scape/pull/502
Author: @RedSparr0w
Created: 9/22/2021
Status: ✅ Merged
Merged: 9/23/2021
Merged by: @dginovker

Base: master ← Head: magic-numbers

📝 Commits (1)

  • 7fc59f2 Update server skill magic numbers

📊 Changes

91 files changed (+857 additions, -795 deletions)

View changed files

📝 2006Scape Server/src/main/java/com/rs2/GameConstants.java (+1 -1)
📝 2006Scape Server/src/main/java/com/rs2/game/content/combat/CombatAssistant.java (+86 -86)
📝 2006Scape Server/src/main/java/com/rs2/game/content/combat/Specials.java (+7 -5)
📝 2006Scape Server/src/main/java/com/rs2/game/content/combat/magic/CastRequirements.java (+2 -1)
📝 2006Scape Server/src/main/java/com/rs2/game/content/combat/magic/Enchanting.java (+4 -2)
📝 2006Scape Server/src/main/java/com/rs2/game/content/combat/magic/MagicMaxHit.java (+9 -8)
📝 2006Scape Server/src/main/java/com/rs2/game/content/combat/magic/MagicRequirements.java (+2 -1)
📝 2006Scape Server/src/main/java/com/rs2/game/content/combat/magic/MagicSpells.java (+13 -12)
📝 2006Scape Server/src/main/java/com/rs2/game/content/combat/magic/MagicTeleports.java (+3 -2)
📝 2006Scape Server/src/main/java/com/rs2/game/content/combat/melee/MeleeData.java (+14 -13)
📝 2006Scape Server/src/main/java/com/rs2/game/content/combat/melee/MeleeMaxHit.java (+4 -3)
📝 2006Scape Server/src/main/java/com/rs2/game/content/combat/npcs/NpcCombat.java (+16 -16)
📝 2006Scape Server/src/main/java/com/rs2/game/content/combat/prayer/ActivatePrayers.java (+5 -4)
📝 2006Scape Server/src/main/java/com/rs2/game/content/combat/prayer/PrayerDrain.java (+5 -4)
📝 2006Scape Server/src/main/java/com/rs2/game/content/combat/range/DwarfCannon.java (+4 -3)
📝 2006Scape Server/src/main/java/com/rs2/game/content/combat/range/RangeMaxHit.java (+10 -9)
📝 2006Scape Server/src/main/java/com/rs2/game/content/consumables/Beverages.java (+30 -29)
📝 2006Scape Server/src/main/java/com/rs2/game/content/consumables/Food.java (+26 -24)
📝 2006Scape Server/src/main/java/com/rs2/game/content/consumables/Kebabs.java (+23 -22)
📝 2006Scape Server/src/main/java/com/rs2/game/content/consumables/Potions.java (+26 -25)

...and 71 more files

📄 Description

Replace all the magic numbers with their corresponding GameConstants skills

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/2006-Scape/2006Scape/pull/502 **Author:** [@RedSparr0w](https://github.com/RedSparr0w) **Created:** 9/22/2021 **Status:** ✅ Merged **Merged:** 9/23/2021 **Merged by:** [@dginovker](https://github.com/dginovker) **Base:** `master` ← **Head:** `magic-numbers` --- ### 📝 Commits (1) - [`7fc59f2`](https://github.com/2006-Scape/2006Scape/commit/7fc59f214468a06bd69b5c4d0ab1d6351e7a3c1c) Update server skill magic numbers ### 📊 Changes **91 files changed** (+857 additions, -795 deletions) <details> <summary>View changed files</summary> 📝 `2006Scape Server/src/main/java/com/rs2/GameConstants.java` (+1 -1) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/combat/CombatAssistant.java` (+86 -86) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/combat/Specials.java` (+7 -5) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/combat/magic/CastRequirements.java` (+2 -1) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/combat/magic/Enchanting.java` (+4 -2) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/combat/magic/MagicMaxHit.java` (+9 -8) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/combat/magic/MagicRequirements.java` (+2 -1) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/combat/magic/MagicSpells.java` (+13 -12) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/combat/magic/MagicTeleports.java` (+3 -2) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/combat/melee/MeleeData.java` (+14 -13) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/combat/melee/MeleeMaxHit.java` (+4 -3) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/combat/npcs/NpcCombat.java` (+16 -16) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/combat/prayer/ActivatePrayers.java` (+5 -4) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/combat/prayer/PrayerDrain.java` (+5 -4) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/combat/range/DwarfCannon.java` (+4 -3) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/combat/range/RangeMaxHit.java` (+10 -9) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/consumables/Beverages.java` (+30 -29) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/consumables/Food.java` (+26 -24) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/consumables/Kebabs.java` (+23 -22) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/consumables/Potions.java` (+26 -25) _...and 71 more files_ </details> ### 📄 Description Replace all the magic numbers with their corresponding GameConstants skills --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Dark98 added the pull-request label 2026-05-30 12:22:08 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Cannot Reproduce
Difficulty: Easy
Difficulty: Easy
Difficulty: Hard
Difficulty: Medium
Documentation
Highest Priority of Type
New Content
New Content
QoL
enhancement
pull-request
Mirrored from GitHub Pull Request
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Dark98
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 2006-Scape/2006Scape#7512