2006-Scape/2006Scape
1
0
Fork 0
mirror of https://github.com/2006-Scape/2006Scape.git synced 2026-10-01 02:17:17 +00:00
Code Issues 4.5k Packages Projects Releases 10 Wiki Activity

[PR #619] [MERGED] Magic num nums #7588

New Issue
Closed
opened 2026-05-30 12:22:23 +00:00 by Dark98 · 0 comments
Dark98 commented 2026-05-30 12:22:23 +00:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/2006-Scape/2006Scape/pull/619
Author: @Dark98
Created: 2/9/2023
Status: ✅ Merged
Merged: 2/18/2023
Merged by: @Dark98

Base: master ← Head: magic-num-nums

📝 Commits (10+)

  • fd6cbd8 Update Libs
  • a2abe3e Replaced Some Magic Numbers
  • 5203959 Rename DWARF_REMAINS to NULL_0
  • 9f8b69d Food.java Rename DWARF_REMAINS to NULL_0
  • 995202d Kebabs.java static import
  • 7b2ef01 Kebabs.java IntelliJ Code Format
  • 316b16d Fix some fullmask item names
  • 2db7b6c Potions.java Replace Magic Numbers
  • c39b916 Potions.java IntelliJ Code Format
  • f186935 BattleStaffs.java Replaced Magic numbers

📊 Changes

8 files changed (+1108 additions, -1122 deletions)

View changed files

📝 2006Scape Server/pom.xml (+2 -2)
📝 2006Scape Server/src/main/java/com/rs2/game/content/StaticItemList.java (+1 -1)
📝 2006Scape Server/src/main/java/com/rs2/game/content/consumables/Food.java (+109 -109)
📝 2006Scape Server/src/main/java/com/rs2/game/content/consumables/Kebabs.java (+116 -116)
📝 2006Scape Server/src/main/java/com/rs2/game/content/consumables/Potions.java (+427 -447)
📝 2006Scape Server/src/main/java/com/rs2/game/content/skills/crafting/BattleStaffs.java (+87 -84)
📝 2006Scape Server/src/main/java/com/rs2/game/content/skills/crafting/CraftingData.java (+363 -360)
📝 2006Scape Server/src/main/java/com/rs2/game/items/ItemData.java (+3 -3)

📄 Description

No description provided

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/2006-Scape/2006Scape/pull/619 **Author:** [@Dark98](https://github.com/Dark98) **Created:** 2/9/2023 **Status:** ✅ Merged **Merged:** 2/18/2023 **Merged by:** [@Dark98](https://github.com/Dark98) **Base:** `master` ← **Head:** `magic-num-nums` --- ### 📝 Commits (10+) - [`fd6cbd8`](https://github.com/2006-Scape/2006Scape/commit/fd6cbd89750bf7dbc6577d2a515af68839ab1561) Update Libs - [`a2abe3e`](https://github.com/2006-Scape/2006Scape/commit/a2abe3effdb1e00345b8ad79d706b1860e4b0185) Replaced Some Magic Numbers - [`5203959`](https://github.com/2006-Scape/2006Scape/commit/52039590e51af21d2331096a1a717fd4c3ce55f4) Rename DWARF_REMAINS to NULL_0 - [`9f8b69d`](https://github.com/2006-Scape/2006Scape/commit/9f8b69da137520557cac590ae479b7c1a40f2915) Food.java Rename DWARF_REMAINS to NULL_0 - [`995202d`](https://github.com/2006-Scape/2006Scape/commit/995202da04e65a5f0adca1033de4a2e5f352507d) Kebabs.java static import - [`7b2ef01`](https://github.com/2006-Scape/2006Scape/commit/7b2ef0109472c01f090faa0e73ad0bb355ec405d) Kebabs.java IntelliJ Code Format - [`316b16d`](https://github.com/2006-Scape/2006Scape/commit/316b16de1aabd2023ae998bb94163fd17370ea06) Fix some fullmask item names - [`2db7b6c`](https://github.com/2006-Scape/2006Scape/commit/2db7b6c5e202d63f58a5a5da50a78fcab86be8a3) Potions.java Replace Magic Numbers - [`c39b916`](https://github.com/2006-Scape/2006Scape/commit/c39b9167cff580ea41c1da27128a4a578a245a40) Potions.java IntelliJ Code Format - [`f186935`](https://github.com/2006-Scape/2006Scape/commit/f186935c9782687b60c3ee56bd1b6ba16185aef9) BattleStaffs.java Replaced Magic numbers ### 📊 Changes **8 files changed** (+1108 additions, -1122 deletions) <details> <summary>View changed files</summary> 📝 `2006Scape Server/pom.xml` (+2 -2) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/StaticItemList.java` (+1 -1) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/consumables/Food.java` (+109 -109) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/consumables/Kebabs.java` (+116 -116) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/consumables/Potions.java` (+427 -447) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/skills/crafting/BattleStaffs.java` (+87 -84) 📝 `2006Scape Server/src/main/java/com/rs2/game/content/skills/crafting/CraftingData.java` (+363 -360) 📝 `2006Scape Server/src/main/java/com/rs2/game/items/ItemData.java` (+3 -3) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Dark98 added the pull-request label 2026-05-30 12:22:23 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Cannot Reproduce
Difficulty: Easy
Difficulty: Easy
Difficulty: Hard
Difficulty: Medium
Documentation
Highest Priority of Type
New Content
New Content
QoL
enhancement
pull-request
Mirrored from GitHub Pull Request
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Dark98
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 2006-Scape/2006Scape#7588