Originally created by @dginovker on GitHub (Oct 25, 2019).
Original GitHub issue: https://github.com/2006-Scape/2006Scape/issues/107
Originally assigned to: @Gptaqbc on GitHub.
& When buying items all items disappear
You got any hint about where I have to look? Looking for Sell 10 doesn't give anything.
<!-- gh-comment-id:546741339 -->
@Gptaqbc commented on GitHub (Oct 27, 2019):
You got any hint about where I have to look? Looking for Sell 10 doesn't give anything.
Not sure sorry, haven't looked into any of the client sided things yet.
<!-- gh-comment-id:546741391 -->
@RedSparr0w commented on GitHub (Oct 27, 2019):
Not sure sorry, haven't looked into any of the client sided things yet.
Code to modify: around line 108...
This add a sell all option... it needs some work done though.
if(rsInterface.parentID == shop interface id) rsInterface.itemActions[buy all menu action number] = "Sell All";
<!-- gh-comment-id:546745356 -->
@Gptaqbc commented on GitHub (Oct 27, 2019):
RSInterface.java
Sell 1 → 1
Sell 5 → 10
Sell 10 → All
Code to modify: around line 108...
This add a sell all option... it needs some work done though.
if(rsInterface.parentID == shop interface id) rsInterface.itemActions[buy all menu action number] = "Sell All";
Fix selling options that currently only sells 1 at a time; -Done
Add sell all feature for non-stackable items; -Done
Fix amount of gp received when selling more than 1;
Replaced noted items in shops for un-noted version; -Done
Implement Sell X - Server side; -Done
Fix buy/sell delay(loop) that causes lags; -Done
(Some of these issues are also happening with trading)
<!-- gh-comment-id:546752673 -->
@Gptaqbc commented on GitHub (Oct 28, 2019):
To do:
1. Replace Buy 10 by buy X - Server side; -Done
2. Fix selling options that currently only sells 1 at a time; -Done
3. Add sell all feature for non-stackable items; -Done
4. Fix amount of gp received when selling more than 1;
5. Replaced noted items in shops for un-noted version; -Done
6. Implement Sell X - Server side; -Done
7. Fix buy/sell delay(loop) that causes lags; -Done
(Some of these issues are also happening with trading)
Not sure what you mean by 2?
I'm pretty sure we replaced the loop that it used to use.
<!-- gh-comment-id:546752770 -->
@RedSparr0w commented on GitHub (Oct 28, 2019):
Not sure what you mean by `2`?
I'm pretty sure we replaced the loop that it used to use.
@RedSparr0w Yeah it needed some work because it was causing lag when buying more than a couple item at once.
<!-- gh-comment-id:548773950 -->
@Gptaqbc commented on GitHub (Nov 1, 2019):
@RedSparr0w Yeah it needed some work because it was causing lag when buying more than a couple item at once.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Originally created by @dginovker on GitHub (Oct 25, 2019).
Original GitHub issue: https://github.com/2006-Scape/2006Scape/issues/107
Originally assigned to: @Gptaqbc on GitHub.
& When buying items all items disappear
@Gptaqbc commented on GitHub (Oct 27, 2019):
What do you mean by string needs to be fixed?
@RedSparr0w commented on GitHub (Oct 27, 2019):
Menu item needs to be modified:
Sell 5->Sell 10Sell 10→Sell All@Gptaqbc commented on GitHub (Oct 27, 2019):
Oh alright. I'll do that!
@Gptaqbc commented on GitHub (Oct 27, 2019):
You got any hint about where I have to look? Looking for Sell 10 doesn't give anything.
@RedSparr0w commented on GitHub (Oct 27, 2019):
Not sure sorry, haven't looked into any of the client sided things yet.
@Gptaqbc commented on GitHub (Oct 27, 2019):
RSInterface.java
Sell 1 → 1
Sell 5 → 10
Sell 10 → All
Code to modify: around line 108...
This add a sell all option... it needs some work done though.
if(rsInterface.parentID == shop interface id) rsInterface.itemActions[buy all menu action number] = "Sell All";
@Gptaqbc commented on GitHub (Oct 28, 2019):
To do:
(Some of these issues are also happening with trading)
@RedSparr0w commented on GitHub (Oct 28, 2019):
Not sure what you mean by
2?I'm pretty sure we replaced the loop that it used to use.
@Gptaqbc commented on GitHub (Nov 1, 2019):
@RedSparr0w Yeah it needed some work because it was causing lag when buying more than a couple item at once.