2006-Scape/2006Scape
1
0
Fork 0
mirror of https://github.com/2006-Scape/2006Scape.git synced 2026-07-02 16:49:03 +00:00
Code Issues 4.5k Packages Projects Releases 10 Wiki Activity

[GH-ISSUE #194] Shouldn't be able to sell to a shop when there is not empty slot in the shop interface. #7733

New Issue
Closed
opened 2026-05-31 12:20:17 +00:00 by Dark98 · 4 comments
Dark98 commented 2026-05-31 12:20:17 +00:00
Owner
Copy Link
Copy Source

Originally created by @Gptaqbc on GitHub (Nov 18, 2019).
Original GitHub issue: https://github.com/2006-Scape/2006Scape/issues/194

As of right now you can sell more than max capacity and it causes any player that uses the store to disconnect.

Originally created by @Gptaqbc on GitHub (Nov 18, 2019). Original GitHub issue: https://github.com/2006-Scape/2006Scape/issues/194 As of right now you can sell more than max capacity and it causes any player that uses the store to disconnect.
Dark98 commented 2026-05-31 12:20:18 +00:00
Author
Owner
Copy Link
Copy Source

@Gptaqbc commented on GitHub (Nov 18, 2019):

Working on it!

Edit: Fixed it so now it wont disconnect the player. But it still need a lot of work to resolve the issue.

<!-- gh-comment-id:555181909 --> @Gptaqbc commented on GitHub (Nov 18, 2019): Working on it! Edit: Fixed it so now it wont disconnect the player. But it still need a lot of work to resolve the issue.
Dark98 commented 2026-05-31 12:20:18 +00:00
Author
Owner
Copy Link
Copy Source

@mrextremez commented on GitHub (Nov 22, 2019):

What work is left to be done? @Gptaqbc

<!-- gh-comment-id:557342808 --> @mrextremez commented on GitHub (Nov 22, 2019): What work is left to be done? @Gptaqbc
Dark98 commented 2026-05-31 12:20:18 +00:00
Author
Owner
Copy Link
Copy Source

@Gptaqbc commented on GitHub (Nov 22, 2019):

Code must be added to prevent players from selling items to shops when it's full and not already in shop.

The tricky part I saw was that you have to check the shop if the items is already in a slot.

<!-- gh-comment-id:557637360 --> @Gptaqbc commented on GitHub (Nov 22, 2019): Code must be added to prevent players from selling items to shops when it's full and not already in shop. The tricky part I saw was that you have to check the shop if the items is already in a slot.
Dark98 commented 2026-05-31 12:20:18 +00:00
Author
Owner
Copy Link
Copy Source

@RedSparr0w commented on GitHub (Dec 12, 2019):

This should be fixed by PR #idontknowthenumber

<!-- gh-comment-id:565210140 --> @RedSparr0w commented on GitHub (Dec 12, 2019): This should be fixed by PR #idontknowthenumber
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Cannot Reproduce
Difficulty: Easy
Difficulty: Easy
Difficulty: Hard
Difficulty: Medium
Documentation
enhancement
Highest Priority of Type
New Content
New Content
pull-request
Mirrored from GitHub Pull Request
 QoL
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Dark98
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 2006-Scape/2006Scape#7733
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?