mirror of
https://github.com/2006-Scape/2006Scape.git
synced 2026-07-02 16:49:03 +00:00
[GH-ISSUE #175] Player can no-clip when the "Loading please wait..." message is shown. #785
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Gptaqbc on GitHub (Nov 11, 2019).
Original GitHub issue: https://github.com/2006-Scape/2006Scape/issues/175
@Gptaqbc commented on GitHub (Nov 11, 2019):
@JetF0x is that right?
@JetF0x commented on GitHub (Nov 11, 2019):
Looks correct @Gptaqbc
@Gptaqbc commented on GitHub (Nov 14, 2019):
We need server-side verification to stop that from happening. Because we got a couple problem related to the ::clip command. A player could make a custom client and abuse the ::clip command as of right now.
A server-side verification would:
@dginovker commented on GitHub (Dec 10, 2019):
Found a solution thanks to Ethan from Parabot: https://pastebin.com/A9CbYZ2r
@dginovker commented on GitHub (Dec 18, 2019):
We seem to have this solution implemented already for following 🤔. You can't noclip when following someone, the same logic just needs to be added for regular walking
edit: Code for reference that doesn't allow clipping: https://github.com/dginovker/2006rebotted/blob/d876a923b9d14410b4d8b860239ea4462dd6243a/2006Redone%20Server/src/com/rebotted/world/clip/PathFinder.java
Thanks again to Ethan from Parabot for this. There's a lot less to do than it seems, we just change the function call.