2006-Scape/2006Scape
1
0
Fork 0
mirror of https://github.com/2006-Scape/2006Scape.git synced 2026-07-02 16:49:03 +00:00
Code Issues 4.5k Packages Projects Releases 10 Wiki Activity

[PR #381] [MERGED] Fix for issue #364 - staffs are now supported when enchanting jewellery #8098

New Issue
Closed
opened 2026-05-31 12:21:52 +00:00 by Dark98 · 0 comments
Dark98 commented 2026-05-31 12:21:52 +00:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/2006-Scape/2006Scape/pull/381
Author: @nocommento
Created: 2/28/2020
Status: ✅ Merged
Merged: 2/28/2020
Merged by: @dginovker

Base: master ← Head: enchant_with_staff_fix

📝 Commits (2)

  • abaa0f5 Added staff support when enchanting (issue #364)
  • 2a8c2f9 Added staff support when enchanting (issue #364)

📊 Changes

1 file changed (+18 additions, -37 deletions)

View changed files

📝 2006Redone Server/src/main/java/com/rebotted/game/content/combat/magic/Enchanting.java (+18 -37)

📄 Description

first pr pls be gentle, pretty much just changed it to use the hasRunes and deleteRunes functions from the CastRequirements class and fixed a bug where the 3rd requirement wouldn't get removed.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/2006-Scape/2006Scape/pull/381 **Author:** [@nocommento](https://github.com/nocommento) **Created:** 2/28/2020 **Status:** ✅ Merged **Merged:** 2/28/2020 **Merged by:** [@dginovker](https://github.com/dginovker) **Base:** `master` ← **Head:** `enchant_with_staff_fix` --- ### 📝 Commits (2) - [`abaa0f5`](https://github.com/2006-Scape/2006Scape/commit/abaa0f57426d586b9a027544e3a870ec568c1e8e) Added staff support when enchanting (issue #364) - [`2a8c2f9`](https://github.com/2006-Scape/2006Scape/commit/2a8c2f95be46cfe2cd4b14f6ebb94db3bfda73df) Added staff support when enchanting (issue #364) ### 📊 Changes **1 file changed** (+18 additions, -37 deletions) <details> <summary>View changed files</summary> 📝 `2006Redone Server/src/main/java/com/rebotted/game/content/combat/magic/Enchanting.java` (+18 -37) </details> ### 📄 Description first pr pls be gentle, pretty much just changed it to use the `hasRunes` and `deleteRunes` functions from the `CastRequirements` class and fixed a bug where the 3rd requirement wouldn't get removed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Dark98 added the pull-request label 2026-05-31 12:21:52 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Cannot Reproduce
Difficulty: Easy
Difficulty: Easy
Difficulty: Hard
Difficulty: Medium
Documentation
enhancement
Highest Priority of Type
New Content
New Content
pull-request
Mirrored from GitHub Pull Request
 QoL
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Dark98
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 2006-Scape/2006Scape#8098
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?