2006-Scape/2006Scape
1
0
Fork 0
mirror of https://github.com/2006-Scape/2006Scape.git synced 2026-07-02 16:49:03 +00:00
Code Issues 4.5k Packages Projects Releases 10 Wiki Activity

[PR #517] [CLOSED] Convert Dialogues To Plugins #8949

New Issue
Closed
opened 2026-06-01 12:22:38 +00:00 by Dark98 · 0 comments
Dark98 commented 2026-06-01 12:22:38 +00:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/2006-Scape/2006Scape/pull/517
Author: @Dark98
Created: 11/11/2021
Status: ❌ Closed

Base: master ← Head: plugins_dialogue

📝 Commits (10+)

  • 45450db Start Setting Up Second World
  • ccc0353 Small Cleanup For World 2 Support
  • 00932b8 Woops Wrong Ports
  • 8fc1e17 Merge branch 'master' into world2
  • 8ab3177 Set Server Port After Loading Config
  • bdd5297 Add xpRate Var & Include With XPRate Calculations
  • 8a10201 Add -w/-world arg to client
  • 38140d8 Add XP Rate Multiplier For Non-Bot Worlds
  • d2faea6 More Multi World Stuff
  • 5c02c34 Add Kick Command To Discord Bot & Fix Type In ConfigLoader

📊 Changes

55 files changed (+2389 additions, -8286 deletions)

View changed files

📝 2006Scape Client/src/main/java/ClientSettings.java (+16 -4)
📝 2006Scape Client/src/main/java/Game.java (+31 -20)
📝 2006Scape Client/src/main/java/Main.java (+14 -3)
📝 2006Scape Server/ServerConfig.Sample.json (+5 -2)
📝 2006Scape Server/data/cache/main_file_cache.dat (+0 -0)
📝 2006Scape Server/data/cache/main_file_cache.idx0 (+0 -0)
➖ 2006Scape Server/data/discord.json (+0 -1)
➕ 2006Scape Server/plugins/plugin/buttons/DialogueOptionButtons.kt (+41 -0)
➕ 2006Scape Server/plugins/plugin/npc/banker/BankerDialogue.kt (+37 -0)
➕ 2006Scape Server/plugins/plugin/npc/banker/FirstClick.kt (+32 -0)
📝 2006Scape Server/plugins/plugin/npc/manwoman/FirstClick.kt (+9 -16)
➕ 2006Scape Server/plugins/plugin/npc/manwoman/ManWomanDialogue.kt (+163 -0)
➕ 2006Scape Server/plugins/plugin/quests/cooksassistant/FirstClick.kt (+26 -0)
➕ 2006Scape Server/plugins/plugin/quests/cooksassistant/dialogue/LumbridgeCookDialogue.kt (+151 -0)
📝 2006Scape Server/src/main/java/com/rs2/ConfigLoader.java (+15 -2)
📝 2006Scape Server/src/main/java/com/rs2/GameConstants.java (+11 -18)
📝 2006Scape Server/src/main/java/com/rs2/GameEngine.java (+1 -4)
➖ 2006Scape Server/src/main/java/com/rs2/game/content/combat/npcs/StaticNpcList.java (+0 -7735)
➕ 2006Scape Server/src/main/java/com/rs2/game/dialogues/ChainablePlugin.java (+14 -0)
📝 2006Scape Server/src/main/java/com/rs2/game/dialogues/ChatEmotes.java (+6 -1)

...and 35 more files

📄 Description

Converts Dialogues To Use The Plugin Based Dialogue System From Astraeus.

Currently Done:
Banker(Most Of Them, Possibly A Couple Missed)
Man/Woman

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/2006-Scape/2006Scape/pull/517 **Author:** [@Dark98](https://github.com/Dark98) **Created:** 11/11/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `plugins_dialogue` --- ### 📝 Commits (10+) - [`45450db`](https://github.com/2006-Scape/2006Scape/commit/45450dbb9ce395e768ea798b9df8c1fc44518ad2) Start Setting Up Second World - [`ccc0353`](https://github.com/2006-Scape/2006Scape/commit/ccc0353bad40dfd937e60e3c6cf52d36c91efde9) Small Cleanup For World 2 Support - [`00932b8`](https://github.com/2006-Scape/2006Scape/commit/00932b82ee8fc3da5820bebd9006779babaa667b) Woops Wrong Ports - [`8fc1e17`](https://github.com/2006-Scape/2006Scape/commit/8fc1e17a25a1b56f59a548818ff4bf6d74513693) Merge branch 'master' into world2 - [`8ab3177`](https://github.com/2006-Scape/2006Scape/commit/8ab31771b3a4234521f1e8ba4e13b6d103d1a88a) Set Server Port After Loading Config - [`bdd5297`](https://github.com/2006-Scape/2006Scape/commit/bdd5297a94cd38d88c1295e180b05f8ab0432a66) Add xpRate Var & Include With XPRate Calculations - [`8a10201`](https://github.com/2006-Scape/2006Scape/commit/8a102016374be271eac4234127a8638d059e2160) Add -w/-world arg to client - [`38140d8`](https://github.com/2006-Scape/2006Scape/commit/38140d8665879063e7c177feb9c37612d9dfdf82) Add XP Rate Multiplier For Non-Bot Worlds - [`d2faea6`](https://github.com/2006-Scape/2006Scape/commit/d2faea6f71b9bdb0011bd315fcb0a219316de216) More Multi World Stuff - [`5c02c34`](https://github.com/2006-Scape/2006Scape/commit/5c02c345693f12ffba8bda006eb14a5cc0b0e738) Add Kick Command To Discord Bot & Fix Type In ConfigLoader ### 📊 Changes **55 files changed** (+2389 additions, -8286 deletions) <details> <summary>View changed files</summary> 📝 `2006Scape Client/src/main/java/ClientSettings.java` (+16 -4) 📝 `2006Scape Client/src/main/java/Game.java` (+31 -20) 📝 `2006Scape Client/src/main/java/Main.java` (+14 -3) 📝 `2006Scape Server/ServerConfig.Sample.json` (+5 -2) 📝 `2006Scape Server/data/cache/main_file_cache.dat` (+0 -0) 📝 `2006Scape Server/data/cache/main_file_cache.idx0` (+0 -0) ➖ `2006Scape Server/data/discord.json` (+0 -1) ➕ `2006Scape Server/plugins/plugin/buttons/DialogueOptionButtons.kt` (+41 -0) ➕ `2006Scape Server/plugins/plugin/npc/banker/BankerDialogue.kt` (+37 -0) ➕ `2006Scape Server/plugins/plugin/npc/banker/FirstClick.kt` (+32 -0) 📝 `2006Scape Server/plugins/plugin/npc/manwoman/FirstClick.kt` (+9 -16) ➕ `2006Scape Server/plugins/plugin/npc/manwoman/ManWomanDialogue.kt` (+163 -0) ➕ `2006Scape Server/plugins/plugin/quests/cooksassistant/FirstClick.kt` (+26 -0) ➕ `2006Scape Server/plugins/plugin/quests/cooksassistant/dialogue/LumbridgeCookDialogue.kt` (+151 -0) 📝 `2006Scape Server/src/main/java/com/rs2/ConfigLoader.java` (+15 -2) 📝 `2006Scape Server/src/main/java/com/rs2/GameConstants.java` (+11 -18) 📝 `2006Scape Server/src/main/java/com/rs2/GameEngine.java` (+1 -4) ➖ `2006Scape Server/src/main/java/com/rs2/game/content/combat/npcs/StaticNpcList.java` (+0 -7735) ➕ `2006Scape Server/src/main/java/com/rs2/game/dialogues/ChainablePlugin.java` (+14 -0) 📝 `2006Scape Server/src/main/java/com/rs2/game/dialogues/ChatEmotes.java` (+6 -1) _...and 35 more files_ </details> ### 📄 Description Converts Dialogues To Use The Plugin Based Dialogue System From Astraeus. Currently Done: Banker(Most Of Them, Possibly A Couple Missed) Man/Woman --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Dark98 added the pull-request label 2026-06-01 12:22:38 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Cannot Reproduce
Difficulty: Easy
Difficulty: Easy
Difficulty: Hard
Difficulty: Medium
Documentation
enhancement
Highest Priority of Type
New Content
New Content
pull-request
Mirrored from GitHub Pull Request
 QoL
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Dark98
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 2006-Scape/2006Scape#8949
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?