This cleans up the definitions for Items and Objects to cleanup the cache loaders and to also allow the loading of most Item Definition data from the cache. In the processing of this PR, some bugs were fixed with the Thieving skill where rewards for pickpocketing and stall thieving were given based off of item name but there was a typo so the reward wouldnt be given.
To the reviewer, should we move the minutes.log file from data/data to data/logs?
**Original Pull Request:** https://github.com/2006-Scape/2006Scape/pull/585
**State:** closed
**Merged:** Yes
---
This cleans up the definitions for Items and Objects to cleanup the cache loaders and to also allow the loading of most Item Definition data from the cache. In the processing of this PR, some bugs were fixed with the Thieving skill where rewards for pickpocketing and stall thieving were given based off of item name but there was a typo so the reward wouldnt be given.
To the reviewer, should we move the minutes.log file from data/data to data/logs?
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Original Pull Request: https://github.com/2006-Scape/2006Scape/pull/585
State: closed
Merged: Yes
This cleans up the definitions for Items and Objects to cleanup the cache loaders and to also allow the loading of most Item Definition data from the cache. In the processing of this PR, some bugs were fixed with the Thieving skill where rewards for pickpocketing and stall thieving were given based off of item name but there was a typo so the reward wouldnt be given.
To the reviewer, should we move the minutes.log file from data/data to data/logs?