From aa4590ff12cc17612768fe7300515ae7d3a20af9 Mon Sep 17 00:00:00 2001 From: Shadowrs Date: Thu, 18 Oct 2018 01:51:04 +0100 Subject: [PATCH 1/3] Clarify -debug CLI flag docs --- src/main/java/org/parabot/Landing.java | 1 + src/main/java/org/parabot/core/Core.java | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/parabot/Landing.java b/src/main/java/org/parabot/Landing.java index ed3efc2..f3cb7f9 100644 --- a/src/main/java/org/parabot/Landing.java +++ b/src/main/java/org/parabot/Landing.java @@ -73,6 +73,7 @@ public final class Landing { System.exit(0); break; case "-debug": + case "-offlinemode": Core.setDebug(true); break; case "-v": diff --git a/src/main/java/org/parabot/core/Core.java b/src/main/java/org/parabot/core/Core.java index 7e17c12..86c4fd4 100644 --- a/src/main/java/org/parabot/core/Core.java +++ b/src/main/java/org/parabot/core/Core.java @@ -72,7 +72,7 @@ public class Core { } /** - * Enabled debug mode + * Set debug mode AKA Offline Mode. If true, BDN login will be skipped, so BDN Servers or Scripts will be unavailable. * * @param debug */ @@ -104,7 +104,7 @@ public class Core { } /** - * @return if the client is in debug mode. + * @return if the client is in debug mode AKA Offline Mode. BDN Servers and Scripts are unavailable. */ public static boolean inDebugMode() { return debug; From e2aa5cdfe26b4c901446c8fdc4960f5598d230c2 Mon Sep 17 00:00:00 2001 From: Shadowrs Date: Thu, 18 Oct 2018 01:51:30 +0100 Subject: [PATCH 2/3] Add verbose prints for version & checksum info --- src/main/java/org/parabot/core/Core.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/main/java/org/parabot/core/Core.java b/src/main/java/org/parabot/core/Core.java index 86c4fd4..7e17f1a 100644 --- a/src/main/java/org/parabot/core/Core.java +++ b/src/main/java/org/parabot/core/Core.java @@ -170,7 +170,9 @@ public class Core { String result; if ((result = WebUtil.getContents(String.format(Configuration.COMPARE_CHECKSUM_URL, "client", currentVersion.get()), "checksum=" + URLEncoder.encode(sb.toString(), "UTF-8"))) != null) { JSONObject object = (JSONObject) WebUtil.getJsonParser().parse(result); - return (boolean) object.get("result"); + boolean upToDate = (boolean) object.get("result"); + Core.verbose("Local checksum: " + URLEncoder.encode(sb.toString(), "UTF-8") + ". " + (upToDate ? "This matches BDN and is up to date." : "BDN mismatch, must be Out Of Date.")); + return upToDate; } } } catch (NoSuchAlgorithmException | ParseException | IOException | URISyntaxException e) { @@ -196,6 +198,7 @@ public class Core { if (!latest) { Directories.clearCache(); } + Core.verbose("Local version: " + currentVersion.get() + ". " + (latest ? "This is up to date." : "This is Out Of Date. Cache will be cleared.")); return latest; } } catch (IOException | ParseException e) { From 9f4f56fa34251efcdbd6476efbf670cf123b242a Mon Sep 17 00:00:00 2001 From: Shadowrs Date: Thu, 18 Oct 2018 01:54:17 +0100 Subject: [PATCH 3/3] Clarify doc --- src/main/java/org/parabot/core/Core.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/parabot/core/Core.java b/src/main/java/org/parabot/core/Core.java index 7e17f1a..0688108 100644 --- a/src/main/java/org/parabot/core/Core.java +++ b/src/main/java/org/parabot/core/Core.java @@ -29,7 +29,7 @@ import java.security.NoSuchAlgorithmException; public class Core { private static int quickLaunchByUuid = -1; // used like -server, but denoted by an Int rather than the server name - private static boolean debug; // in debug mode, we will print more detailed error messages. + private static boolean debug; // Debug mode is Offline Mode. No BDN connection for Servers/Scripts/User Login. Not related to debug messages. private static boolean verbose; private static boolean dump; private static boolean loadLocal; //Loads both local and public scripts/servers