Update CowKiller Premade Script

Added More Inventory Checks To Stop The Script Being Weird
Repackaged A Bit
Updated Script Descriptions
Lowered Waiting Time In Openlummybank Script

.github/workflows/maven.yml

@@ -1,34 +0,0 @@
-# This workflow will build a Java project with Maven, and cache/restore any dependencies to improve the workflow execution time
-# For more information see: https://help.github.com/actions/language-and-framework-guides/building-and-testing-java-with-maven
-
-name: Java CI with Maven
-
-on:
-  push:
-    branches: [ master ]
-  pull_request:
-    branches: [ master ]
-
-jobs:
-  build:
-
-    runs-on: ubuntu-latest
-
-    steps:
-    - uses: actions/checkout@v2
-    - name: Set up JDK 8
-      uses: actions/setup-java@v2
-      with:
-        java-version: '8'
-        distribution: 'adopt'
-        cache: maven
-    - name: Build with Maven
-      run: mvn -B package --file pom.xml
-    - name: tag-version
-      # You may pin to the exact commit or the version.
-      # uses: juliansangillo/tag-version@0ca10cb901a4e3273715c4443e5dec5ad8f40328
-      uses: juliansangillo/tag-version@v1.5
-    - name: GitHub Releases
-      # You may pin to the exact commit or the version.
-      # uses: fnkr/github-action-ghr@96b1448dc6162f370067e1de51e856e733a76b4f
-      uses: fnkr/github-action-ghr@v1.3

src/main/java/scriptfactory/AdvancedGui/ScriptFactorySDN/ScriptFactoryScript.java

@@ -1,8 +1,10 @@
 package scriptfactory.AdvancedGui.ScriptFactorySDN;
 
-import scriptfactory.AdvancedGui.ScriptFactorySDN.Scripts.Cowkiller;
 import org.parabot.core.desc.ScriptDescription;
 import org.parabot.environment.scripts.Category;
+import scriptfactory.AdvancedGui.ScriptFactorySDN.Scripts.Combat.CowkillerBanking;
+import scriptfactory.AdvancedGui.ScriptFactorySDN.Scripts.Deps.Openlummybank;
+import scriptfactory.AdvancedGui.ScriptFactorySDN.Scripts.Deps.Walktocows;
 
 public class ScriptFactoryScript extends ScriptDescription {
 
@@ -23,9 +25,12 @@ public class ScriptFactoryScript extends ScriptDescription {
 
     public static ScriptFactoryScript[] getDescriptions() {
         return new ScriptFactoryScript[]{
-                new Cowkiller(),
+                //Scripts
-                new Cowkiller.Walktocows(),
+                new CowkillerBanking(),
-                new Cowkiller.Openlummybank(),
+                //new ArdyCakes(),
+                //Deps
+                new Walktocows(),
+                new Openlummybank(),
         };
     }
 

src/main/java/scriptfactory/AdvancedGui/ScriptFactorySDN/Scripts/Combat/CowkillerBanking.java

@@ -0,0 +1,42 @@
+package scriptfactory.AdvancedGui.ScriptFactorySDN.Scripts.Combat;
+
+import scriptfactory.AdvancedGui.ScriptFactorySDN.ScriptFactoryScript;
+import org.parabot.environment.scripts.Category;
+
+public class CowkillerBanking extends ScriptFactoryScript {
+    public CowkillerBanking() {
+        super(
+                "Cow killer (with banking)",
+                "Before",
+                Category.COMBAT,
+                1.1,
+                "Kills Cows In Lumbridge And Banks In The Castle \n Set Tick Speed To 1000 For Best Results \n Can Be Started Anywhere",
+                "If Inventory-slots-used(28)\n" +
+                        "Run-subscript(Openlummybank)\n" +
+                        "Bank-all-except-IDs()\n" +
+                        "Run-subscript(Walktocows)\n" +
+                        "Endif\n" +
+                        "IfNot In-Combat()\n" +
+                        "If Entity-is-around(81,397,1767,1768)\n" +
+                        "Take-Ground-item(2132)\n" +
+                        "Take-Ground-item(526)\n" +
+                        "Take-Ground-item(1739)\n" +
+                        "If Inventory-slots-used(28)\n" +
+                        "Run-subscript(Openlummybank)\n" +
+                        "Bank-all-except-IDs()\n" +
+                        "Run-subscript(Walktocows)\n" +
+                        "Endif\n" +
+                        "Interact-with-entity-by-ID(81,397,1767,1768,1)\n" +
+                        "Endif\n" +
+                        "IfNot Entity-is-around(81,397,1767,1768)\n" +
+                        "If Inventory-slots-used(28)\n" +
+                        "Run-subscript(Openlummybank)\n" +
+                        "Bank-all-except-IDs()\n" +
+                        "Endif\n" +
+                        "Run-subscript(Walktocows)\n" +
+                        "Endif\n" +
+                        "Endif\n",
+                new String[]{"Walktocows", "Openlummybank"}
+        );
+    }
+}

src/main/java/scriptfactory/AdvancedGui/ScriptFactorySDN/Scripts/Cowkiller.java

@@ -1,81 +0,0 @@
-package scriptfactory.AdvancedGui.ScriptFactorySDN.Scripts;
-
-import scriptfactory.AdvancedGui.ScriptFactorySDN.ScriptFactoryScript;
-import org.parabot.environment.scripts.Category;
-
-public class Cowkiller extends ScriptFactoryScript {
-    public Cowkiller() {
-        super(
-                "Cow killer (with banking)",
-                "Before",
-                Category.COMBAT,
-                1.0,
-                "Kills cows in lumbridge and banks in the castle",
-                "If Inventory-slots-used(28)\n" +
-                        "Run-subscript(Openlummybank)\n" +
-                        "Bank-all-except-IDs()\n" +
-                        "Run-subscript(Walktocows)\n" +
-                        "Endif\n" +
-                        "IfNot In-Combat()\n" +
-                        "If Entity-is-around(81,397,1767,1768)\n" +
-                        "Take-Ground-item(2132)\n" +
-                        "Take-Ground-item(526)\n" +
-                        "Take-Ground-item(1739)\n" +
-                        "Interact-with-entity-by-ID(81,397,1767,1768,1)\n" +
-                        "Endif\n" +
-                        "IfNot Entity-is-around(81,397,1767,1768)\n" +
-                        "Run-subscript(Walktocows)\n" +
-                        "Endif\n" +
-                        "Endif\n",
-                new String[]{"Walktocows", "Openlummybank"}
-        );
-    }
-
-    public static class Walktocows extends ScriptFactoryScript
-    {
-        public Walktocows() {
-            super(
-                    "Walktocows",
-                    "Before",
-                    "Dependency",
-                    1.0,
-                    "Walks to the cows in lumbridge from anywhere",
-                    "IfNot Entity-is-around(81,397,1767,1768)\n" +
-                            "Type(::stuck,1)\n" +
-                            "Sleep(1500)\n" +
-                            "Walk-to(3241,3226,14000)\n" +
-                            "Walk-to(3259,3233,14000)\n" +
-                            "Walk-to(3256,3250,14000)\n" +
-                            "Walk-to(3252,3266,14000)\n" +
-                            "Interact-with-entity-by-location(3253,3266,1)\n" +
-                            "Walk-to(3258,3268,5000)\n" +
-                            "Endif\n",
-                    new String[]{}
-            );
-        }
-    }
-
-    public static class Openlummybank extends ScriptFactoryScript
-    {
-        public Openlummybank() {
-            super(
-                    "Openlummybank",
-                    "Before",
-                    "Dependency",
-                    1.0,
-                    "Opens the bank in lumbridge castle from anywhere",
-                    "Type(::stuck,1)\n" +
-                            "Sleep(1500)\n" +
-                            "Interact-with-entity-by-location(3217,3218,1)\n" +
-                            "Interact-with-entity-by-location(3215,3211,1)\n" +
-                            "Interact-with-entity-by-location(3204,3207,1)\n" +
-                            "Sleep(15000)\n" +
-                            "Interact-with-entity-by-location(3204,3207,1)\n" +
-                            "Interact-with-entity-by-location(3204,3207,2)\n" +
-                            "Interact-with-entity-by-ID(494,3)\n" +
-                            "Sleep(6000)\n",
-                    new String[]{}
-            );
-        }
-    }
-}

src/main/java/scriptfactory/AdvancedGui/ScriptFactorySDN/Scripts/Deps/Openlummybank.java

@@ -0,0 +1,27 @@
+package scriptfactory.AdvancedGui.ScriptFactorySDN.Scripts.Deps;
+
+import scriptfactory.AdvancedGui.ScriptFactorySDN.ScriptFactoryScript;
+
+public class Openlummybank extends ScriptFactoryScript
+{
+    public Openlummybank() {
+        super(
+                "Openlummybank",
+                "Before",
+                "Dependency",
+                1.1,
+                "Opens the bank in lumbridge castle from anywhere",
+                "Type(::stuck,1)\n" +
+                        "Sleep(1500)\n" +
+                        "Interact-with-entity-by-location(3217,3218,1)\n" +
+                        "Interact-with-entity-by-location(3215,3211,1)\n" +
+                        "Interact-with-entity-by-location(3204,3207,1)\n" +
+                        "Sleep(12000)\n" +
+                        "Interact-with-entity-by-location(3204,3207,1)\n" +
+                        "Interact-with-entity-by-location(3204,3207,2)\n" +
+                        "Interact-with-entity-by-ID(494,3)\n" +
+                        "Sleep(6000)\n",
+                new String[]{}
+        );
+    }
+}

src/main/java/scriptfactory/AdvancedGui/ScriptFactorySDN/Scripts/Deps/Walktocows.java

@@ -0,0 +1,27 @@
+package scriptfactory.AdvancedGui.ScriptFactorySDN.Scripts.Deps;
+
+import scriptfactory.AdvancedGui.ScriptFactorySDN.ScriptFactoryScript;
+
+public class Walktocows extends ScriptFactoryScript
+{
+    public Walktocows() {
+        super(
+                "Walktocows",
+                "Before",
+                "Dependency",
+                1.0,
+                "Walks to the cows in lumbridge from anywhere",
+                "IfNot Entity-is-around(81,397,1767,1768)\n" +
+                        "Type(::stuck,1)\n" +
+                        "Sleep(1500)\n" +
+                        "Walk-to(3241,3226,14000)\n" +
+                        "Walk-to(3259,3233,14000)\n" +
+                        "Walk-to(3256,3250,14000)\n" +
+                        "Walk-to(3252,3266,14000)\n" +
+                        "Interact-with-entity-by-location(3253,3266,1)\n" +
+                        "Walk-to(3258,3268,5000)\n" +
+                        "Endif\n",
+                new String[]{}
+        );
+    }
+}

src/main/java/scriptfactory/AdvancedGui/ScriptFactorySDN/Scripts/Thieving/ArdyCakesBanking.java

@@ -1,16 +1,16 @@
-package scriptfactory.AdvancedGui.ScriptFactorySDN.Scripts;
+package scriptfactory.AdvancedGui.ScriptFactorySDN.Scripts.Thieving;
 
 import org.parabot.environment.scripts.Category;
 import scriptfactory.AdvancedGui.ScriptFactorySDN.ScriptFactoryScript;
 
-public class ArdyCakes extends ScriptFactoryScript {
+public class ArdyCakesBanking extends ScriptFactoryScript {
-    public ArdyCakes() {
+    public ArdyCakesBanking() {
         super(
                 "ArdyCakes (with banking)",
                 "Maui",
                 Category.THIEVING,
                 1.0,
-                "Steals cakes in Ardy",
+                "Steals cakes in Ardy \n Start Next To Ardy Cake Stalls",
                 "If Inventory-slots-used(28)\n" +
                         "IfNot Entity-is-around(494)\n" +
                         "Walk-to(2655,3286,35000)\n" +