Add item on item decoder; minor mining changes.

data/plugins/bank/bank.rb

@@ -30,4 +30,4 @@ on :event, :object_action do |ctx, player, event|
   end
 end
 
-# TODO: when we have NPCs/dialogue, also respond to clicking on them
+# TODO: when we have NPCs/dialogue, also respond to clicking on them

data/plugins/cmd-teleport/teleport.rb

@@ -16,4 +16,4 @@ on :command, :tele, RIGHTS_ADMIN do |player, command|
   else
     player.send_message "Syntax: ::tele [x] [y] [z=0]"
   end
-end
+end

data/plugins/logout/logout.rb

@@ -2,4 +2,4 @@ LOGOUT_BUTTON_ID = 2458
 
 on :button, LOGOUT_BUTTON_ID do |player|
   player.logout
-end
+end

data/plugins/mining/gem.rb

@@ -16,4 +16,4 @@ end
 append_gem(Gemstone.new(1623, 0)) # uncut sapphire
 append_gem(Gemstone.new(1605, 0)) # uncut emerald
 append_gem(Gemstone.new(1619, 0)) # uncut ruby
-append_gem(Gemstone.new(1617, 0)) # uncut diamond
+append_gem(Gemstone.new(1617, 0)) # uncut diamond

data/plugins/mining/mining.rb

@@ -160,4 +160,4 @@ on :event, :object_action do |ctx, player, event|
       end
     end
   end
-end
+end

data/plugins/mining/ore.rb

@@ -93,4 +93,4 @@ append_ore Ore.new(449,  ADAMANT_OBJECTS, 70, 95,   800 ) # adamant ore
 append_ore Ore.new(451,  RUNITE_OBJECTS,  85, 125,  2500) # runite ore
 
 # TODO: rune essence object id = 2491
-#   level 1, exp 5, rune ess = 1436, pure ess = 7936
+#   level 1, exp 5, rune ess = 1436, pure ess = 7936

data/plugins/mining/pickaxe.rb

@@ -28,4 +28,4 @@ append_pickaxe(Pickaxe.new(1273, 21, 629, 5)) # mithril pickaxe
 append_pickaxe(Pickaxe.new(1271, 31, 628, 4)) # adamant pickaxe
 append_pickaxe(Pickaxe.new(1275, 41, 624, 3)) # rune pickaxe
 
-PICKAXE_IDS.reverse!
+PICKAXE_IDS.reverse!

data/plugins/mining/respawn.rb

@@ -1,5 +1,3 @@
-MAX_PLAYERS = 2000 # TODO: obtain from a Java class
-
 # Calculates the number of pulses it takes for an ore to respawn based on the
 # number of players currently online.
 #
@@ -14,5 +12,5 @@ MAX_PLAYERS = 2000 # TODO: obtain from a Java class
 # function. The rest of the mining plugin rounds the base respawn times in
 # pulses down where appropriate.
 def respawn_pulses(base, players)
-  base - players * base / (MAX_PLAYERS * 2)
-end
+  base - players * base / (World.world.player_repository.size * 2)
+end