Dark98/threeSD
1
0
Fork 0
mirror of https://github.com/Dark98/threeSD.git synced 2026-07-04 00:38:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve error handling.

Browse Source 
Do not cancel the entire process when an error occurs. Instead, return a list of failed contents.
This commit is contained in:
zhupengfei
2020-05-16 15:13:52 +08:00
parent 4391845185
commit 1c28fff725
4 changed files with 38 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/core/inner_fat.cpp
+12
View File
@@ -22,6 +22,10 @@ bool InnerFAT::IsGood() const {
}
bool InnerFAT::ExtractDirectory(const std::string& path, std::size_t index) const {
if (index >= directory_entry_table.size()) {
LOG_ERROR(Core, "Index out of bound {}", index);
return false;
}
auto entry = directory_entry_table[index];
std::array<char, 17> name_data = {}; // Append a null terminator
@@ -152,6 +156,10 @@ bool SDSavegame::ExtractFile(const std::string& path, std::size_t index) const {
return false;
}
if (index >= file_entry_table.size()) {
LOG_ERROR(Core, "Index out of bound {}", index);
return false;
}
auto entry = file_entry_table[index];
std::array<char, 17> name_data = {}; // Append a null terminator
@@ -305,6 +313,10 @@ bool SDExtdata::ExtractFile(const std::string& path, std::size_t index) const {
/// Maximum amount of device files a device directory can hold.
constexpr u32 DeviceDirCapacity = 126;
if (index >= file_entry_table.size()) {
LOG_ERROR(Core, "Index out of bound {}", index);
return false;
}
auto entry = file_entry_table[index];
std::array<char, 17> name_data = {}; // Append a null terminator