Created by: puremana
- Replace get NPC name associate array method to indexed array method
The current code uses a GetNpcName
method which incorrectly assumes that the NPC List is an associate array where the ID is the index. This is not the case as the index is actually incremental.
While I would have rather changed the NPC List to be an associate array, as in the future writing code like this is not scalable for thousands of people on each server with thousands of NPC's, however that would require a rewrite of other methods too.
I found this issue when I attempted to kill Giant Mole which has an ID of 3340 but an array index of 2773. There is no npc with the index of 3340 so it crashed the server.